all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Davis Herring" <herring@lanl.gov>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Reading char choices
Date: Fri, 7 Jan 2011 09:16:40 -0800 (PST)	[thread overview]
Message-ID: <45079.130.55.118.19.1294420600.squirrel@webmail.lanl.gov> (raw)
In-Reply-To: <871v4ohesj.fsf@stupidchicken.com>

>       (message "%s" prompt)
>       (setq char (read-event))

Couldn't we pass the prompt to read-event?  Also, how does this inhibit
quitting out of the whole function?

> 		((eq (key-binding (vector char)) 'keyboard-quit)
> 		 (if inhibit-keyboard-quit (keyboard-quit)))

If I'm missing something and we really do inhibit quitting, surely this
should be (unless inhibit-keyboard-quit ...).

> 		((setq done (memq char chars))))))

So if it's not valid, we just ignore it.  Would we rather display a
message (as for `y-or-n-p'), at least optionally?

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.



  reply	other threads:[~2011-01-07 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-07 16:14 Reading char choices Chong Yidong
2011-01-07 17:16 ` Davis Herring [this message]
2011-01-08 19:35   ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45079.130.55.118.19.1294420600.squirrel@webmail.lanl.gov \
    --to=herring@lanl.gov \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.