From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#36448: 26.2; doc string of `highlight-lines-matching-regexp' Date: Sun, 30 Jun 2019 13:40:10 -0700 (PDT) Message-ID: <44e129fa-f290-4376-af26-adbe5837fa22@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109547"; mail-complaints-to="usenet@blaine.gmane.org" To: 36448@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 30 22:41:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhgdW-000SM4-Gy for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 22:41:22 +0200 Original-Received: from localhost ([::1]:46416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhgdU-0007KW-46 for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 16:41:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34901) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhgdE-0007KE-MG for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhgdC-0005or-OI for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhgdC-0005nu-14 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhgdB-0005se-U3 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2019 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36448 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156192722222539 (code B ref -1); Sun, 30 Jun 2019 20:41:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jun 2019 20:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:47340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhgcY-0005rT-9c for submit@debbugs.gnu.org; Sun, 30 Jun 2019 16:40:22 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhgcV-0005rK-7s for submit@debbugs.gnu.org; Sun, 30 Jun 2019 16:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34805) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhgcT-0007Ay-Sz for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhgcS-0005D2-OU for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:17 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:57146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhgcR-0005AI-De for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 16:40:16 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5UKdOYO078687 for ; Sun, 30 Jun 2019 20:40:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=wmyX7TUgpDiFRF/ETBAPJ8KEEx8YqIGwpyUREe4IMLI=; b=zSHdkVSuyziXpgSvJju6WIkTL/vCeC72FKIq+cUXG++c5EDcjkN44mrArIMGvIW3hrD5 yGT7Bhodywdzwr3mMAyxzfap6rStHkiKzR2SaRVdvH3ZnjJtuhmMWeDiFNrQ1X50g2ex m9FMUrgHToj6nHaNzbqeAOx+jiwc+kRmoQZg98n6a+SrlIluNfl2m+LLkWYUD5uPwcLm 3duwwaEq2/Q2BgMFvZ3zKncJtGF1Qmam0PefIyXSMgMpXeE6+xEZnbkxVRXrDwL69nUx u4MqPaJFXCLOORQpMqxn/7ffKAMgyFWwRlRO2pyejXorvnyUumJ2ZttWzK3kZQqJFZ5c ow== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2te61dtes4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 30 Jun 2019 20:40:12 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5UKcG5V195447 for ; Sun, 30 Jun 2019 20:40:11 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2tebbhvx0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 30 Jun 2019 20:40:11 +0000 Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5UKeBmu003984 for ; Sun, 30 Jun 2019 20:40:11 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9304 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906300266 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9304 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906300266 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161909 Archived-At: This part of the doc string is not so good: Set face of all lines containing a match of REGEXP to FACE. That's not what happens - "set" is the wrong verb here (face attributes are set, but not the displayed face as a whole). For example, if `font-lock-mode' is enabled and the command highlights a line that contains text already highlighted by font-lock (e.g. with a face foreground attribute) then the `highlight-lines-matching-regexp' highlighting adds its face to the `face' spec for that already highlighted text. It does not replace face attributes that are already set there. The doc string should just say something similar to what (elisp) `Highlight Interactively' says: Highlight entire lines containing a match for REGEXP, using face FACE ('highlight-lines-matching-regexp'). Highlighting "using" FACE is less definitive (more vague) than "setting" the face to FACE. If the doc string wants to go into more detail then it can say that FACE is _added_ to faces already present, or that its attributes are added merged with those already present. In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''