From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72986: Disabling menu-bar-mode changes size of new frames Date: Fri, 6 Sep 2024 16:16:18 +0200 Message-ID: <44e0648e-b374-4816-8f3b-6948af471ab1@gmx.at> References: <86ttex6iv0.fsf@gnu.org> <062bf084-741b-4d60-b9de-c62d62a79807@gmx.at> <7b6a5b97-fb0c-4eb0-a5b8-78b6ad5002d9@gmx.at> <7be33291-1828-41a6-bd56-759db2f533ee@gmx.at> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25820"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Po Lu , Eli Zaretskii , 72986@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 06 16:17:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smZm5-0006YT-P1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Sep 2024 16:17:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smZls-0004p1-0g; Fri, 06 Sep 2024 10:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smZlo-0004XP-BN for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2024 10:17:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smZlo-0005RF-2I for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2024 10:17:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=1mjg9+gApsLhfM6cdMYGUu4YtOQyp2jDPc7ETCQyBoE=; b=jPzfgbNApUBGMZXVGShUJYUXOAb99osBI8HYp57zv1Sv1NtQyFpKyqgluBj3IOyMfKT26k1spw4z4LerAwS0Ej/slKfJU72hf5e7CJ1ykz7sRetQDB36RBwo35eiZTykd89tJE8yGh35T5/iSpghwW5/C3sDEp8p6H8KSqaBWFcU+6bQP99DUFiK16Mn411mwHW9ZRyLlTFGh+JDz92HzpGs2pht0+e1n1quxsw8SVbahyeTz+tWEs4ZWf1Ql2O11xr27DPC1DKgjy5ZzSUlBWvo7IOSp+6ThmjvFi4yVAsiM5Km3CCodnldjSCVS8wKQDeHe8NB6ERUo/P+d+lnkg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smZlm-00022j-Fq for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2024 10:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Sep 2024 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72986 X-GNU-PR-Package: emacs Original-Received: via spool by 72986-submit@debbugs.gnu.org id=B72986.17256322017812 (code B ref 72986); Fri, 06 Sep 2024 14:17:02 +0000 Original-Received: (at 72986) by debbugs.gnu.org; 6 Sep 2024 14:16:41 +0000 Original-Received: from localhost ([127.0.0.1]:53709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smZlR-00021w-CO for submit@debbugs.gnu.org; Fri, 06 Sep 2024 10:16:41 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:33329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smZlO-00021h-Og for 72986@debbugs.gnu.org; Fri, 06 Sep 2024 10:16:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1725632184; x=1726236984; i=rudalics@gmx.at; bh=1mjg9+gApsLhfM6cdMYGUu4YtOQyp2jDPc7ETCQyBoE=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=XJGqLnEszfROJhkew04odnMg4deN2yx6ss1IvTlpoU1nibG3MjxPfeuNRaqxeJmS 6GEM57Dub8JuBnMhoxOZYK8aFfCQwaiWLJjwl6WQdMVqC3ZmlGHAXSE9b5I4Jip41 gnsLvK/gSaf6xzxyFLgE+ILh+s9SMlGidHEE6af6a8jsGfflwS16taX9Up+VtOZWJ jexJToPA9mq9oDKHVIU97SDesyHd9kEEEY9PxJTQAyNBrZ4phfBQ1JlfcH1VZCqh/ k7kvRamiNK6DJfkUMTXV5iA0BpIDg13lMNaa2PgTqKxcfeCUlX6Gsvnng7AzIZhYV Jmuqntz0AphfvvVL6g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([46.125.249.118]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxDkm-1rpOUa1iXo-00xZDL; Fri, 06 Sep 2024 16:16:24 +0200 Content-Language: en-US In-Reply-To: X-Provags-ID: V03:K1:Zr7i0zCZ3Biot6yOps1rzbBOodDPR4c59NhDSlIrlq+xkAaT997 sPSG3H/cgLYL6ircPuey0NyWodrOu5I75EU+G2Sd4bT3howlOguWkT9OWuRmmmiD8aT1zzD LKxJAB5ZyDYdl59hfKLKdDuxGoE+fRhAWhykXCjP8Ma5uXSmdtmA62OoTNB7qHUHpiANuvj DtI/imI84X9n/0Fc8owkQ== UI-OutboundReport: notjunk:1;M01:P0:che4HHHHCNM=;Vl/ktNcM1gyWsObYX78ydCL0+JZ UzL4tdE2vD20ssS0QRI+2/FaVkSvQFTLRoCUQ5j0bWzMtn3uHkFdnHTnY03QMNzoEDiKaFGbO EgvzTSebP0ovA6tFu5LO5t6bni02lwJNXoOMDYzRb5iyxq5oWussFAjJ5pmMjn9YuapfF4pqj XleJRul7n1/CYERkPJrr8YZwvM1Tf2Kpky/BaqqvCDjTxSSPCncy4hAwFEswth33/rE2YQwMD D4Jm5rv3u8cN6R+LIvI+8oCdMLICV0y+jBviw18hGo76fFwTmqYoxV0FJnxj2OxJJ5VMfRlyO SCyopimD1EapcDZaBuXf1Y+fbPlfw1xdcqgKFd5tv/icTRo8xaWRquEhnwfi0Q1XKSVs4RsVL 26S39935C6WSnv2Lgkt4AkVx5QWlERFl5iAKE92XIts3V5geu70vpLTOVi9HFhb70mmIWF1fJ v9Z++SKhdx8zZR43eNbLeIOZFRLsiS9L1eA7l5gseHnWPtZgVAPtKOBs5jigwQbm6msiP0AVB dA2dhXY75URaClcYN57P5TX6h6K+NufTrVOnJwwGNIU9Mchdy89BP30XZipfFkzvMcRclDUoQ lQxwrhfOBpsZRkzK92gwtlIvtQpgIJUfTIfQZiYWU3mvE8qCfgTz/9dOETPcKfZSaKPL821T0 mTgy6F00ZcOdnBF9IlPDEvdA8EDhqWPuPAroFpi1xgZPLae+wCx1Qxq7U5EwwwB0oy7jmd6+p Ckr1ryNTECEoLcrCkAehu2ACxrIBGVjN66D6u4dt1Cad6X2L2ez1wFon5j5r195XEoOtor/J X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291316 Archived-At: > Now the change_frame_size(5) initial and final sizes look correct. OK. In the next step I'd like to isolate the menubar code as the sole culprit for what's going in. Please with master do (setq default-frame-alist '((width . 200))) or some other insanely large value so we can see whether we can make the GTK error disappear this way. And please apply the trivial patch diff --git a/src/xfns.c b/src/xfns.c index 3f0d8f3fcd0..c90ac9c0d37 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -5230,7 +5230,7 @@ DEFUN ("x-create-frame", Fx_create_frame, Sx_create_frame, gui_default_parameter (f, parms, Qmenu_bar_lines, NILP (Vmenu_bar_mode) - ? make_fixnum (0) : make_fixnum (1), + ? make_fixnum (0) : make_fixnum (0), NULL, NULL, RES_TYPE_NUMBER); gui_default_parameter (f, parms, Qtab_bar_lines, NILP (Vtab_bar_mode) @@ -5342,7 +5342,7 @@ DEFUN ("x-create-frame", Fx_create_frame, Sx_create_frame, #if defined (USE_X_TOOLKIT) || defined (USE_GTK) /* Create the menu bar. */ - if (!minibuffer_only && FRAME_EXTERNAL_MENU_BAR (f)) + if (0) // !minibuffer_only && FRAME_EXTERNAL_MENU_BAR (f)) { /* If this signals an error, we haven't set size hints for the frame and we didn't make it visible. */ and do C-x 5 2. martin