From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 34949@debbugs.gnu.org
Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
Date: Mon, 16 Mar 2020 22:17:38 +0200 [thread overview]
Message-ID: <44cda45a-db93-f2c1-626d-9ace68cd6fd1@yandex.ru> (raw)
In-Reply-To: <87lfo1dvcf.fsf@mail.linkov.net>
On 16.03.2020 1:58, Juri Linkov wrote:
>> The hook will allow us to move almost all of the new code to the place
>> where its purpose is more obvious. And that's a good thing.
>
> I think better to leave marking in vc-dir.el because it's the file
> that deals with details of marking vc-dir files (using ewoc, etc.)
>
> Requiring ewoc in vc.el would be inappropriate (supposing that the
> hook will reside in vc.el)
Here's a slight modification: create both the hook and a function inside
the vc-dir package (let's call it vc-dir-mark-files) which will accept a
list of file names and mark them. dired-vc-next-action will then call it
from the hook.
This way, ewoc juggling will not spill outside.
>>> Maybe then a shorter name vc-root-dir-action?
>>
>> The word "action" there seems to hold no particular meaning.
>>
>> vc-root-dir-with-dwim-selection, maybe?
>
> Shorter names:
>
> vc-dir-root-registered
> or just
> vc-dir-registered
These either sound like callbacks, or alternatively make an impression
that only registered files will be *shown* (not marked).
Are you sure you don't want to split it into a new command that will
simply mark a set of files you expect here? E.g. all belonging to
"registered" statuses. That might require extra keypress, but
vc-dir-root-registered is probably not going to have the same short
combination that vc-dir has anyway. So it might be a wash, keypresses-wise.
And vc-dir-root can just be "vc-dir in the repository root" that we both
have wanted for a while.
> Also there is a command 'vc-register' (C-x v i).
> Its counterpart could be named 'vc-dir-register'
> and will open a vc-dir buffer where only unregistered
> files will be marked.
Are you sure you will remember the new commands and use them on a
regular basis? I most likely won't.
And similarly, we can add a special command to mark only unregistered
files. Although it's usually not a problem to navigate to the first
unregistered one and press 'M'.
next prev parent reply other threads:[~2020-03-16 20:17 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 17:50 bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Philipp Stephani
2019-10-09 22:40 ` Lars Ingebrigtsen
2019-12-24 19:53 ` Dmitry Gutov
2019-12-24 23:28 ` Juri Linkov
2020-02-17 23:42 ` Juri Linkov
2020-02-18 22:27 ` Dmitry Gutov
2020-02-18 23:36 ` Juri Linkov
2020-02-20 23:14 ` Juri Linkov
2020-02-21 0:22 ` Dmitry Gutov
2020-02-23 0:04 ` Juri Linkov
2020-02-23 9:01 ` Dmitry Gutov
2020-02-23 23:25 ` Juri Linkov
2020-02-24 0:17 ` Dmitry Gutov
2020-02-25 0:12 ` Juri Linkov
2020-02-25 10:32 ` Dmitry Gutov
2020-02-25 21:23 ` Juri Linkov
2020-02-26 22:49 ` Dmitry Gutov
2020-02-26 23:46 ` Juri Linkov
2020-02-27 7:28 ` Dmitry Gutov
2020-02-27 23:15 ` Juri Linkov
2020-02-28 19:22 ` Dmitry Gutov
2020-02-29 21:25 ` Juri Linkov
2020-02-29 22:25 ` Dmitry Gutov
2020-03-09 22:55 ` Juri Linkov
2020-03-12 0:08 ` Dmitry Gutov
2020-03-12 0:41 ` Juri Linkov
2020-03-12 22:43 ` Juri Linkov
2020-03-13 12:11 ` Dmitry Gutov
2020-03-14 23:31 ` Juri Linkov
2020-03-15 21:54 ` Dmitry Gutov
2020-03-15 23:58 ` Juri Linkov
2020-03-16 20:17 ` Dmitry Gutov [this message]
2020-03-24 22:16 ` Juri Linkov
2020-03-25 20:47 ` Juri Linkov
2020-03-25 21:32 ` Dmitry Gutov
2020-03-29 22:35 ` Juri Linkov
2020-03-30 19:53 ` Dmitry Gutov
2020-03-24 22:36 ` Juri Linkov
2020-03-25 20:59 ` Juri Linkov
2020-03-25 21:15 ` Drew Adams
2020-03-25 21:50 ` Juri Linkov
2020-03-25 22:04 ` Drew Adams
2020-03-26 23:18 ` Juri Linkov
2020-03-27 16:11 ` Drew Adams
2020-03-27 22:41 ` Dmitry Gutov
2020-03-28 23:54 ` Juri Linkov
2020-03-29 18:41 ` Dmitry Gutov
2020-03-29 22:27 ` Juri Linkov
2020-03-30 20:01 ` Dmitry Gutov
2020-03-30 22:40 ` Juri Linkov
2020-03-30 23:22 ` Dmitry Gutov
2020-03-31 1:02 ` Drew Adams
2020-04-02 22:08 ` Juri Linkov
2020-04-03 0:21 ` Dmitry Gutov
2020-04-03 20:08 ` Philipp Stephani
2020-04-04 23:37 ` Juri Linkov
2020-04-05 9:47 ` Philipp Stephani
2020-04-05 23:05 ` Juri Linkov
2020-04-09 8:41 ` Eli Zaretskii
2020-04-11 23:38 ` Juri Linkov
2020-04-12 6:33 ` Eli Zaretskii
2020-04-12 23:51 ` Juri Linkov
2020-04-13 4:31 ` Eli Zaretskii
2020-04-13 23:25 ` Juri Linkov
2020-03-25 21:59 ` Dmitry Gutov
2020-03-26 23:10 ` Juri Linkov
2020-03-26 23:51 ` Dmitry Gutov
2020-02-21 0:16 ` Dmitry Gutov
2019-12-25 21:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44cda45a-db93-f2c1-626d-9ace68cd6fd1@yandex.ru \
--to=dgutov@yandex.ru \
--cc=34949@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.