From: martin rudalics <rudalics@gmx.at>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: jit-lock timer etc.
Date: Mon, 21 Aug 2006 18:57:25 +0200 [thread overview]
Message-ID: <44E9E5F5.8000400@gmx.at> (raw)
In-Reply-To: <m3ejvaqpv8.fsf@kfs-l.imdomain.dk>
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
> Martin, would you like to try to update your patch ?
Apparently, my patch works also without restricting the values of
`run-at-time' as I did earlier. Could you please try the attached
revision with "pathological" values for `jit-lock-stealth-time' and
`jit-lock-stealth-nice'.
[-- Attachment #2: jit-lock.patch --]
[-- Type: text/plain, Size: 4971 bytes --]
*** jit-lock.el.~1.54.~ Mon Aug 21 14:35:24 2006
--- jit-lock.el Mon Aug 21 18:14:28 2006
***************
*** 444,512 ****
result))))
! (defun jit-lock-stealth-fontify ()
"Fontify buffers stealthily.
! This functions is called after Emacs has been idle for
! `jit-lock-stealth-time' seconds."
! ;; I used to check `inhibit-read-only' here, but I can't remember why. -stef
! (unless (or executing-kbd-macro
memory-full
! (window-minibuffer-p (selected-window)))
! (let ((buffers (buffer-list))
! (outer-buffer (current-buffer))
minibuffer-auto-raise
! message-log-max)
! (with-local-quit
! (while (and buffers (not (input-pending-p)))
! (with-current-buffer (pop buffers)
! (when jit-lock-mode
! ;; This is funny. Calling sit-for with 3rd arg non-nil
! ;; so that it doesn't redisplay, internally calls
! ;; wait_reading_process_input also with a parameter
! ;; saying "don't redisplay." Since this function here
! ;; is called periodically, this effectively leads to
! ;; process output not being redisplayed at all because
! ;; redisplay_internal is never called. (That didn't
! ;; work in the old redisplay either.) So, we learn that
! ;; we mustn't call sit-for that way here. But then, we
! ;; have to be cautious not to call sit-for in a widened
! ;; buffer, since this could display hidden parts of that
! ;; buffer. This explains the seemingly weird use of
! ;; save-restriction/widen here.
!
(with-temp-message (if jit-lock-stealth-verbose
(concat "JIT stealth lock "
(buffer-name)))
!
! ;; In the following code, the `sit-for' calls cause a
! ;; redisplay, so it's required that the
! ;; buffer-modified flag of a buffer that is displayed
! ;; has the right value---otherwise the mode line of
! ;; an unmodified buffer would show a `*'.
! (let (start
! (nice (or jit-lock-stealth-nice 0))
! (point (point-min)))
! (while (and (setq start
! (jit-lock-stealth-chunk-start point))
! ;; In case sit-for runs any timers,
! ;; give them the expected current buffer.
! (with-current-buffer outer-buffer
! (sit-for nice)))
!
! ;; fontify a block.
! (jit-lock-fontify-now start (+ start jit-lock-chunk-size))
! ;; If stealth jit-locking is done backwards, this leads to
! ;; excessive O(n^2) refontification. -stef
! ;; (when (>= jit-lock-context-unfontify-pos start)
! ;; (setq jit-lock-context-unfontify-pos end))
!
! ;; Wait a little if load is too high.
! (when (and jit-lock-stealth-load
! (> (car (load-average)) jit-lock-stealth-load))
! ;; In case sit-for runs any timers,
! ;; give them the expected current buffer.
! (with-current-buffer outer-buffer
! (sit-for (or jit-lock-stealth-time 30))))))))))))))
\f
--- 444,491 ----
result))))
! (defun jit-lock-stealth-fontify (&optional repeat)
"Fontify buffers stealthily.
! This function is called repeatedly after Emacs has become idle for
! `jit-lock-stealth-time' seconds. Optional argument REPEAT is expected
! non-nil in a repeated invocation of this function."
! (unless (or (input-pending-p)
! executing-kbd-macro
memory-full
! (window-minibuffer-p (selected-window))
! (null (if repeat
! ;; In repeated invocations `jit-lock-stealth-buffers'
! ;; has been already set up.
! jit-lock-stealth-buffers
! ;; In first invocation set up `jit-lock-stealth-buffers'
! ;; from `buffer-list'.
! (setq jit-lock-stealth-buffers (buffer-list)))))
! (let ((buffer (car jit-lock-stealth-buffers))
minibuffer-auto-raise
! message-log-max
! start load-delay)
! (when (or (not jit-lock-stealth-load)
! (or (<= (car (load-average)) jit-lock-stealth-load)
! ;; If load is too high, remember this in `load-delay'.
! (not (setq load-delay t))))
! (with-current-buffer buffer
! (if (and jit-lock-mode
! (setq start (jit-lock-stealth-chunk-start (point))))
! ;; Fontify one block of at most `jit-lock-chunk-size' characters.
(with-temp-message (if jit-lock-stealth-verbose
(concat "JIT stealth lock "
(buffer-name)))
! (jit-lock-fontify-now start (+ start jit-lock-chunk-size)))
! ;; Nothing to fontify here. Remove this buffer from
! ;; `jit-lock-stealth-buffers'.
! (setq jit-lock-stealth-buffers (cdr jit-lock-stealth-buffers)))))
! (when (and jit-lock-stealth-buffers jit-lock-stealth-time)
! ;; Call us again.
! (run-at-time
! ;; If load was too high, call again after `jit-lock-stealth-time'
! ;; seconds. Otherwise repeat after `jit-lock-stealth-nice' seconds.
! (if load-delay jit-lock-stealth-time (or jit-lock-stealth-nice 0))
! nil 'jit-lock-stealth-fontify t)))))
\f
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-08-21 16:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 11:12 jit-lock timer etc Richard Stallman
2006-08-21 11:39 ` Kim F. Storm
2006-08-21 16:57 ` martin rudalics [this message]
2006-08-21 18:51 ` Chong Yidong
2006-08-21 22:22 ` martin rudalics
2006-08-21 23:26 ` Chong Yidong
2006-08-22 7:18 ` Kim F. Storm
2006-08-22 15:41 ` Richard Stallman
2006-08-23 12:27 ` martin rudalics
2006-08-23 13:09 ` Kim F. Storm
2006-08-24 5:20 ` Richard Stallman
2006-08-24 7:47 ` Kim F. Storm
2006-08-24 7:58 ` Kim F. Storm
2006-08-24 9:07 ` Kim F. Storm
2006-08-24 14:47 ` Chong Yidong
2006-08-25 20:23 ` Richard Stallman
2006-08-25 22:45 ` Kim F. Storm
2006-08-25 20:23 ` Richard Stallman
2006-08-25 21:27 ` Chong Yidong
2006-08-26 12:22 ` Richard Stallman
2006-08-24 9:10 ` Kim F. Storm
2006-08-24 12:23 ` martin rudalics
2006-08-24 12:54 ` Kim F. Storm
2006-08-24 13:07 ` Kim F. Storm
2006-08-24 13:11 ` Kim F. Storm
2006-08-24 13:34 ` Kim F. Storm
2006-08-24 18:11 ` martin rudalics
2006-08-24 20:11 ` Kim F. Storm
2006-08-24 23:41 ` Chong Yidong
2006-08-25 7:17 ` Kim F. Storm
2006-08-24 14:16 ` Chong Yidong
2006-08-24 5:20 ` Richard Stallman
2006-08-24 7:48 ` Kim F. Storm
2006-08-24 12:21 ` martin rudalics
2006-08-24 15:27 ` Chong Yidong
2006-08-24 15:40 ` Chong Yidong
2006-08-24 18:09 ` martin rudalics
2006-08-24 19:16 ` Stefan Monnier
2006-08-24 19:20 ` Stefan Monnier
2006-08-24 16:18 ` martin rudalics
2006-08-24 16:34 ` Chong Yidong
2006-08-24 19:48 ` Chong Yidong
2006-08-25 6:00 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E9E5F5.8000400@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.