[PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[Bozhidar Batsov]

[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]

Hi everyone,  

Currently there is no support in `version-regexp-alist' for dealing with snapshot releases, so I’ve added some. I’ve also updated the treatment of x.x-cvs and x.x-date versions as they are actually snapshot releases, not alpha releases. Version ending with git and bzr are now treated the same way as cvs.

Hopefully you’ll find this patch useful.  

--  
Cheers,
Bozhidar


[-- Attachment #1.2: Type: text/html, Size: 778 bytes --]

[-- Attachment #2: 0001-subr.el-Support-for-snapshot-versions-in-version-reg.patch --]
[-- Type: application/octet-stream, Size: 2098 bytes --]

From b72a0387470f58af2936002c49235b236a7121ef Mon Sep 17 00:00:00 2001
From: Bozhidar Batsov <bozhidar@batsov.com>
Date: Thu, 31 Oct 2013 12:19:14 +0200
Subject: [PATCH] * subr.el: Support for snapshot versions in
 version-regexp-alist.

---
 lisp/subr.el | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/lisp/subr.el b/lisp/subr.el
index 4df9c9a..0556211 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -4478,11 +4478,12 @@ Usually the separator is \".\", but it can be any other string.")
 
 
 (defconst version-regexp-alist
-  '(("^[-_+ ]?alpha$"           . -3)
-    ("^[-_+]$"                  . -3) ; treat "1.2.3-20050920" and "1.2-3" as alpha releases
-    ("^[-_+ ]cvs$"              . -3) ; treat "1.2.3-CVS" as alpha release
-    ("^[-_+ ]?beta$"            . -2)
-    ("^[-_+ ]?\\(pre\\|rcc\\)$" . -1))
+  '(("^[-_+ ]?snapshot$"              . -4)
+    ("^[-_+]$"                        . -4) ; treat "1.2.3-20050920" and "1.2-3" as snapshot releases
+    ("^[-_+ ]?\\(cvs\\|git\\|bzr\\)$" . -4) ; treat "1.2.3-CVS" as snapshot release
+    ("^[-_+ ]?alpha$"                 . -3)
+    ("^[-_+ ]?beta$"                  . -2)
+    ("^[-_+ ]?\\(pre\\|rcc\\)$"       . -1))
   "Specify association between non-numeric version and its priority.
 
 This association is used to handle version string like \"1.0pre2\",
@@ -4490,6 +4491,8 @@ This association is used to handle version string like \"1.0pre2\",
 non-numeric part of a version string to an integer.  For example:
 
    String Version    Integer List Version
+   \"0.9snapshot\"     (0  9 -4)
+   \"1.0-git\"         (1  0 -4)
    \"1.0pre2\"         (1  0 -1 2)
    \"1.0PRE2\"         (1  0 -1 2)
    \"22.8beta3\"       (22 8 -2 3)
@@ -4546,6 +4549,8 @@ Examples of version conversion:
    \"0.9alpha1\"       (0  9 -3 1)
    \"0.9AlphA1\"       (0  9 -3 1)
    \"0.9alpha\"        (0  9 -3)
+   \"0.9snapshot\"     (0  9 -4)
+   \"1.0-git\"         (1  0 -4)
 
 See documentation for `version-separator' and `version-regexp-alist'."
   (or (and (stringp ver) (> (length ver) 0))
-- 
1.8.4

Re: [PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[Stefan Monnier]

> Currently there is no support in `version-regexp-alist' for dealing with
> snapshot releases, so I’ve added some. I’ve also updated the treatment of
> x.x-cvs and x.x-date versions as they are actually snapshot releases, not
> alpha releases. Version ending with git and bzr are now treated the same way
> as cvs.

Looks good, please install,


        Stefan

Re: [PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

On 1 November 2013 19:36, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > Currently there is no support in `version-regexp-alist' for dealing with
> > snapshot releases, so I’ve added some. I’ve also updated the treatment of
> > x.x-cvs and x.x-date versions as they are actually snapshot releases, not
> > alpha releases. Version ending with git and bzr are now treated the same
> way
> > as cvs.
>
> Looks good, please install,
>
>
>         Stefan
>

I don't have commit access, so I cannot install the patch myself (if your
reply referred to me).

-- 
Best Regards,
Bozhidar Batsov

http://www.batsov.com

[-- Attachment #2: Type: text/html, Size: 1223 bytes --]

Re: [PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[Stefan Monnier]

> I don't have commit access,

That's easy to fix: ask for membership in the "emacs" group from your
Savannah account,


        Stefan

Re: [PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

On 1 November 2013 21:13, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > I don't have commit access,
>
> That's easy to fix: ask for membership in the "emacs" group from your
> Savannah account,
>
>
>         Stefan
>

Thanks for the information. Done.



-- 
Best Regards,
Bozhidar Batsov

http://www.batsov.com

[-- Attachment #2: Type: text/html, Size: 939 bytes --]

Re: [PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

Patch installed.

On 1 November 2013 21:52, Bozhidar Batsov <bozhidar.batsov@gmail.com> wrote:

> On 1 November 2013 21:13, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> > I don't have commit access,
>>
>> That's easy to fix: ask for membership in the "emacs" group from your
>> Savannah account,
>>
>>
>>         Stefan
>>
>
> Thanks for the information. Done.
>
>
>
> --
> Best Regards,
> Bozhidar Batsov
>
> http://www.batsov.com
>



-- 
Best Regards,
Bozhidar Batsov

http://www.batsov.com

[-- Attachment #2: Type: text/html, Size: 1705 bytes --]

Re: [PATCH] * subr.el: Support for snapshot versions in version-regexp-alist

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

I've also patched `package-version-join' in package.el to properly handle
snapshot versions.


On 2 November 2013 12:25, Bozhidar Batsov <bozhidar.batsov@gmail.com> wrote:

> Patch installed.
>
> On 1 November 2013 21:52, Bozhidar Batsov <bozhidar.batsov@gmail.com>wrote:
>
>> On 1 November 2013 21:13, Stefan Monnier <monnier@iro.umontreal.ca>wrote:
>>
>>> > I don't have commit access,
>>>
>>> That's easy to fix: ask for membership in the "emacs" group from your
>>> Savannah account,
>>>
>>>
>>>         Stefan
>>>
>>
>> Thanks for the information. Done.
>>
>>
>>
>> --
>> Best Regards,
>> Bozhidar Batsov
>>
>> http://www.batsov.com
>>
>
>
>
> --
> Best Regards,
> Bozhidar Batsov
>
> http://www.batsov.com
>



-- 
Best Regards,
Bozhidar Batsov

http://www.batsov.com

[-- Attachment #2: Type: text/html, Size: 2486 bytes --]