all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jan D." <jan.h.d@swipnet.se>
Cc: Masatake YAMATO <jet@gyve.org>, emacs-devel@gnu.org
Subject: Re: Fix infinite loop in tex file handling in etags
Date: Sat, 12 Aug 2006 16:24:09 +0200	[thread overview]
Message-ID: <44DDE489.7060709@swipnet.se> (raw)
In-Reply-To: <E1GBtoW-0001HP-QE@tucano.isti.cnr.it>

Francesco Potorti wrote:
>>> Could someone install this patch, too?
>>>       
>> Done.
>>     
>
> Please, do not install changes in etags.c, unless it is urgent and the
> reasons for the changes are clearly understood.  Generally speaking, it
> is better asking me first, as I have a regression test suite that I run
> before committing any changes.
>   

Ok.

> I am going to examine the changes you made.  In the meantime, would you
> please send me a test case showing that etags fails for each of your
> changes?

The first change (important that the file x.tex does not end in a newline):
% echo -n "%" > x.tex
% etags x.tex

etags hangs in an infinite loop.

The second change:
% echo '#line 123 L"x.c"' > x.c
% etags x.c

etags gets a segmentation violation.

    Jan D.

  reply	other threads:[~2006-08-12 14:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07  4:01 Fix infinite loop in tex file handling in etags Masatake YAMATO
2006-08-08  9:33 ` Jan Djärv
2006-08-12 13:46   ` Francesco Potorti
2006-08-12 14:24     ` Jan D. [this message]
2006-08-14  8:35     ` Masatake YAMATO
2006-08-14 14:29       ` Francesco Potorti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DDE489.7060709@swipnet.se \
    --to=jan.h.d@swipnet.se \
    --cc=emacs-devel@gnu.org \
    --cc=jet@gyve.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.