From: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: jit lock sit-for provokes redisplay provokes imenu
Date: Fri, 21 Jul 2006 11:13:07 +0200 [thread overview]
Message-ID: <44C09AA3.8060600@gmx.at> (raw)
In-Reply-To: <E1G3hD3-0002az-U4@fencepost.gnu.org>
> This change, with the design I proposed, is so simple that it can't
> break anything. It would enable us to get rid of a gross
> inefficiency, which is a kind of bug. So I think we should do it now.
The following questions would have to be answered before doing that:
1. Should the value returned by `buffer-chars-modified-tick' always
(invariantly) imply the value returned by `buffer-modified-tick'? With
other words, suppose we have a thing called CHAR_MODIFF: Would we have
to support the invariant
MODIFF >= CHAR_MODIFF >= SAVE_MODIFF
In my opinion it seems counterintuitive to say that a buffer is "not
modified" but a "character insertion and/or deletion has occurred".
Hence I think the answer is yes.
Affected seem (at least): `write-region', `insert-file-contents',
`set-buffer-modified-p' and `restore-buffer-modified-p'. Any more?
2. Things like `subst-char-in-region' with NOUNDO non-nil change the
buffer but update the SAVE_MODIFF in order to simulate that no buffer
change occurred:
if (MODIFF - 1 == SAVE_MODIFF)
SAVE_MODIFF++;
I think that's innocuous but, if someone wanted to increment SAVE_MODIFF
in order to "ignore" a _text-property_ change only, the invariant above
could get violated. Is anyone aware of whether such a hack exists or is
planned somewhere?
3. `first-change-hook' currently runs whenever a text-property is
assigned (by font-lock, for example). I believe this should change with
the new function too?
next prev parent reply other threads:[~2006-07-21 9:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <81CCA6588E60BB42BE68BD029ED4826008838221@wimex2.wim.midas-kapiti.com>
2006-07-20 18:16 ` jit lock sit-for provokes redisplay provokes imenu Richard Stallman
2006-07-20 19:47 ` Drew Adams
2006-07-20 22:41 ` Richard Stallman
2006-07-21 9:13 ` martin rudalics [this message]
2006-07-21 19:37 ` Richard Stallman
2006-07-22 9:01 ` martin rudalics
2006-07-24 14:42 ` Richard Stallman
2006-07-26 9:32 ` martin rudalics
2006-07-21 14:53 ` martin rudalics
2006-07-22 4:38 ` Richard Stallman
2006-07-22 9:21 ` martin rudalics
2006-07-23 7:55 ` martin rudalics
2006-07-24 14:42 ` Richard Stallman
2006-07-26 11:24 ` martin rudalics
2006-07-26 15:10 ` Stefan Monnier
2006-07-26 16:16 ` martin rudalics
2006-07-27 14:35 ` Stefan Monnier
2006-07-26 22:34 ` Richard Stallman
2006-07-26 22:48 ` David Kastrup
2006-07-27 16:04 ` Richard Stallman
2006-07-27 16:27 ` David Kastrup
2006-07-27 23:45 ` Richard Stallman
2006-08-03 9:35 ` martin rudalics
2006-08-20 14:28 ` Chong Yidong
2006-08-21 14:20 ` Kim F. Storm
2006-08-21 15:20 ` Chong Yidong
2006-08-23 15:04 ` Kim F. Storm
2006-07-26 14:51 Marshall, Simon
2006-07-26 15:48 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C09AA3.8060600@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.