all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Reitter <david.reitter@gmail.com>
To: wyuenho@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: NS Port keeps crashing  when FN key combo is pressed.
Date: Thu, 14 Jan 2010 17:54:53 -0500	[thread overview]
Message-ID: <44BBB2F9-4B1B-4D77-965F-2F9763C489FE@gmail.com> (raw)
In-Reply-To: <4B4F9144.3020009@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

On Jan 14, 2010, at 4:48 PM, Jimmy Yuen Ho Wong wrote:

> Sometime since the last change few changes in nsterm.m, whenever I hit a function key combo, Emacs.app immediately crashes with no stack trace. I'm not sure what's happening.
> 
> I'm running on Mac OS X 10.5.8 PPC.


Indeed it crashes, but getting a trace was no problem for me.

Try the patch below, which fixes the issue for me.
(I believe it does not need a Qmodifier_value attribute, as the function modifier isn't checked in xterm.c.)

- David


 
diff --git a/src/nsterm.m b/src/nsterm.m
index ff2e47a..ce6cca5 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6707,6 +6707,7 @@ syms_of_nsterm ()
   DEFSYM (Qmeta, "meta");
   DEFSYM (Qsuper, "super");
   DEFSYM (Qcontrol, "control");
+  DEFSYM (Qnone, "none");
   Fput (Qalt, Qmodifier_value, make_number (alt_modifier));
   Fput (Qhyper, Qmodifier_value, make_number (hyper_modifier));
   Fput (Qmeta, Qmodifier_value, make_number (meta_modifier));



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 203 bytes --]

  reply	other threads:[~2010-01-14 22:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14 21:48 NS Port keeps crashing when FN key combo is pressed Jimmy Yuen Ho Wong
2010-01-14 22:54 ` David Reitter [this message]
     [not found]   ` <4B4FB7A6.6020603@gmail.com>
2010-01-15  0:35     ` David Reitter
2010-01-15  1:47       ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BBB2F9-4B1B-4D77-965F-2F9763C489FE@gmail.com \
    --to=david.reitter@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=wyuenho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.