Minimal patch: Use link face as default for button face

Minimal patch: Use link face as default for button face

[Lennart Borgman]

Now that there is a face called 'link should not this be used in button.el?


diff -u -r1.21 button.el
--- button.el   6 Feb 2006 14:33:32 -0000       1.21
+++ button.el   25 Jun 2006 08:07:32 -0000
@@ -52,9 +52,8 @@
 ;; Globals

 ;; Use color for the MS-DOS port because it doesn't support underline.
-(defface button '((((type pc) (class color))
-                  (:foreground "lightblue"))
-                 (t :underline t))
+(defface button
+  '((t :inherit link))
   "Default face used for buttons."
   :group 'basic-faces)

Re: Minimal patch: Use link face as default for button face

[Eli Zaretskii]

> Date: Sun, 25 Jun 2006 10:09:22 +0200
> From: Lennart Borgman <lennart.borgman.073@student.lu.se>
> 
> Now that there is a face called 'link should not this be used in button.el?
> 
> 
> diff -u -r1.21 button.el
> --- button.el   6 Feb 2006 14:33:32 -0000       1.21
> +++ button.el   25 Jun 2006 08:07:32 -0000
> @@ -52,9 +52,8 @@
>  ;; Globals
> 
>  ;; Use color for the MS-DOS port because it doesn't support underline.
> -(defface button '((((type pc) (class color))
> -                  (:foreground "lightblue"))
> -                 (t :underline t))
> +(defface button
> +  '((t :inherit link))
>    "Default face used for buttons."
>    :group 'basic-faces)

This modifies the face default for (type pc).  I don't think it's
time to change defaults now.

Re: Minimal patch: Use link face as default for button face

[Lennart Borgman]

Eli Zaretskii wrote:
>> Date: Sun, 25 Jun 2006 10:09:22 +0200
>> From: Lennart Borgman <lennart.borgman.073@student.lu.se>
>>
>> Now that there is a face called 'link should not this be used in button.el?
>>
>>
>> diff -u -r1.21 button.el
>> --- button.el   6 Feb 2006 14:33:32 -0000       1.21
>> +++ button.el   25 Jun 2006 08:07:32 -0000
>> @@ -52,9 +52,8 @@
>>  ;; Globals
>>
>>  ;; Use color for the MS-DOS port because it doesn't support underline.
>> -(defface button '((((type pc) (class color))
>> -                  (:foreground "lightblue"))
>> -                 (t :underline t))
>> +(defface button
>> +  '((t :inherit link))
>>    "Default face used for buttons."
>>    :group 'basic-faces)
>>     
>
> This modifies the face default for (type pc).  I don't think it's
> time to change defaults now.
>   
Would it not be better then to move this default to the face "link"? 
What is the benefit of not doing this now?

Re: Minimal patch: Use link face as default for button face

[Eli Zaretskii]

> Date: Sun, 25 Jun 2006 21:44:42 +0200
> From: Lennart Borgman <lennart.borgman.073@student.lu.se>
> CC:  emacs-devel@gnu.org
> 
> Would it not be better then to move this default to the face "link"? 

Maybe, I don't know.  Personally, I don't think we should do any such
changes at this time.

> What is the benefit of not doing this now?

Changing such a fundamental face might cause all kinds of unintended
consequences.  We really don't need this now, especially since the
`link' face had its current definition for ages, and no one
complained, AFAIK.

Re: Minimal patch: Use link face as default for button face

[Richard Stallman]

    > -(defface button '((((type pc) (class color))
    > -                  (:foreground "lightblue"))
    > -                 (t :underline t))
    > +(defface button
    > +  '((t :inherit link))
    >    "Default face used for buttons."
    >    :group 'basic-faces)

    This modifies the face default for (type pc).  I don't think it's
    time to change defaults now.

It makes changes on many kinds of platforms, since `link'
does a lot more than just underline.

Buttons are different from links, so I think this change is probably a
mistake on general principles.

Re: Minimal patch: Use link face as default for button face

[Lennart Borgman]

Richard Stallman wrote:
>     > -(defface button '((((type pc) (class color))
>     > -                  (:foreground "lightblue"))
>     > -                 (t :underline t))
>     > +(defface button
>     > +  '((t :inherit link))
>     >    "Default face used for buttons."
>     >    :group 'basic-faces)
>
>     This modifies the face default for (type pc).  I don't think it's
>     time to change defaults now.
>
> It makes changes on many kinds of platforms, since `link'
> does a lot more than just underline.
>
> Buttons are different from links, so I think this change is probably a
> mistake on general principles.
>   

I am not sure if I am correct, but it seems to me that the basic 
"button" is indeed a link. Compare help buffers for example. The "button 
links" there have the face "button".

"Buttons" are technically different from widgets but to the reader a 
widget link and a button link should look the same in my opinion.

Re: Minimal patch: Use link face as default for button face

[Richard Stallman]

    I am not sure if I am correct, but it seems to me that the basic 
    "button" is indeed a link. Compare help buffers for example. The "button 
    links" there have the face "button".

Without rechecking when buttons are used and when links are used,
I don't know how much this is true.  Would someone like to check?

Re: Minimal patch: Use link face as default for button face

[Miles Bader]

Richard Stallman <rms@gnu.org> writes:
>     I am not sure if I am correct, but it seems to me that the basic 
>     "button" is indeed a link. Compare help buffers for example. The "button 
>     links" there have the face "button".
>
> Without rechecking when buttons are used and when links are used,
> I don't know how much this is true.  Would someone like to check?

Well... a button is not "basically a link", as there is no standard
default action associated with buttons.

Probably the _majority_ of buttons used in the Emacs distrution act
basically like links, but there are also certainly those that don't
(e.g., in "international/mule-defs.el" it uses a button for changing the
sort order of a displayed table).

As buttons can be defined hierarchically -- a button's behavior is
(usually) defined by its "button-class", and a button-class can inherit
from a superclass -- maybe a cleaner way would be to add a standard
button-class named "link", and make link-like buttons inherit from it.

Then the "link" button class would use the "link" face by default.

-Miles

-- 
My spirit felt washed.  With blood.  [Eli Shin, on "The Passion of the Christ"]

Re: Minimal patch: Use link face as default for button face

[Richard Stallman]

    As buttons can be defined hierarchically -- a button's behavior is
    (usually) defined by its "button-class", and a button-class can inherit
    from a superclass -- maybe a cleaner way would be to add a standard
    button-class named "link", and make link-like buttons inherit from it.

    Then the "link" button class would use the "link" face by default.

Could you put that in etc/TODO?

Re: Minimal patch: Use link face as default for button face

[Miles Bader]

Richard Stallman <rms@gnu.org> writes:
> > Add a standard button-class named "link", and make link-like buttons
> > inherit from it.  Then the "link" button class would use the "link"
> > face by default.
>
> Could you put that in etc/TODO?

Ok I did

-miles

-- 
"Though they may have different meanings, the cries of 'Yeeeee-haw!' and
 'Allahu akbar!' are, in spirit, not actually all that different."