From: Lennart Borgman <lennart.borgman.073@student.lu.se>
Cc: emacs-devel@gnu.org
Subject: Re: Minimal patch: Use link face as default for button face
Date: Sun, 25 Jun 2006 21:44:42 +0200 [thread overview]
Message-ID: <449EE7AA.6000104@student.lu.se> (raw)
In-Reply-To: <uirmp84j0.fsf@gnu.org>
Eli Zaretskii wrote:
>> Date: Sun, 25 Jun 2006 10:09:22 +0200
>> From: Lennart Borgman <lennart.borgman.073@student.lu.se>
>>
>> Now that there is a face called 'link should not this be used in button.el?
>>
>>
>> diff -u -r1.21 button.el
>> --- button.el 6 Feb 2006 14:33:32 -0000 1.21
>> +++ button.el 25 Jun 2006 08:07:32 -0000
>> @@ -52,9 +52,8 @@
>> ;; Globals
>>
>> ;; Use color for the MS-DOS port because it doesn't support underline.
>> -(defface button '((((type pc) (class color))
>> - (:foreground "lightblue"))
>> - (t :underline t))
>> +(defface button
>> + '((t :inherit link))
>> "Default face used for buttons."
>> :group 'basic-faces)
>>
>
> This modifies the face default for (type pc). I don't think it's
> time to change defaults now.
>
Would it not be better then to move this default to the face "link"?
What is the benefit of not doing this now?
next prev parent reply other threads:[~2006-06-25 19:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 8:09 Minimal patch: Use link face as default for button face Lennart Borgman
2006-06-25 18:38 ` Eli Zaretskii
2006-06-25 19:44 ` Lennart Borgman [this message]
2006-06-26 3:27 ` Eli Zaretskii
2006-06-26 11:33 ` Richard Stallman
2006-06-26 13:46 ` Lennart Borgman
2006-06-27 16:14 ` Richard Stallman
2006-06-28 6:52 ` Miles Bader
2006-06-29 12:59 ` Richard Stallman
2006-06-30 1:54 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449EE7AA.6000104@student.lu.se \
--to=lennart.borgman.073@student.lu.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.