From: Lennart Borgman <lennart.borgman.073@student.lu.se>
Cc: emacs-devel@gnu.org
Subject: Re: Changing of line format and undo
Date: Thu, 22 Jun 2006 00:45:39 +0200 [thread overview]
Message-ID: <4499CC13.501@student.lu.se> (raw)
In-Reply-To: <33003.128.165.123.239.1150926847.squirrel@webmail.lanl.gov>
Stuart D. Herring wrote:
> Lennart Borgman wrote:
>
>> Eli Zaretskii wrote:
>>
>>> If you mean "C-x RET f", then it doesn't really change anything. It
>>> just sets a buffer-local variable to some value. So there's nothing
>>> to undo.
>>>
>>>
>> That is an internal Emacs perpective. From a users point of view there
>> is truly a change. If you for example change the line endings the file
>> will be saved with this new line endings.
>>
>
> Doing
>
> (add-hook 'local-write-file-functions 'erase-buffer)
>
> also would change how files were written out. Changing how Emacs works
> (via variables like the coding systems, hooks, or outright rewriting
> functions) is not within the scope of the undo mechanism, which is for
> modifications to text, not Emacs.
>
I would say that the line endings is a border case. I would expect most
users to look like it like changing the text (even if that is not what
is done internally). However I realize it is a lot of work to fix this
border case and it is perhaps not worth the trouble.
>
>> BTW should not changes of this kind also set the buffer to modified?
>>
>
> If and only if they should be undoable (which they shouldn't, IMHO). It
> would be very odd to have a buffer unmodified before and after an undo, or
> to be marked modified with no way (via undo) to remove that marking.
>
My mistake. As David pointed out the buffer is marked modified if you
change the line endings in a supported way. It is natural to make the
buffer modified since perhaps it will not get saved otherwise.
Unfortunately this change is not undoable and that is a bit confusing
sometimes.
next prev parent reply other threads:[~2006-06-21 22:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 22:15 Changing of line format and undo Lennart Borgman
2006-06-21 3:23 ` Eli Zaretskii
2006-06-21 15:12 ` Lennart Borgman
2006-06-21 15:14 ` David Kastrup
2006-06-21 15:50 ` Lennart Borgman
2006-06-21 16:31 ` David Kastrup
2006-06-21 16:47 ` Lennart Borgman
2006-06-21 17:31 ` Eli Zaretskii
2006-07-02 15:39 ` Stefan Monnier
2006-07-02 21:19 ` Kim F. Storm
2006-07-03 15:05 ` Richard Stallman
2006-07-03 21:30 ` Lennart Borgman
2006-07-04 12:55 ` Richard Stallman
2006-08-21 14:27 ` Kim F. Storm
2006-08-21 16:17 ` Stefan Monnier
2006-08-22 7:42 ` Richard Stallman
2006-08-22 9:26 ` Kim F. Storm
2006-08-22 9:39 ` Kim F. Storm
2006-08-23 4:06 ` Richard Stallman
2006-08-23 4:11 ` Lennart Borgman
2006-08-28 9:52 ` Richard Stallman
2006-06-21 21:54 ` Stuart D. Herring
2006-06-21 22:45 ` Lennart Borgman [this message]
2006-06-22 3:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4499CC13.501@student.lu.se \
--to=lennart.borgman.073@student.lu.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.