From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Davis Herring" Newsgroups: gmane.emacs.devel Subject: Re: [patch] Tramp Scpc Autodetection Date: Thu, 8 Apr 2010 12:35:37 -0700 (PDT) Message-ID: <44934.130.55.118.19.1270755337.squirrel@webmail.lanl.gov> References: Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1270755368 31869 80.91.229.12 (8 Apr 2010 19:36:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Apr 2010 19:36:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Noah Lavine" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 08 21:36:00 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NzxWA-00018V-M3 for ged-emacs-devel@m.gmane.org; Thu, 08 Apr 2010 21:35:59 +0200 Original-Received: from localhost ([127.0.0.1]:52157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzxWA-0001Ys-28 for ged-emacs-devel@m.gmane.org; Thu, 08 Apr 2010 15:35:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzxW4-0001YL-Vt for emacs-devel@gnu.org; Thu, 08 Apr 2010 15:35:53 -0400 Original-Received: from [140.186.70.92] (port=36141 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzxW3-0001WK-PG for emacs-devel@gnu.org; Thu, 08 Apr 2010 15:35:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzxVw-0005ii-TB for emacs-devel@gnu.org; Thu, 08 Apr 2010 15:35:51 -0400 Original-Received: from proofpoint2.lanl.gov ([204.121.3.26]:33356) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzxVw-0005hE-5o for emacs-devel@gnu.org; Thu, 08 Apr 2010 15:35:44 -0400 Original-Received: from mailrelay1.lanl.gov (mailrelay1.lanl.gov [128.165.4.101]) by proofpoint2.lanl.gov (8.14.3/8.14.3) with ESMTP id o38JZco4019845; Thu, 8 Apr 2010 13:35:38 -0600 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mailrelay1.lanl.gov (Postfix) with ESMTP id 0BAA5341838; Thu, 8 Apr 2010 13:35:38 -0600 (MDT) X-NIE-2-Virus-Scanner: amavisd-new at mailrelay1.lanl.gov Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay1.lanl.gov (Postfix) with ESMTP id EC2F6341817; Thu, 8 Apr 2010 13:35:37 -0600 (MDT) Original-Received: by webmail1.lanl.gov (Postfix, from userid 48) id E9AAD450001; Thu, 8 Apr 2010 13:35:37 -0600 (MDT) Original-Received: from 130.55.118.19 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Thu, 8 Apr 2010 12:35:37 -0700 (PDT) In-Reply-To: User-Agent: SquirrelMail/1.4.8-5.el5_4.10.lanl1 X-Priority: 3 (Normal) Importance: Normal X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2010-04-08_11:2010-02-06, 2010-04-08, 2010-04-07 signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123360 Archived-At: > I'd like to do whatever is necessary to contribute this patch to > emacs. What is necessary for that? I'm not in charge, but you'll certainly need a copyright assignment for this if you don't already have one: I believe you just need to write to copyright-clerk@fsf.org and ask for the form, but if I'm wrong a maintainer (Stefan or Chong) will correct me shortly. After review/revision of the patch and your assignment (which usually takes longer), someone will commit your patch quickly. Since this is a user-visible change (if a minor one), a NEWS entry might be helpful. > More generally, I couldn't find any information on the emacs website > or in the manual about how to contribute to Emacs. Is this list the > right place to send things like this? Yes, although if you're reporting a bug (and possibly supplying a patch) you should write to bug-gnu-emacs@gnu.org, which is backed by a database so that bugs and patches don't get forgotten. For discussion of new features or changes to the interface or so, this is the place; your case is perhaps a gray area. A few comments on the patch: > +(defun detect-scpc () You should use the package prefix "tramp-" here. > + (search-forward "OpenSSH_" nil t) > + (looking-at "[0-9.]*") > + (let ((ssl-version (read (match-string 0)))) > + (>= ssl-version 4.0)))))) This won't do the right thing if, say, the version is "4.3.2", because `read' will treat it as a symbol, not a number. The obvious change is to use "[0-9]+\\.?[0-9]*" as the regexp, which will also avoid an error if there is no version string in the buffer at all (if, say, the process call fails). Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.