From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stuart D. Herring" Newsgroups: gmane.emacs.devel Subject: Re: `key-binding' and XEmacs-style events Date: Sat, 3 Mar 2007 22:13:18 -0800 (PST) Message-ID: <44731.128.165.0.81.1172988798.squirrel@webmail.lanl.gov> References: <36817.128.165.123.18.1172703473.squirrel@webmail.lanl.gov> <38667.128.165.123.18.1172788075.squirrel@webmail.lanl.gov> <38780.128.165.123.18.1172793133.squirrel@webmail.lanl.gov> <85y7mg9hci.fsf@lola.goethe.zz> Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1172988831 26106 80.91.229.12 (4 Mar 2007 06:13:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 4 Mar 2007 06:13:51 +0000 (UTC) Cc: emacs-devel@gnu.org, Stefan Monnier , rms@gnu.org, "Kim F. Storm" To: "David Kastrup" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 04 07:13:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HNjyZ-0005jl-MK for ged-emacs-devel@m.gmane.org; Sun, 04 Mar 2007 07:13:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HNjyZ-0008GT-1C for ged-emacs-devel@m.gmane.org; Sun, 04 Mar 2007 01:13:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HNjyH-0008GC-69 for emacs-devel@gnu.org; Sun, 04 Mar 2007 01:13:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HNjyF-0008G0-2P for emacs-devel@gnu.org; Sun, 04 Mar 2007 01:13:23 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HNjyE-0008Fx-P1 for emacs-devel@gnu.org; Sun, 04 Mar 2007 01:13:22 -0500 Original-Received: from mailwasher.lanl.gov ([192.65.95.54] helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HNjyC-0003pc-Rl; Sun, 04 Mar 2007 01:13:21 -0500 Original-Received: from mailrelay1.lanl.gov (mailrelay1.lanl.gov [128.165.4.101]) by mailwasher-b.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l246DK5e021894; Sat, 3 Mar 2007 23:13:20 -0700 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay1.lanl.gov (8.13.8/8.13.8/(ccn-5)) with ESMTP id l246DI4f006765; Sat, 3 Mar 2007 23:13:19 -0700 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id l246DI4e003700; Sat, 3 Mar 2007 23:13:18 -0700 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id l246DIrl003698; Sat, 3 Mar 2007 22:13:18 -0800 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.0.81 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Sat, 3 Mar 2007 22:13:18 -0800 (PST) In-Reply-To: <85y7mg9hci.fsf@lola.goethe.zz> User-Agent: SquirrelMail/1.4.8-2.el3.7lanl X-Priority: 3 (Normal) Importance: Normal X-PMX-Version: 4.7.1.128075 X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67283 Archived-At: > Is it documented anywhere that this a valid way to create a key > sequence with modifiers? See (elisp)Changing Key Bindings. > Should we change EVENT_HAS_PARAMETERS itself maybe? Or EVENTP? As far as I can tell, this is the only place where it matters. "Real" events -- those that are generated by user input -- are never of this form, since it's not the "real" representation. (This is at least true for keys; I don't know whether mouse events can have this structure, but they can't very well be misclassified by the current macros!) Even `lookup-key' handles them properly; it's just the special code in `key-binding' that needs to decide whether to intuit a position that doesn't already support them. I actually considered changing EVENT_HAS_PARAMETERS first, but decided that (since I knew of no other bugs caused by it) it was safer and simpler to just change the logic in the one place. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.