From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode Date: Wed, 5 Feb 2020 02:55:00 +0300 Message-ID: <446caa77-8ff1-c565-9bf3-8facc37e3a9d@yandex.ru> References: <83a762k9p2.fsf@gnu.org> <71c2898c-aca7-ea92-e7d2-f4fd122b566d@gmail.com> <83ftfthsqs.fsf@gnu.org> <83d0awj42l.fsf@gnu.org> <83a760j23r.fsf@gnu.org> <838slkj0mk.fsf@gnu.org> <17d792bd-c96f-0440-7127-5308cc34f158@gmail.com> <83y2tjhe6l.fsf@gnu.org> <4b167bc3-0240-cb51-a004-6d9e1a84d0a4@yandex.ru> <83pnevghgp.fsf@gnu.org> <83k152gy3h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97357"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 39379@debbugs.gnu.org, wyuenho@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 05 00:56:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iz83E-000PCo-6S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Feb 2020 00:56:16 +0100 Original-Received: from localhost ([::1]:39754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz83C-0001gV-T6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Feb 2020 18:56:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33422) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz831-0001gP-JR for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 18:56:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz830-00084I-LE for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 18:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz830-000847-Hk for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 18:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iz830-0007zg-Gi for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 18:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Feb 2020 23:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39379 X-GNU-PR-Package: emacs Original-Received: via spool by 39379-submit@debbugs.gnu.org id=B39379.158086050930662 (code B ref 39379); Tue, 04 Feb 2020 23:56:02 +0000 Original-Received: (at 39379) by debbugs.gnu.org; 4 Feb 2020 23:55:09 +0000 Original-Received: from localhost ([127.0.0.1]:44937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz829-0007yU-KY for submit@debbugs.gnu.org; Tue, 04 Feb 2020 18:55:09 -0500 Original-Received: from mail-lf1-f52.google.com ([209.85.167.52]:34637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz828-0007yC-5B for 39379@debbugs.gnu.org; Tue, 04 Feb 2020 18:55:08 -0500 Original-Received: by mail-lf1-f52.google.com with SMTP id l18so133329lfc.1 for <39379@debbugs.gnu.org>; Tue, 04 Feb 2020 15:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=D0Hso9gi8iAFO69awIB08b9sQ4k7h8Rax2XXIuLc13U=; b=LoVIRfDt9mM5z201whVmWO7+IZmo/uzfriV2hOCNXqIwoaRN8X0ndfdbeyot9EHpVf RwGJz7Y4SPulNs35KzChr0P18csULJcPpDRVHK948QejXSLTAgEaeRQZ91NJzUcDUuqb 8855y80hk7le5jGaDi/+aKAK7vBez7/xSJJN7wyCC/v73PVLtKreO7Y1fxlATgxsRQUu RmBT/N3USFq1Vb1CbTGitomzrJOdbolhQQ5g5NrOn1i79XLWUbLN6StEUhWIZYgWmZZv lFdPnzf+LEkFsd7VFP9U16LK1B+i88GqmEOlpCfprlnoPqtDvWORM8d9BewkQ9IOq/fr AfiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D0Hso9gi8iAFO69awIB08b9sQ4k7h8Rax2XXIuLc13U=; b=T0ov3j/NDzCM8/KPP7zkpHQp56nAgOBnxS7K7eLUPIdC7aexNHa5HGMPquziGEkHjO PPIdgXMk5bG/5ZA8NTIntytKG/3L9a40QmobPqm5+YZoO3F3bGUJ70WfZwchsqIFpwzh xYBoI/bg64nH7BqHm/HhcvA5RERETbuT03NBk874SzAOTwkh+dYYa2R7LsCOJWgw3qte AudadIre1IJ5HlJobMLZ6a9tD/DLJcBgheuG+QavDZFQEA3FHPw9NU5KmN5cyj07t+Rd lTNMZntgYWH9BXNOV5DusiRdZ8Nao60vNfgwpXamth4uHbJPWgh8lpOJWri5/4o6Bv9u hmug== X-Gm-Message-State: APjAAAVHag2WNH4iHTXHHp0+OxlGV0Dm+eQNHKyHES+9WAdd0yjPFYL6 4MX88wTKHj+zR3TwSIibhhU= X-Google-Smtp-Source: APXvYqxdulBZOtRlOiQ5yPnBMYF0kxkNGdDPuBmnSGgs9ZLRwTxFZor8jqKrSR3Y7+sT8O+GmziaKg== X-Received: by 2002:ac2:5c4b:: with SMTP id s11mr16430967lfp.133.1580860502070; Tue, 04 Feb 2020 15:55:02 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id l3sm12288632lja.78.2020.02.04.15.55.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2020 15:55:01 -0800 (PST) In-Reply-To: <83k152gy3h.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175679 Archived-At: On 04.02.2020 18:40, Eli Zaretskii wrote: >> But... the change in ido-vertical-mode is simpler still: just add an >> extra argument to concat. > > That's true, but AFAIU the problem is not limited to > ido-vertical-mode, it will happen whenever the string to display > starts with a newline. Such a string is entirely legitimate, isn't > it? And the caller cannot possibly know that ido-exhibit will put the > 'cursor' property on the first character of that text. So I think it > isn't entirely reasonable to expect such callers to defend themselves > against internal implementation details of ido-exhibit. Umm, it's ido-exhibit that calls ido-completions. And ido-completions, as defined in ido.el, never returns such strings. Anyway, since you insist, I've pushed that change. >> If we do that in ido.do, the reason why would be fairly non-obvious from >> that code. > > If the test for the leading newline is there, the reason is quite > obvious, and we can have a comment for those who don't know enough > about the 'cursor' property and cursor positioning. I think the > result will more obvious than a mysterious concatenation of a blank in > ido-vertical-mode, which will need a comment explaining it as well. Yes, ok. Although our general policy, I think, is that external packages that use questionable practices (such as redefining functions, instead of using whatever available public customization points there are) are generally left to their own devices.