From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: Problem report #33 RESOLVED Date: Tue, 16 May 2006 08:16:05 +0200 Message-ID: <44696E25.5000008@swipnet.se> References: <200605140438.k4E4c6Mu002995@scanner2.ics.uci.edu> <44671504.9010808@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1147760208 14652 80.91.229.2 (16 May 2006 06:16:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 16 May 2006 06:16:48 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 16 08:16:45 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FfsrK-0004Ll-UP for ged-emacs-devel@m.gmane.org; Tue, 16 May 2006 08:16:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FfsrK-0008Uk-8J for ged-emacs-devel@m.gmane.org; Tue, 16 May 2006 02:16:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ffsr6-0008UC-69 for emacs-devel@gnu.org; Tue, 16 May 2006 02:16:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ffsr3-0008Ty-1q for emacs-devel@gnu.org; Tue, 16 May 2006 02:16:27 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ffsr2-0008Ts-Rr for emacs-devel@gnu.org; Tue, 16 May 2006 02:16:24 -0400 Original-Received: from [81.228.8.185] (helo=av12-1-sn2.hy.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Ffstc-0004Q1-Lt for emacs-devel@gnu.org; Tue, 16 May 2006 02:19:04 -0400 Original-Received: by av12-1-sn2.hy.skanova.net (Postfix, from userid 502) id D345A37EB2; Tue, 16 May 2006 08:16:23 +0200 (CEST) Original-Received: from smtp4-2-sn2.hy.skanova.net (smtp4-2-sn2.hy.skanova.net [81.228.8.93]) by av12-1-sn2.hy.skanova.net (Postfix) with ESMTP id C61FE37EA3; Tue, 16 May 2006 08:16:23 +0200 (CEST) Original-Received: from coolsville.localdomain (81-235-205-204-no59.tbcn.telia.com [81.235.205.204]) by smtp4-2-sn2.hy.skanova.net (Postfix) with ESMTP id 7A80337E46; Tue, 16 May 2006 08:16:23 +0200 (CEST) User-Agent: Thunderbird 1.5.0.2 (X11/20060501) Original-To: "Kim F. Storm" In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54559 Archived-At: > What about the x_window_to_frame call in relation to Ghostview? > If it can return NULL, emacs will crash... > It can return NULL if the window has been removed (i.e. it is a race problem). Probably not that common in real life, but I think you should check in your fix. Jan D. > > Index: xterm.c > =================================================================== > RCS file: /cvsroot/emacs/emacs/src/xterm.c,v > retrieving revision 1.912 > diff -c -r1.912 xterm.c > *** xterm.c 14 May 2006 11:26:07 -0000 1.912 > --- xterm.c 15 May 2006 21:43:13 -0000 > *************** > *** 5821,5826 **** > --- 5821,5828 ---- > images, only, which should have 1 page. */ > Pixmap pixmap = (Pixmap) event.xclient.data.l[1]; > f = x_window_to_frame (dpyinfo, event.xclient.window); > + if (!f) > + goto OTHER; > x_kill_gs_process (pixmap, f); > expose_frame (f, 0, 0, 0, 0); > goto done; >