From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: Problem report #33 RESOLVED Date: Sun, 14 May 2006 13:31:16 +0200 Message-ID: <44671504.9010808@swipnet.se> References: <200605140438.k4E4c6Mu002995@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1147606316 4008 80.91.229.2 (14 May 2006 11:31:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 14 May 2006 11:31:56 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 14 13:31:54 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FfEpC-0002vi-T8 for ged-emacs-devel@m.gmane.org; Sun, 14 May 2006 13:31:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FfEpC-0005Dy-DZ for ged-emacs-devel@m.gmane.org; Sun, 14 May 2006 07:31:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FfEok-0005AG-GG for emacs-devel@gnu.org; Sun, 14 May 2006 07:31:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FfEoi-00059E-MD for emacs-devel@gnu.org; Sun, 14 May 2006 07:31:22 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FfEoi-000598-Fa for emacs-devel@gnu.org; Sun, 14 May 2006 07:31:20 -0400 Original-Received: from [81.228.9.179] (helo=av6-1-sn3.vrr.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FfEqt-0000EB-B3 for emacs-devel@gnu.org; Sun, 14 May 2006 07:33:35 -0400 Original-Received: by av6-1-sn3.vrr.skanova.net (Postfix, from userid 502) id 5F13237F55; Sun, 14 May 2006 13:31:19 +0200 (CEST) Original-Received: from smtp3-1-sn3.vrr.skanova.net (smtp3-1-sn3.vrr.skanova.net [81.228.9.101]) by av6-1-sn3.vrr.skanova.net (Postfix) with ESMTP id 4F4C737F3E; Sun, 14 May 2006 13:31:19 +0200 (CEST) Original-Received: from coolsville.localdomain (81-235-205-204-no59.tbcn.telia.com [81.235.205.204]) by smtp3-1-sn3.vrr.skanova.net (Postfix) with ESMTP id 3517E37E55; Sun, 14 May 2006 13:31:19 +0200 (CEST) User-Agent: Thunderbird 1.5.0.2 (X11/20060420) Original-To: Dan Nicolaescu In-Reply-To: <200605140438.k4E4c6Mu002995@scanner2.ics.uci.edu> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54438 Archived-At: Dan Nicolaescu wrote: > This one reappeared after the last xterm.c checkin. > Is it OK not to check f for NULL here? > No it is not OK. If someone tries to get the widget tree with editres on an Emacs lucid dialog for example, Emacs will crash. I've checked in a fix. Jan D. > CID: 33 > Checker: NULL_RETURNS (help) > File: base/src/emacs/src/xterm.c > Function: handle_one_xevent > Description: Dereferencing NULL value "f" > > 5801 #ifdef HACK_EDITRES > 5802 if (event.xclient.message_type > 5803 == dpyinfo->Xatom_editres) > 5804 { > > Event returned_null: Function "x_any_window_to_frame" returned NULL value (checked 8 out of 9 times) [model] > Event var_assigned: Variable "f" assigned to NULL return value from "x_any_window_to_frame" > Also see events: [var_assigned][dereference] > > 5805 f = x_any_window_to_frame (dpyinfo, event.xclient.window); > > Event dereference: Dereferencing NULL value "f" > Also see events: [returned_null][var_assigned] > > 5806 _XEditResCheckMessages (f->output_data.x->widget, NULL, > 5807 &event, NULL); > 5808 goto done; > 5809 } > >