with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs]

From: Lars Hansen <lists@soem.dk>
Cc: emacs-pretest-bug@gnu.org, Luc Teirlinck <teirllm@dms.auburn.edu>,
	rms@gnu.org, wohler@newt.com
Subject: with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs]
Date: Fri, 12 May 2006 12:50:23 +0200	[thread overview]
Message-ID: <4464686F.7050101@soem.dk> (raw)
In-Reply-To: <44643259.3050302@soem.dk>

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

Lars Hansen wrote:

>I suggest to use with-temp-buffer (and buffer-disable-undo)
>  
>
Does it ever make sense to save undo information in a temporary buffer?
If not, I suggest to disable it in with-temp-buffer.
Patch attached.

[-- Attachment #2: subr.diff --]
[-- Type: text/x-patch, Size: 761 bytes --]

*** subr.el~	2006-05-12 08:24:10.000000000 +0200
--- subr.el	2006-05-12 12:40:59.575290323 +0200
***************
*** 2220,2226 ****
  See also `with-temp-file' and `with-output-to-string'."
    (declare (indent 0) (debug t))
    (let ((temp-buffer (make-symbol "temp-buffer")))
!     `(let ((,temp-buffer (generate-new-buffer " *temp*")))
         (unwind-protect
  	   (with-current-buffer ,temp-buffer
  	     ,@body)
--- 2220,2227 ----
  See also `with-temp-file' and `with-output-to-string'."
    (declare (indent 0) (debug t))
    (let ((temp-buffer (make-symbol "temp-buffer")))
!     `(let ((,temp-buffer (generate-new-buffer " *temp*"))
!            (buffer-undo-list t))
         (unwind-protect
  	   (with-current-buffer ,temp-buffer
  	     ,@body)

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel