From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: David Ponce Newsgroups: gmane.emacs.bugs Subject: bug#40788: 28.0.50; Error running timer =?UTF-8?Q?=E2=80=98custom-magic-reset=E2=80=99?= Date: Fri, 24 Apr 2020 17:56:42 +0200 Message-ID: <444f86ec-6d0b-7134-5bb1-165549a7acb3@orange.fr> References: <9360131a-d203-4075-78b2-f4d31d044801@orange.fr> <1699699799.16404.1587663566588.JavaMail.www@wwinf1p24> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62951"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: 40788@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 24 17:57:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jS0hX-000GFi-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Apr 2020 17:57:15 +0200 Original-Received: from localhost ([::1]:42702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jS0hW-0006fH-6E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Apr 2020 11:57:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35512) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jS0hL-0006eR-Ht for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 11:57:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jS0hK-0000Un-Uc for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 11:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jS0hK-0000Uf-Ht for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 11:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jS0hK-0006Un-G8 for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2020 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Apr 2020 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40788 X-GNU-PR-Package: emacs Original-Received: via spool by 40788-submit@debbugs.gnu.org id=B40788.158774381224927 (code B ref 40788); Fri, 24 Apr 2020 15:57:02 +0000 Original-Received: (at 40788) by debbugs.gnu.org; 24 Apr 2020 15:56:52 +0000 Original-Received: from localhost ([127.0.0.1]:57775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jS0hA-0006Ty-1H for submit@debbugs.gnu.org; Fri, 24 Apr 2020 11:56:52 -0400 Original-Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:57165 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jS0h8-0006Tk-2U for 40788@debbugs.gnu.org; Fri, 24 Apr 2020 11:56:51 -0400 Original-Received: from [192.168.1.25] ([92.129.68.39]) by mwinf5d57 with ME id Wfwi2200B0qq0GU03fwiA4; Fri, 24 Apr 2020 17:56:43 +0200 X-ME-Helo: [192.168.1.25] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Fri, 24 Apr 2020 17:56:43 +0200 X-ME-IP: 92.129.68.39 In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178933 Archived-At: On 24/04/2020 13:56, Robert Pluim wrote: >>>>>> On Thu, 23 Apr 2020 19:39:26 +0200 (CEST), David PONCE said: > > David> Hello again, > David> Below is a possible patch that seems to have fixed the issue for me. > David> But I am not sure the approach is correct > > Rather than defining a new function, you can add an argument to the > existing one. Something like (untested) Hi Robert, Sure, your patch is better :-) I tested it, and I confirm it fixes the issue :-) I also tested the below variant, because it seems to me that it is not necessary to set the buffer when magic is nil, as there is nothing to do. Please feel free to apply which version looks better to you. Thanks! diff --git a/home/dponce/installs/emacs/lisp/cus-edit.el b/cus-edit.el index d3d17fd..490d905 100644 --- a/home/dponce/installs/emacs/lisp/cus-edit.el +++ b/cus-edit.el @@ -2102,11 +2102,12 @@ and `face'." (insert " ")) (widget-put widget :children children)))) -(defun custom-magic-reset (widget) +(defun custom-magic-reset (widget &optional buffer) "Redraw the :custom-magic property of WIDGET." (let ((magic (widget-get widget :custom-magic))) (when magic - (widget-value-set magic (widget-value magic))))) + (with-current-buffer (or buffer (current-buffer)) + (widget-value-set magic (widget-value magic)))))) ;;; The `custom' Widget. @@ -2217,7 +2218,7 @@ and `face'." ;; commands like `M-u' (that work on a region in the buffer) ;; will upcase the wrong part of the buffer, since more text has ;; been inserted before point. - (run-with-idle-timer 0.0 nil #'custom-magic-reset widget) + (run-with-idle-timer 0.0 nil #'custom-magic-reset widget (current-buffer)) (apply 'widget-default-notify widget args)))) (defun custom-redraw (widget)