Re: [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing

Re: [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing

[Stefan Monnier]

> +(defconst js--name-start-re (concat "[a-zA-Z_$]")
>    "Regexp matching the start of a JavaScript identifier, without grouping.")

BTW, my knowledge of Javascript is very limited, but IIUC its
identifiers are not limited to ASCII, so [[:alpha:]_$] is probably
a better regexp.


        Stefan

Re: [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing

[Jackson Ray Hamilton]

Hi Stefan,

You’re right.  I pushed “Permit non-ASCII identifiers in JS” to address 
this.

Jackson

On 4/7/19 6:02 PM, Stefan Monnier wrote:
>> +(defconst js--name-start-re (concat "[a-zA-Z_$]")
>>     "Regexp matching the start of a JavaScript identifier, without grouping.")
> BTW, my knowledge of Javascript is very limited, but IIUC its
> identifiers are not limited to ASCII, so [[:alpha:]_$] is probably
> a better regexp.
>
>
>          Stefan