From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: jan.synacek@posteo.org Newsgroups: gmane.emacs.bugs Subject: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Date: Mon, 30 May 2022 11:00:07 +0000 Message-ID: <43b5eada954e592cc0c747368a3dbdb7@posteo.de> References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_c4b091c9e73cc44cc80cb6f924cd70b8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28538"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55632@debbugs.gnu.org, DG To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 30 13:01:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nvd9N-0007E6-SI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 May 2022 13:01:30 +0200 Original-Received: from localhost ([::1]:58686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvd9M-0005Jv-Jh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 May 2022 07:01:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvd8w-0005I9-Lf for bug-gnu-emacs@gnu.org; Mon, 30 May 2022 07:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvd8w-0002sd-At for bug-gnu-emacs@gnu.org; Mon, 30 May 2022 07:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nvd8w-0000bk-AA for bug-gnu-emacs@gnu.org; Mon, 30 May 2022 07:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: jan.synacek@posteo.org Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 May 2022 11:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55632-submit@debbugs.gnu.org id=B55632.16539084212276 (code B ref 55632); Mon, 30 May 2022 11:01:02 +0000 Original-Received: (at 55632) by debbugs.gnu.org; 30 May 2022 11:00:21 +0000 Original-Received: from localhost ([127.0.0.1]:42905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvd8G-0000ae-SE for submit@debbugs.gnu.org; Mon, 30 May 2022 07:00:21 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:45687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvd8A-0000aC-St for 55632@debbugs.gnu.org; Mon, 30 May 2022 07:00:19 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9AD62240109 for <55632@debbugs.gnu.org>; Mon, 30 May 2022 13:00:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1653908408; bh=xP6l5JjR94KE3wal8EMNGwMbJcQ7F+sGefpR1eMMIXk=; h=Date:From:To:Cc:Subject:From; b=DPgg9MuqwY4GW8PUq8pCSIsbNEE0VZEAGuXpSqYRjzUD3n/DevJBiUmhWMwfUs3KU 9Uz+qDO/haVfFa8mwg8iro76C7GyyBHSI5aoBkFtkT/QT/SKvlA38kD4whXlG1+f9u LIolXdRXKHEn+1gGI5E2emFARsrumIQXSYQ/2SBOemx6gGyqTT/tS5QksXiSnenZM4 IUYj+B35djj+VDDk1xWG7l0vTOKITZyPISOemme+YK+mZbF2E7r92mW8B3KIw8uiGg PYXT0wb9OZ1UvBDqKqmOeYDtbPoI5k4/xrJynyEdz32kRCKkJhtc7MGoaCMPa/yK+H bFoI50Lw8FicA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LBXVv4St9z6tm9; Mon, 30 May 2022 13:00:07 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233365 Archived-At: --=_c4b091c9e73cc44cc80cb6f924cd70b8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=flowed On 29.05.2022 23:41, Dmitry Gutov wrote: > On 27.05.2022 16:55, Dmitry Gutov wrote: >> On 25.05.2022 12:08, Jan Syn=C3=A1=C4=8Dek wrote: >>> Currently, `project-find-file' always includes untracked files, which= =20 >>> is >>> not always the desired behavior. This patch adds a new user option to >>> make only find the actual project files. By default, the variable is=20 >>> set >>> to nil, which means the behavior is not changed. >>=20 >> Sure, thanks. I'll review this soon-ish. >=20 > The patch seems functional, thanks. Should also get you better > performance, if this is the behavior you prefer. >=20 > Regarding the naming and the docstring, though: unlike what the > defcustom says, it will affect also 'project-find-regexp' (i.e. which > files get searched by this command), and all other features that > delegate to 'project-files' internally. >=20 > So the docstring could use some generalizing. And consider these two > options for rename: >=20 > - project-vc-tracked-only (defaulting to nil, like in the patch) > - project-vc-include-untracked (defaulting to t) >=20 > The docstring could say something like: >=20 > When non-nil, the VC project backend includes the untracked files. Thank you for the review. I addressed your comments in the new version=20 of the patch. --=_c4b091c9e73cc44cc80cb6f924cd70b8 Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name=0001-Add-new-user-option-project-vc-include-untracked.patch Content-Disposition: attachment; filename=0001-Add-new-user-option-project-vc-include-untracked.patch; size=3437 RnJvbSBiZTM2ODY0Nzc4M2RhOGMxMmUyZWExNzU0MDFkZDdmODRkMGNkNGM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SmFuPTIwU3luPUMzPUExPUM0PThEZWs/PSA8 amFuLnN5bmFjZWtAZ21haWwuY29tPgpEYXRlOiBXZWQsIDI1IE1heSAyMDIyIDEwOjUzOjU1ICsw MjAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG5ldyB1c2VyIG9wdGlvbiBwcm9qZWN0LXZjLWluY2x1 ZGUtdW50cmFja2VkCgoqIGRvYy9lbWFjcy9tYWludGFpbmluZy50ZXhpIChQcm9qZWN0cyk6IERv Y3VtZW50IGl0LgoqIGxpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgKHByb2plY3QtLXZjLWxpc3Qt ZmlsZXMpOiBVc2UgaXQuCi0tLQogZG9jL2VtYWNzL21haW50YWluaW5nLnRleGkgfCAgMyArKysK IGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgIHwgIDQgKysrKwogbGlzcC9wcm9nbW9kZXMvcHJv amVjdC5lbCAgfCAxNiArKysrKysrKysrKy0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL21haW50YWlu aW5nLnRleGkgYi9kb2MvZW1hY3MvbWFpbnRhaW5pbmcudGV4aQppbmRleCAzZGRlYTBhZTU4Li42 ZjBkYTYzODM3IDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvbWFpbnRhaW5pbmcudGV4aQorKysgYi9k b2MvZW1hY3MvbWFpbnRhaW5pbmcudGV4aQpAQCAtMTY2Niw2ICsxNjY2LDkgQEAgUHJvamVjdHMK ICAgV2hpY2ggZmlsZXMgZG8gb3IgZG9uJ3QgYmVsb25nIHRvIGEgcHJvamVjdCBpcyBhbHNvIGRl dGVybWluZWQgYnkKIHRoZSBwcm9qZWN0IGJhY2stZW5kLiAgRm9yIGV4YW1wbGUsIHRoZSBWQyBi YWNrLWVuZCBkb2Vzbid0IGNvbnNpZGVyCiBgYGlnbm9yZWQnJyBmaWxlcyAoQHB4cmVme1ZDIEln bm9yZX0pIHRvIGJlIHBhcnQgb2YgdGhlIHByb2plY3QuCitBbHNvLCBzb21lIFZDIGJhY2stZW5k cyBjb25zaWRlciBgYHVudHJhY2tlZCcnIGZpbGVzIGJ5IGRlZmF1bHQuCitUaGF0IGJlaGF2aW9y IGlzIGNvbnRyb2xsYWJsZSB3aXRoIHRoZSB2YXJpYWJsZQorQGNvZGV7cHJvamVjdC12Yy1pbmNs dWRlLXVudHJhY2tlZH0uCiAKIEBtZW51CiAqIFByb2plY3QgRmlsZSBDb21tYW5kczo6ICAgQ29t bWFuZHMgZm9yIGhhbmRsaW5nIHByb2plY3QgZmlsZXMuCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBi L2V0Yy9ORVdTCmluZGV4IDU5ODdhY2RhYzkuLmI2OTVkNjMwMjAgMTAwNjQ0Ci0tLSBhL2V0Yy9O RVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xNjkzLDYgKzE2OTMsMTAgQEAgRW5hYmxpbmcgdGhpcyBt aW5vciBtb2RlIHR1cm5zIG9uIGhpZGluZyBoZWFkZXIgbWF0ZXJpYWwsIGxpa2UKICdlbGlkZS1o ZWFkJyBkb2VzOyBkaXNhYmxpbmcgaXQgc2hvd3MgdGhlIGhlYWRlci4gIFRoZSBjb21tYW5kcwog J2VsaWRlLWhlYWQnIGFuZCAnZWxpZGUtaGVhZC1zaG93JyBhcmUgbm93IG9ic29sZXRlLgogCisr KysKKyoqKiBOZXcgdXNlciBvcHRpb24gJ3Byb2plY3QtdmMtaW5jbHVkZS11bnRyYWNrZWQnLgor V2hlbiBub24tbmlsLCB0aGUgVkMgcHJvamVjdCBiYWNrZW5kIGluY2x1ZGVzIHRoZSB1bnRyYWNr ZWQgZmlsZXMuCisKIC0tLQogKiogVGhlIGF1dG9hcmcuZWwgbGlicmFyeSBpcyBub3cgbWFya2Vk IG9ic29sZXRlLgogVGhpcyBsaWJyYXJ5IHByb3ZpZGVzIHRoZSAnYXV0b2FyZy1tb2RlJyBhbmQg J2F1dG9hcmcta3AtbW9kZScgbWlub3IKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2pl Y3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9wcm9qZWN0LmVsCmluZGV4IDZjNTAxMzUzNTguLmU0ODhm YTE0NWUgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9w cm9nbW9kZXMvcHJvamVjdC5lbApAQCAtMzgyLDYgKzM4MiwxMSBAQCBwcm9qZWN0LXZjLW1lcmdl LXN1Ym1vZHVsZXMKICAgOnBhY2thZ2UtdmVyc2lvbiAnKHByb2plY3QgLiAiMC4yLjAiKQogICA6 c2FmZSAjJ2Jvb2xlYW5wKQogCisoZGVmY3VzdG9tIHByb2plY3QtdmMtaW5jbHVkZS11bnRyYWNr ZWQgdAorICAiV2hlbiBub24tbmlsLCB0aGUgVkMgcHJvamVjdCBiYWNrZW5kIGluY2x1ZGVzIHRo ZSB1bnRyYWNrZWQgZmlsZXMuIgorICA6dHlwZSAnYm9vbGVhbgorICA6c2FmZSAjJ2Jvb2xlYW5w KQorCiA7OyBGSVhNRTogVXNpbmcgdGhlIGN1cnJlbnQgYXBwcm9hY2gsIG1ham9yIG1vZGVzIGFy ZSBzdXBwb3NlZCB0byBzZXQKIDs7IHRoaXMgdmFyaWFibGUgdG8gYSBidWZmZXItbG9jYWwgdmFs dWUuICBTbyB3ZSBkb24ndCBoYXZlIGFjY2VzcyB0bwogOzsgdGhlICJleHRlcm5hbCByb290cyIg b2YgbGFuZ3VhZ2UgQSBmcm9tIGJ1ZmZlcnMgb2YgbGFuZ3VhZ2UgQiwgd2hpY2gKQEAgLTUxMiw4 ICs1MTcsOSBAQCBwcm9qZWN0LS12Yy1saXN0LWZpbGVzCiAgICAgICAgICAgIChhcmdzICcoIi16 IikpCiAgICAgICAgICAgICh2Yy1naXQtdXNlLWxpdGVyYWwtcGF0aHNwZWNzIG5pbCkKICAgICAg ICAgICAgZmlsZXMpCi0gICAgICAgOzsgSW5jbHVkZSB1bnJlZ2lzdGVyZWQuCi0gICAgICAgKHNl dHEgYXJncyAoYXBwZW5kIGFyZ3MgJygiLWMiICItbyIgIi0tZXhjbHVkZS1zdGFuZGFyZCIpKSkK KyAgICAgICAoc2V0cSBhcmdzIChhcHBlbmQgYXJncworICAgICAgICAgICAgICAgICAgICAgICAg ICAnKCItYyIgIi0tZXhjbHVkZS1zdGFuZGFyZCIpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICh3aGVuIHByb2plY3QtdmMtaW5jbHVkZS11bnRyYWNrZWQgJygiLW8iKSkpKQogICAgICAgICh3 aGVuIGV4dHJhLWlnbm9yZXMKICAgICAgICAgIChzZXRxIGFyZ3MgKGFwcGVuZCBhcmdzCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnMgIi0tIgpAQCAtNTY1LDkgKzU3MSw5IEBAIHBy b2plY3QtLXZjLWxpc3QtZmlsZXMKICAgICAgICAoZGVsZXRlLWNvbnNlY3V0aXZlLWR1cHMgZmls ZXMpKSkKICAgICAoYEhnCiAgICAgIChsZXQgKChkZWZhdWx0LWRpcmVjdG9yeSAoZXhwYW5kLWZp bGUtbmFtZSAoZmlsZS1uYW1lLWFzLWRpcmVjdG9yeSBkaXIpKSkKLSAgICAgICAgICAgYXJncykK LSAgICAgICA7OyBJbmNsdWRlIHVucmVnaXN0ZXJlZC4KLSAgICAgICAoc2V0cSBhcmdzIChuY29u YyBhcmdzICcoIi1tY2FyZHUiICItLW5vLXN0YXR1cyIgIi0wIikpKQorICAgICAgICAgICAoYXJn cyAobGlzdCAoY29uY2F0ICItbWNhcmQiICh3aGVuIHByb2plY3QtdmMtaW5jbHVkZS11bnRyYWNr ZWQgInUiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIi0tbm8tc3RhdHVzIgorICAgICAgICAg ICAgICAgICAgICAgICAiLTAiKSkpCiAgICAgICAgKHdoZW4gZXh0cmEtaWdub3JlcwogICAgICAg ICAgKHNldHEgYXJncyAobmNvbmMgYXJncwogICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1h cGNhbgotLSAKMi4zNi4xCgo= --=_c4b091c9e73cc44cc80cb6f924cd70b8--