From menu button, how run more than one command?

From menu button, how run more than one command?

[DiGrazia]

I want to have a menu whose buttons each executes something like this:

(cd "c:/blah/")
(find-file) ;Do not specify file; instead, open the Find File window.

That is, I want each button to run "cd" and then "find-file" interactively.

The code below works, but note that the menu button calls function
"abc".  If the menu contains many buttons, each button would need a
dedicated function.

(defvar my-menu (make-sparse-keymap))

(define-key my-menu [rmx]
   '(menu-item "FILE" abc))      ;executes function abc

(defun abc ()
   (interactive)
   (cd "C:/emacs")
   (call-interactively 'find-file)
)

Is there a way to write the "define-key" so that I don't need a separate
function?
Or, is there a way to pass an argument from "menu-item" to a function?

From menu button, how run more than one command?

[RD]

I want to have a menu whose buttons each executes more than one command, 
something like this:

(cd "c:/blah/")
(call-interactively 'find-file) ;open the Find File window.


The code below works, but note that the menu button calls function
"abc".  If the menu contains many buttons, each button would need a
dedicated function.

(defvar my-menu (make-sparse-keymap))

(define-key my-menu [rmx]
   '(menu-item "FILE" abc))      ;executes function abc

(defun abc ()
   (interactive)
   (cd "C:/emacs")
   (call-interactively 'find-file)
)

Is there a way to write the "define-key" so that I don't need a separate
function?
Or, is there a way to pass an argument from "menu-item" to the function?

Re: From menu button, how run more than one command?

[Mathias Dahl]

RD <rjjd@localnet.com> writes:

> The code below works, but note that the menu button calls function
> "abc".  If the menu contains many buttons, each button would need a
> dedicated function.
>
> (defvar my-menu (make-sparse-keymap))
>
> (define-key my-menu [rmx]
>    '(menu-item "FILE" abc))      ;executes function abc
>
> (defun abc ()
>    (interactive)
>    (cd "C:/emacs")
>    (call-interactively 'find-file)
> )
>
> Is there a way to write the "define-key" so that I don't need a separate
> function?
> Or, is there a way to pass an argument from "menu-item" to the function?

Luckily for you I struggled too with menus last week. Would something
like this work for you?

(defvar my-menu (make-sparse-keymap))

(define-key my-menu [rmx1]
   `(menu-item "Find file on c:/" 
               ,(lambda () 
                  (interactive) 
                  (abc "c:/"))))

(define-key my-menu [rmx2]
   `(menu-item "Find file on h:/" 
               ,(lambda () 
                  (interactive) 
                  (abc "h:/"))))

(defun abc (path)
   (cd path)
   (call-interactively 'find-file))

;; Test it

(popup-menu my-menu)

/Mathias

Re: From menu button, how run more than one command?

[Kevin Rodgers]

Mathias Dahl wrote:
 > Luckily for you I struggled too with menus last week. Would something
 > like this work for you?
 >
 > (defvar my-menu (make-sparse-keymap))
 >
 > (define-key my-menu [rmx1]
 >    `(menu-item "Find file on c:/"
 >                ,(lambda ()
 >                   (interactive)
 >                   (abc "c:/"))))
 >
 > (define-key my-menu [rmx2]
 >    `(menu-item "Find file on h:/"
 >                ,(lambda ()
 >                   (interactive)
 >                   (abc "h:/"))))
 >
 > (defun abc (path)
 >    (cd path)
 >    (call-interactively 'find-file))
 >
 > ;; Test it
 >
 > (popup-menu my-menu)

(lambda ...) is a self-evaluating form, so the backquote/comma syntax is
completely extraneous and can be replaced with a simple quote:
'(menu-item ...)

-- 
Kevin Rodgers

Re: From menu button, how run more than one command?

[Mathias Dahl]

Kevin Rodgers <ihs_4664@yahoo.com> writes:

>  > (define-key my-menu [rmx2]
>  >    `(menu-item "Find file on h:/"
>  >                ,(lambda ()
>  >                   (interactive)
>  >                   (abc "h:/"))))

> (lambda ...) is a self-evaluating form, so the backquote/comma syntax is
> completely extraneous and can be replaced with a simple quote:
> '(menu-item ...)

I played a lot with that and the above worked so... :) My elisp is a
bit shaky and sometimes you don't know what you do wrong and what
changes that fixed the problem, so I probably changed some other thing
while adding those "`" and "," which solved the problem.

Anyway, thanks for pointing it out, I will play some more with it.

Re: From menu button, how run more than one command?

[Johan Bockgård]

Kevin Rodgers <ihs_4664@yahoo.com> writes:

> Mathias Dahl wrote:

>> (defvar my-menu (make-sparse-keymap))
>>
>> (define-key my-menu [rmx1]
>>    `(menu-item "Find file on c:/"
>>                ,(lambda ()
>>                   (interactive)
>>                   (abc "c:/"))))
[...]
> (lambda ...) is a self-evaluating form, so the backquote/comma
> syntax is completely extraneous and can be replaced with a simple
> quote: '(menu-item ...)

Having `lambda' in a non-quoted context has the advantage that the
byte-compiler can process it.

-- 
Johan Bockgård

Re: From menu button, how run more than one command?

[Eli Zaretskii]

> From: RD <rjjd@localnet.com>
> Date: Fri, 24 Feb 2006 22:07:21 -0500
> 
> (defvar my-menu (make-sparse-keymap))
> 
> (define-key my-menu [rmx]
>    '(menu-item "FILE" abc))      ;executes function abc
> 
> (defun abc ()
>    (interactive)
>    (cd "C:/emacs")
>    (call-interactively 'find-file)
> )
> 
> Is there a way to write the "define-key" so that I don't need a separate
> function?

Yes, use `lambda' (a.k.a. anonymous functions).