From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"17172@debbugs.gnu.org" <17172@debbugs.gnu.org>
Subject: bug#17172: 24.3.50; Timeouts when pasting from mouse
Date: Tue, 15 Apr 2014 22:41:23 +0200 [thread overview]
Message-ID: <43B05B9F-D0DA-47AC-B8FB-4A780FF3E095@swipnet.se> (raw)
In-Reply-To: <534D9453.9040700@cs.ucla.edu>
Hello.
> 15 apr 2014 kl. 22:19 skrev Paul Eggert <eggert@cs.ucla.edu>:
>
> Jan Djärv wrote:
>> That can't happen, all masks are initialized with FD_ZERO.
>
> True, but after that they can be reused in some cases and it's not immediately obvious that they are guaranteed to be properly reinitialized for every call to xg_select.
They are not reinitialized with FD_ZERO, but no garbage bits are ever set.
>
>> If we passed masks with garbage in them to pselect we would get EINVAL back.
>
> Not if the garbage's 1 bits happen to correspond to open file descriptors.
But there are no garbage bits.
>
>> In that case, process.c does not inspect the masks, so this change fixes nothing.
>
> Although it doesn't inspect the masks right away, in some cases it reuses a mask later. The code is reasonably tricky here.
Not so you can't follow it.
>
>> you just used it as a means to get untested code into the emacs-24 branch
>
> Hmm, well, that's a bit unfair as I did test it, but as you're sure the change doesn't fix any user-visible bugs I reverted it.
It was not tested by the OP of this bug.
Jan D.
next prev parent reply other threads:[~2014-04-15 20:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 13:39 bug#17172: 24.3.50; Timeouts when pasting from mouse Alex Bennée
2014-04-15 8:02 ` Paul Eggert
2014-04-15 10:17 ` Jan D.
2014-04-15 11:10 ` Nicolas Richard
2014-04-15 14:01 ` Alex Bennée
2014-04-15 16:01 ` Paul Eggert
2014-04-15 17:29 ` Jan Djärv
2014-04-15 20:19 ` Paul Eggert
2014-04-15 20:41 ` Jan Djärv [this message]
2014-04-17 7:53 ` Jan Djärv
2014-04-17 8:33 ` Nicolas Richard
2014-04-17 9:20 ` Jan Djärv
2014-04-17 10:19 ` Nicolas Richard
2014-04-17 12:10 ` Jan Djärv
2014-04-29 9:22 ` Nicolas Richard
2014-04-17 16:31 ` Jan Djärv
2014-04-15 16:00 ` Eli Zaretskii
2014-04-29 9:22 ` Nicolas Richard
2014-12-24 16:58 ` bug#17172: Timeouts when pasting David A. Thompson
2014-12-27 10:39 ` Torsten Bronger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43B05B9F-D0DA-47AC-B8FB-4A780FF3E095@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=17172@debbugs.gnu.org \
--cc=alex.bennee@linaro.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.