all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38563@debbugs.gnu.org
Subject: bug#38563: 27.0.50; Company popup renders with newlines (?) inheriting the bg properties of the character at next line's bol
Date: Wed, 18 Dec 2019 22:37:49 +0200	[thread overview]
Message-ID: <4397c5c2-e944-e684-82c4-e458826addc2@yandex.ru> (raw)
In-Reply-To: <837e2w5kzm.fsf@gnu.org>

On 16.12.2019 17:49, Eli Zaretskii wrote:

> Unfortunately, in bug#38633 in turned out my "fix" was not really a
> fix, but a stupid typo, which just happened to stop the problem in
> this bug from happening, but caused serious breakage elsewhere.
> 
> So I'm reopening this bug, and will have to think of a better
> solution.

In case you don't find it, how about we put 'default' as the 'face' 
property of the overlay? That seems to work.

And with that we can stop appending 'default' to all 'face' values in 
the overlay string.

WDYT?


diff --git a/company.el b/company.el
index 80398a3..399e9ea 100644
--- a/company.el
+++ b/company.el
@@ -2939,6 +2939,7 @@ Returns a negative number if the tooltip should be 
displayed above point."
            (overlay-put ov 'display disp)
          (overlay-put ov 'after-string disp)
          (overlay-put ov 'invisible t))
+      (overlay-put ov 'face 'default)
        (overlay-put ov 'window (selected-window)))))

  (defun company-pseudo-tooltip-guard ()





  reply	other threads:[~2019-12-18 20:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  1:13 bug#38563: 27.0.50; Company popup renders with newlines (?) inheriting the bg properties of the character at next line's bol Dmitry Gutov
2019-12-11 17:20 ` Eli Zaretskii
2019-12-11 21:47   ` Dmitry Gutov
2019-12-12 11:32     ` Eli Zaretskii
2019-12-12 22:13       ` Dmitry Gutov
2019-12-13  8:22         ` Eli Zaretskii
2019-12-13  9:30           ` Eli Zaretskii
2019-12-13 10:31             ` Eli Zaretskii
2019-12-13 12:00               ` Dmitry Gutov
2019-12-13 10:17           ` Dmitry Gutov
2019-12-13 14:12             ` Eli Zaretskii
2019-12-13 15:04               ` Dmitry Gutov
2019-12-13 15:32                 ` Eli Zaretskii
2019-12-13 23:10                   ` Dmitry Gutov
2019-12-14  8:13                     ` Eli Zaretskii
2019-12-15 22:26                       ` Dmitry Gutov
2019-12-16 15:49                         ` Eli Zaretskii
2019-12-18 20:37                           ` Dmitry Gutov [this message]
2019-12-21  7:53                             ` Eli Zaretskii
2019-12-21 13:22                               ` Dmitry Gutov
2019-12-21 13:31                                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4397c5c2-e944-e684-82c4-e458826addc2@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=38563@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.