From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: fancy-splash-screen customize group... Date: Thu, 08 Dec 2005 01:39:47 +0100 Message-ID: <439780D3.70401@student.lu.se> References: <200512072349.jB7Nn5fB031485@brains.moreideas.ca> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080209090308000903060401" X-Trace: sea.gmane.org 1134004405 566 80.91.229.2 (8 Dec 2005 01:13:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 8 Dec 2005 01:13:25 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 08 02:13:16 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EkAKB-0006ww-V3 for ged-emacs-devel@m.gmane.org; Thu, 08 Dec 2005 02:11:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EkAKS-0005yZ-04 for ged-emacs-devel@m.gmane.org; Wed, 07 Dec 2005 20:12:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ek9po-0003Ti-6H for emacs-devel@gnu.org; Wed, 07 Dec 2005 19:40:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ek9pj-0003SH-5S for emacs-devel@gnu.org; Wed, 07 Dec 2005 19:40:30 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ek9pg-0003RZ-JS for emacs-devel@gnu.org; Wed, 07 Dec 2005 19:40:25 -0500 Original-Received: from [81.228.11.98] (helo=pne-smtpout1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ek9qa-0007d6-Ep; Wed, 07 Dec 2005 19:41:20 -0500 Original-Received: from [192.168.123.121] (83.249.218.244) by pne-smtpout1-sn1.fre.skanova.net (7.2.060.1) id 4396EEA400029309; Thu, 8 Dec 2005 01:39:48 +0100 User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en Original-To: Peter Whaite , Per Abrahamsen In-Reply-To: <200512072349.jB7Nn5fB031485@brains.moreideas.ca> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47185 Archived-At: This is a multi-part message in MIME format. --------------080209090308000903060401 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Peter Whaite wrote: >Lennart Borgman wrote: > > >>Thanks, but are there really state buttons that are not next to options? Is >>not both yours and mine sentence wrong then? Or can you give an example, >>please? >> >> > >At the top of every customize group page there is a global state button >that can be used to set or save all the options that have been changed >in the page, e.g. > >/- Emacs group: ---------------------------------------------------------\ > State: visible group members are all at standard settings. > Customization of the One True Editor. > See also Manual. > >No big deal, though I don't think its necessary to say 'next to' as the >association between the State button and the option is obvious enough. > > Based on the feed back I made a new patch. I added the mouse over face (requires a small change to wid-edit.el - I think Per A hinted about that earlier) and rewrote the header text little. There is now also an explanation of what a button is in case there are no "custom-raised-buttons". I kept the 'next to' this time, I am not convinced yet ;-) --------------080209090308000903060401 Content-Type: text/plain; name="cus-edit-links-2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cus-edit-links-2.patch" Index: cus-edit.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/cus-edit.el,v retrieving revision 1.243 diff -c -r1.243 cus-edit.el *** cus-edit.el 4 Dec 2005 02:39:24 -0000 1.243 --- cus-edit.el 8 Dec 2005 00:31:47 -0000 *************** *** 1412,1417 **** --- 1412,1424 ---- 'custom-button-pressed 'custom-button-pressed-unraised)))) + (defface custom-link-face + `((((class color) (background light)) (:foreground "blue" :underline t)) + (((class color) (background dark)) (:foreground "cyan" :underline t))) + "Face used to highlight attributes that are links." + :group 'custom-faces) + + (defun custom-buffer-create-internal (options &optional description) (custom-mode) (if custom-buffer-verbose-help *************** *** 1419,1445 **** (widget-insert "This is a customization buffer") (if description (widget-insert description)) ! (widget-insert (format ". ! %s show active fields; type RET or click mouse-1 ! on an active field to invoke its action. Editing an option value ! changes only the text in the buffer. Invoke the State button to set or ! save the option value. Saving an option normally edits your init file. ! Invoke " ! (if custom-raised-buttons ! "`Raised' buttons" ! "Square brackets"))) (widget-create 'info-link ! :tag "Custom file" "(emacs)Saving Customizations") (widget-insert ! " for information on how to save in a different file. ! Invoke ") (widget-create 'info-link ! :tag "Help" :help-echo "Read the online help." "(emacs)Easy Customization") ! (widget-insert " for general information.\n\n") ! (widget-insert "Operate on everything in this buffer:\n ")) (widget-insert " ")) (widget-create 'push-button :tag "Set for Current Session" --- 1426,1461 ---- (widget-insert "This is a customization buffer") (if description (widget-insert description)) ! (widget-insert ". ! ! Editing an option value changes only the text in the buffer. The ! State button next to the option can be used to set or save the ! value. ! ! Saving an option normally edits your init file. See ") (widget-create 'info-link ! :button-face 'custom-link-face ! :button-prefix "" ! :button-suffix "" ! :mouse-face 'highlight ! :tag "custom file" "(emacs)Saving Customizations") (widget-insert ! "\nfor information on how to save in a different file.\n\nSee ") ! (widget-create 'info-link ! :button-face 'custom-link-face ! :button-prefix "" ! :button-suffix "" ! :mouse-face 'highlight ! :tag "help" :help-echo "Read the online help." "(emacs)Easy Customization") ! (widget-insert " for more information.\n\n") ! (unless custom-raised-buttons ! (widget-insert ! "Note: On your display type 'buttons' are represented with square\nbrackets.\n\n")) ! (widget-insert "Operate on all options in this buffer:\n ")) (widget-insert " ")) (widget-create 'push-button :tag "Set for Current Session" *************** *** 2149,2154 **** --- 2165,2174 ---- (insert " ") (push (widget-create-child-and-convert widget 'custom-group-link + :button-face 'custom-link-face + :button-prefix "" + :button-suffix "" + :mouse-face 'highlight :tag (custom-unlispify-tag-name symbol) symbol) buttons) *************** *** 2160,2166 **** (when links (insert "\nParent documentation: ") (while links ! (push (widget-create-child-and-convert widget (car links)) buttons) (setq links (cdr links)) (cond ((null links) --- 2180,2192 ---- (when links (insert "\nParent documentation: ") (while links ! (push (widget-create-child-and-convert ! widget (car links) ! :button-face 'custom-link-face ! :button-prefix "" ! :button-suffix "" ! :mouse-face 'highlight ! ) buttons) (setq links (cdr links)) (cond ((null links) --------------080209090308000903060401 Content-Type: text/plain; name="wid-edit-mouse-face.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="wid-edit-mouse-face.patch" Index: wid-edit.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/wid-edit.el,v retrieving revision 1.155 diff -c -r1.155 wid-edit.el *** wid-edit.el 16 Nov 2005 22:15:59 -0000 1.155 --- wid-edit.el 8 Dec 2005 00:21:50 -0000 *************** *** 403,409 **** ;; We want to avoid the face with image buttons. (unless (widget-get widget :suppress-face) (overlay-put overlay 'face (widget-apply widget :button-face-get)) ! (overlay-put overlay 'mouse-face widget-mouse-face)) (overlay-put overlay 'pointer 'hand) (overlay-put overlay 'follow-link follow-link) (overlay-put overlay 'help-echo help-echo))) --- 403,410 ---- ;; We want to avoid the face with image buttons. (unless (widget-get widget :suppress-face) (overlay-put overlay 'face (widget-apply widget :button-face-get)) ! ;;(overlay-put overlay 'mouse-face widget-mouse-face)) ! (overlay-put overlay 'mouse-face (widget-apply widget :mouse-face-get))) (overlay-put overlay 'pointer 'hand) (overlay-put overlay 'follow-link follow-link) (overlay-put overlay 'help-echo help-echo))) *************** *** 1390,1395 **** --- 1391,1397 ---- :offset 0 :format-handler 'widget-default-format-handler :button-face-get 'widget-default-button-face-get + :mouse-face-get 'widget-default-mouse-face-get :sample-face-get 'widget-default-sample-face-get :delete 'widget-default-delete :copy 'identity *************** *** 1533,1538 **** --- 1535,1548 ---- (if parent (widget-apply parent :button-face-get) widget-button-face)))) + + (defun widget-default-mouse-face-get (widget) + ;; Use :mouse-face or widget-mouse-face + (or (widget-get widget :mouse-face) + (let ((parent (widget-get widget :parent))) + (if parent + (widget-apply parent :mouse-face-get) + widget-mouse-face)))) (defun widget-default-sample-face-get (widget) ;; Use :sample-face. --------------080209090308000903060401 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --------------080209090308000903060401--