From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33992: 27.0.50; xref-find-definitions wastes too much space Date: Thu, 16 May 2019 01:37:53 +0300 Message-ID: <437558cf-3bd5-a6c7-e9d7-d22a87064d78@yandex.ru> References: <87muoe7jrs.fsf@mail.linkov.net> <87a7hp43a5.fsf@mail.linkov.net> <205acda7-07a3-d85c-378c-c178f9f76b55@yandex.ru> <87o95l4ht4.fsf@mail.linkov.net> <64f42172-460f-a633-1c80-23d34b5c0d07@yandex.ru> <87lg0m96bm.fsf@mail.linkov.net> <87ftpfqvvg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122234"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 33992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 00:51:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hR2ji-000VYd-9j for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 00:50:58 +0200 Original-Received: from localhost ([127.0.0.1]:43758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hR2jh-0005BX-3c for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 18:50:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hR2jU-0004uF-A9 for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:50:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hR2YA-0006x4-Md for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40043) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hR2YA-0006wy-Iy for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hR2YA-00048V-BS for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 18:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2019 22:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33992-submit@debbugs.gnu.org id=B33992.155795988715822 (code B ref 33992); Wed, 15 May 2019 22:39:02 +0000 Original-Received: (at 33992) by debbugs.gnu.org; 15 May 2019 22:38:07 +0000 Original-Received: from localhost ([127.0.0.1]:53587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR2XG-000478-Mi for submit@debbugs.gnu.org; Wed, 15 May 2019 18:38:06 -0400 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:37378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR2XE-00046c-LF for 33992@debbugs.gnu.org; Wed, 15 May 2019 18:38:05 -0400 Original-Received: by mail-lf1-f54.google.com with SMTP id q17so1058546lfo.4 for <33992@debbugs.gnu.org>; Wed, 15 May 2019 15:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kYpHP6USArkGc4GLRHtjZDrjsH5YM4gquXXrBO7RXBU=; b=HS5035z4f1JOUMaFAKhxNhUu0GrEyj1N/FcP/LbXdGFQ7Oe6XaUuMTZPbDzUrpWpYL CsE+lvQYZoo/mms9E9POnyMV2uJ4ldr2v+dcRk178aXsFnrdd6uZhx0M7Y6DRs2jjrzw tksQ7OR5SQsnRBuuoiVNWSZi1206VWKHmpmgRVreJ86JYNWlNCgYuJm1SsySXRjtjIkO gMGB7r4Jg30aUXVjle4OR2JPouYhQly0rFqKFsr8Lmjl4hNtlv9sR0qcYl1Ml2l6qRLQ 9Sa3g1SAaYBP1Eu9C34HTn6Jq2AAg879cpgLZzwsfrTkLSetzclXtD6b/RHIAQbd02Lw jT5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kYpHP6USArkGc4GLRHtjZDrjsH5YM4gquXXrBO7RXBU=; b=qJpaecl4rLtsoWPcdTx0V1+rxALk44/Kla1ODRdCpWUooA/eI3sbWtS9a8WgNhEgNZ b957RVIPNxCYWOSZbyLK8BL0Gci9c1yxHcnf5uqXhWPYUBy93jiAtBh5Ywvdaxcfmpa0 hNrnGLjLpRoTxfhn6XfogCSye38Mgr3UKbdHMcS+9eDyM2/aRYqVRnoQaAM69liNoiIv eo+ptV/sMw1g8AADaNrHXk/AzhCrPd3JJisJbKg1QWChJAhCo6kP+I4JO3R2moXsFKk/ +tJNodwPS4qrrrbZI0hML5Rzr5CurGtjBxrqyk8t47TFcQsl2/3JhkUA9VTqHsIfb0W4 rqTA== X-Gm-Message-State: APjAAAXAmZoGgEtRRx1gs2ONPU3PsSRTWBCrlkeCAokFZBaycJaFQPO/ nnxQMmeMqWraPOoK46hJJ0Y= X-Google-Smtp-Source: APXvYqzfZY+brBgOQdCnyQEnbFYLi24j0bvEGFWPXE8AiWd4AbSbnwSLCwbQos0U50m43X9+QdmNkg== X-Received: by 2002:ac2:434a:: with SMTP id o10mr16945634lfl.122.1557959877703; Wed, 15 May 2019 15:37:57 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id g14sm612375lfb.20.2019.05.15.15.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 15:37:56 -0700 (PDT) In-Reply-To: <87ftpfqvvg.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159367 Archived-At: On 15.05.2019 23:57, Juri Linkov wrote: >>>>> (defun display-buffer-condition-from-xref (_buffer-name _action) >>>>> (string-match-p "\\`\\*\\(xref\\)\\*\\(\\|<[0-9]+>\\)\\'" >>>>> (buffer-name (current-buffer)))) >>>> >>>> This function seems unused. >>> >>> It's unused because it would be useful only in the *xref* buffer >>> created by the xref-find-definitions command, so xref needs to >>> provide a way to distinguish such case. >> >> Shouldn't it be referenced somewhere else in your patch as well? > > A patch is proposed in a separate bug#35737. I don't see display-buffer-condition-from-xref used in that patch either, but it's not hugely important, really. > Created a separate bug#35592. Thanks. > Created a separate bug#35702. Thanks.