all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Roland Winkler" <winkler@gnu.org>
To: Teemu Likonen <tlikonen@iki.fi>
Cc: 44647@debbugs.gnu.org
Subject: bug#44647: 27.1.50; `bibtex-contline-indentation' doesn't work as file local variable
Date: Mon, 16 Nov 2020 10:36:43 -0600	[thread overview]
Message-ID: <43675.43620.246196.24498@gargle.gargle.HOWL> (raw)
In-Reply-To: <87eektcs81.fsf@iki.fi>

On Mon Nov 16 2020 Teemu Likonen wrote:
> > Your patch implies that the buffer-local value of fill-prefix is not
> > what it should be (say, if any other command wants to use it).
> 
> Yes. Bibtex-mode's filling uses fill-prefix and that variable must
> be set to correct value before filling. The correct moment may not
> be when a bibtex-mode buffer is initialized with buffer-local
> values.

Defcustom supports the keyword :set that can handle the case when a
user variable such as bibtex-contline-indentation is changed which
implies updating another variable such as fill-prefix.  However, I
assume that this is a rather rare case in the present context.

On the other hand, it is a design principle of emacs that variables
such as fill-prefix can be and are used by different commands.  So
they should have their proper value instead of only let-binding them
on the fly.  Such let-bindings are used only when it is the intent
to use different values than the proper buffer-local values.





  reply	other threads:[~2020-11-16 16:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 21:18 bug#44647: 27.1.50; `bibtex-contline-indentation' doesn't work as file local variable Teemu Likonen
2020-11-14 21:27 ` Teemu Likonen
2020-11-15  9:39   ` Teemu Likonen
2020-11-16  4:09   ` Roland Winkler
2020-11-16 14:05     ` Teemu Likonen
2020-11-16 16:36       ` Roland Winkler [this message]
2020-11-16 22:58   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43675.43620.246196.24498@gargle.gargle.HOWL \
    --to=winkler@gnu.org \
    --cc=44647@debbugs.gnu.org \
    --cc=tlikonen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.