From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 75226@debbugs.gnu.org, Jacob Faibussowitsch <jacob.fai@gmail.com>
Subject: bug#75226: [31.0.50] C++ ts-mode missing "alignof" as keyword
Date: Tue, 7 Jan 2025 19:09:40 -0800 [thread overview]
Message-ID: <43399C53-8860-43D1-A319-B3DE2885592E@gmail.com> (raw)
In-Reply-To: <1736D702-1BC1-4DF6-967C-052D9E446677@gmail.com>
> On Jan 3, 2025, at 11:34 PM, Yuan Fu <casouri@gmail.com> wrote:
>
>
>
>> On Jan 3, 2025, at 3:38 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>> From: Yuan Fu <casouri@gmail.com>
>>> Date: Fri, 3 Jan 2025 00:50:46 -0800
>>> Cc: Jacob Faibussowitsch <jacob.fai@gmail.com>,
>>> 75226@debbugs.gnu.org
>>>
>>>> On Jan 1, 2025, at 10:41 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>>
>>>>> Eli, what’s the status of Emacs 30 right now? Can I push to emacs-30 and have this change queued for Emacs 30.2? Or should I wait a bit?
>>>>
>>>> If this just adds a bunch of strings to c-ts-mode--keywords, it's okay
>>>> to add them on emacs-30.
>>>
>>> Not quite, right now emacs-30’s c-ts-mode works with grammar as far back as v0.19.0 [1]. If we just add the keywords, c-ts-mode wouldn’t work with grammar v0.20.4 and earlier. So I’m going to add the new keywords with a check, which disables the new keywords if grammar doesn’t recognize them. Also there’re many missing keywords, none of which I have seen before :-), I need time to go over them and see how are they supposed by be fontified (keyword face or something else).
>>>
>>> So let’s wait for 30.2.
>>
>> If so, please install on master, and let's consider backporting it to
>> the emacs-30 branch after 30.1 is released.
>>
>> Thanks.
>
> Sounds good.
>
> Yuan
I found that both c++-mode and c++-ts-mode fontifies C++ alternative operators like and_eq, xor, etc as keywords. Maybe we should fontify them in operator face (added in Emacs 29) instead?
Yuan
next prev parent reply other threads:[~2025-01-08 3:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-31 16:01 bug#75226: [31.0.50] C++ ts-mode missing "alignof" as keyword Jacob Faibussowitsch
2025-01-02 3:28 ` Yuan Fu
2025-01-02 5:06 ` Stefan Kangas
2025-01-02 6:41 ` Eli Zaretskii
2025-01-02 14:03 ` Jacob Faibussowitsch
2025-01-02 15:47 ` Eli Zaretskii
2025-01-03 8:50 ` Yuan Fu
2025-01-03 11:38 ` Eli Zaretskii
2025-01-04 7:34 ` Yuan Fu
2025-01-08 3:09 ` Yuan Fu [this message]
2025-01-08 12:49 ` Eli Zaretskii
2025-01-08 13:58 ` Jacob Faibussowitsch
2025-01-08 14:49 ` Alan Mackenzie
2025-01-08 17:12 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43399C53-8860-43D1-A319-B3DE2885592E@gmail.com \
--to=casouri@gmail.com \
--cc=75226@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jacob.fai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.