From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master a140513: Optimize certain memq forms during byte-compilation. Date: Sat, 24 Mar 2018 23:43:38 -0700 Organization: UCLA Computer Science Department Message-ID: <43249c06-3b78-3a2c-6989-0ba5981d92d3@cs.ucla.edu> References: <20180324193057.15201.3832@vcs0.savannah.gnu.org> <20180324193058.8731020445@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7D5552410D6F7713E78803B3" X-Trace: blaine.gmane.org 1521960145 17462 195.159.176.226 (25 Mar 2018 06:42:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Mar 2018 06:42:25 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: Vibhav Pant To: Glenn Morris , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 25 08:42:21 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezzMC-0004RJ-P9 for ged-emacs-devel@m.gmane.org; Sun, 25 Mar 2018 08:42:20 +0200 Original-Received: from localhost ([::1]:50246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezzOG-0001x3-7R for ged-emacs-devel@m.gmane.org; Sun, 25 Mar 2018 02:44:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezzNa-0001wo-2p for emacs-devel@gnu.org; Sun, 25 Mar 2018 02:43:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezzNW-0000nf-1P for emacs-devel@gnu.org; Sun, 25 Mar 2018 02:43:46 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42866) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezzNV-0000mb-PQ; Sun, 25 Mar 2018 02:43:41 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 921D016169C; Sat, 24 Mar 2018 23:43:39 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SxC6bqdlEDfl; Sat, 24 Mar 2018 23:43:38 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D4FDF1616B5; Sat, 24 Mar 2018 23:43:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ii6uoSehVNyO; Sat, 24 Mar 2018 23:43:38 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B003916169C; Sat, 24 Mar 2018 23:43:38 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223989 Archived-At: This is a multi-part message in MIME format. --------------7D5552410D6F7713E78803B3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit The memq-related patch doesn't look quite right to me, since byte-optimize-and might be called on a form that is not 'and'. Does the attached patch fix things for you? --------------7D5552410D6F7713E78803B3 Content-Type: text/x-patch; name="byte-opt.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="byte-opt.diff" diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el index 54421e01be..15e4536659 100644 --- a/lisp/emacs-lisp/byte-opt.el +++ b/lisp/emacs-lisp/byte-opt.el @@ -777,7 +777,7 @@ byte-optimize-memq (setq form `(and ,(byte-optimize-predicate `(eq ,(nth 1 form) ',(nth 0 list))) ',list)))) - (byte-optimize-and form))) + (byte-optimize-predicate form))) (put 'identity 'byte-optimizer 'byte-optimize-identity) (put 'memq 'byte-optimizer 'byte-optimize-memq) --------------7D5552410D6F7713E78803B3--