From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer Date: Sat, 18 Dec 2021 10:05:50 +0100 Message-ID: <4318fa2c-0127-4a14-f65e-399b5c097028@gmx.at> References: <865yrqsxmu.fsf@mail.linkov.net> <865yro7csh.fsf@mail.linkov.net> <83h7b8fngd.fsf@gnu.org> <86v8zo4bma.fsf@mail.linkov.net> <83fsqsfh8i.fsf@gnu.org> <86tuf73aen.fsf@mail.linkov.net> <83h7b7e8t2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7775"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52491@debbugs.gnu.org To: Eli Zaretskii , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 18 10:07:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myVgM-0001ov-EY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 10:07:10 +0100 Original-Received: from localhost ([::1]:53524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myVgK-0005A8-Dr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 04:07:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myVgE-00058F-5d for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 04:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myVgD-0005uA-St for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 04:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myVgD-0002WM-LS for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 04:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Dec 2021 09:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52491 X-GNU-PR-Package: emacs Original-Received: via spool by 52491-submit@debbugs.gnu.org id=B52491.16398183619612 (code B ref 52491); Sat, 18 Dec 2021 09:07:01 +0000 Original-Received: (at 52491) by debbugs.gnu.org; 18 Dec 2021 09:06:01 +0000 Original-Received: from localhost ([127.0.0.1]:41251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myVfF-0002Uv-3x for submit@debbugs.gnu.org; Sat, 18 Dec 2021 04:06:01 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:56887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myVfD-0002Ue-2a for 52491@debbugs.gnu.org; Sat, 18 Dec 2021 04:05:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639818352; bh=pGs8GyPStiqkKg7vA5aE5l7IRjEoYFHWnuO58wXdRIw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=LD2OSbd+eBVzmzfC1w6ECZtILrmDggzOtI2nhvOLrXeIiGVbNNeFv6i5DHL3PtlFE UuAHsIquHzFNvoBzxvNvec6+Y+BUm5ZaEpGfy6cOMyCs0ulO7VGNI8CtPY0XRaT7bv hwbMjQ6aMSLFv9hloBFjqfinLOb4HayxclYw9lJo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.38]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWASY-1n1JzG1zha-00XbxJ; Sat, 18 Dec 2021 10:05:52 +0100 In-Reply-To: <83h7b7e8t2.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:1hnY0WhOlFws613Gb77VpGNXtydUiCEnxzZjaseQ/yT4O2+3yIh Rb6wYkZ5W6VjVh8AP617g0n6uM9SBdtrxMeV4xeWBtkMF1kbCjICub6ZAtkRyem05vw19rk 8WW/cFrpou16Llvqtx9XfBzDHeKlLQP1/lZ4Tw+wmDx/pJ8IxDD5GRYMw6E1I7eePbgWKkI QRq5wZ0OdIx2GTENxgunA== X-UI-Out-Filterresults: notjunk:1;V03:K0:QtnOrF4AkLY=:90bb8tidX/Iq8nEu/aTDqJ 7fkf/8n+B+Pp1g4DHpf+Y+P3BwiLY4QoDC29vwJIeacMOv1SpoDWNI9c8opq6sIAJVRduDtLD dBhFgIRnBLQIIgzqhgXWliUgl0ga5QfWNm+ZChDWrWY1u1FH4PVOMAOAAT2i9ic54bZe/tQa+ zaM0+r2TzsPsClB+ogF3wM/C4MODkBLjSghoa+X8yCXfldQU8ZrMvrb8gwFopHupu85H2FJRH RQXgYQF+3reLdUvwgqFmLzXusCm7xDlNgKqhMTP3hxBu68HqFPDT8W6QOmShlyEhP1NUqgf2A mkyIC+MbzzVTUcupQr8euZbxye6w/5KQvwKXbGZGF6Yg0N+co1BnYOdwy2Pt5loigA+bcxRpu 1W7Fm/3UtHi0LcKKCSklvHM+lXrgLR6CUoXVrh1xas5GPs/R5hI0MoS7hgWpGK9gIx5CJVnK7 Rw3VjMPgRQdtw8PFeDbCfUjvayvO9a4LRGOy91SPMUGfiLGIPvtA+aJnHjm83a6Na6jp33p1c aBGv5mrJCVqQ9c9wyK+Xhj2lJXSc6nArvPZkXnnZcE33qF1yNe7SA07jV3azWTlGJx3uKiklf xM5U7+lHQ1Sbt3adk72mNfpNXKZwxvqI95gdn50B1Di2l0q29SjrPLm7ljgtroOABFgXEqBTw SfOmc0+2CaSmyd/wnyKocBEd6QKkxmsmyL4BHyo4hYrIrmZb5qOzqq3XjWMkOobkx/iTQnwgz JyRDggtx2QWjSCuJJf/ASTnpnYDyQcJkPvI5BYnNZZkl7dtCACqsNh/TE0/wuLvXHKsObFUA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222602 Archived-At: > Martin, any comments on this for the release branch? It looks > non-trivial to me, and delete-window is a low-level API. The bug is a regression so it should be fixed. Whether and how Juri's fix can affect other operations that use the minibuffer before deleting some window is beyond my imagination. I do not understand two things: It seems that this part of the doc-string A minibuffer window is never a candidate when MINIBUF is nil or omitted. MINIBUF t means consider the minibuffer window only if the minibuffer is active. does not match well this part of the code (dolist (window (window-list-1 nil (unless minibuf 'nomini) all-frames)) And this (are we sure that we always want to do it when "setting up" completions?) (setq-local delete-window-choose-selected 'mru) apparently makes this binding (choose-selected delete-window-choose-selected) necessary. But this would imply that at the time 'delete-window' is called, its buffer is current which is by no means guaranteed. So the latter form should probably become (choose-selected (buffer-local-value 'delete-window-choose-selected (window-buffer window)))) martin