From: Phil Sainty <psainty@orcon.net.nz>
To: 34657@debbugs.gnu.org
Subject: bug#34657: 26.1; Some erc hook names lack the expected suffix
Date: Tue, 26 Feb 2019 12:54:57 +1300 [thread overview]
Message-ID: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> (raw)
`erc-before-connect' and `erc-after-connect' are abnormal hooks,
so I think they should each have the suffix "-functions" for
consistency, and so that they are easier to discover.
Is is ok to rename them and defvaralias the old names?
All other erc hooks have the -hook or -functions suffix, so far
as I can see.
For reference:
(defcustom erc-before-connect nil
"Hook called before connecting to a server.
This hook gets executed before `erc' actually invokes `erc-mode'
with your input data. The functions in here get called with three
parameters, SERVER, PORT and NICK."
:group 'erc-hooks
:type 'hook)
(defcustom erc-after-connect nil
"Hook called after connecting to a server.
This hook gets executed when an end of MOTD has been received. All
functions in here get called with the parameters SERVER and NICK."
:group 'erc-hooks
:type 'hook)
In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, Xaw
scroll bars)
of 2019-01-07 built on hal
Repository revision: b0b483d714e87ee0a4572f9c541514a1ac1a8226
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version
11.0.11906000
System Description: Ubuntu 18.04.2 LTS
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading erc...done
uncompressing erc.el.gz...done
Mark set
Configured using:
'configure --prefix=/home/phil/emacs/head/usr/local
--with-x-toolkit=lucid --without-sound'
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GSETTINGS GLIB NOTIFY
INOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11
XDBE XIM THREADS LCMS2 GMP
Important settings:
value of $LANG: en_NZ.UTF-8
locale-coding-system: utf-8-unix
Major mode: Emacs-Lisp
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa
derived epg epg-config gnus-util rmail rmail-loaddefs time-date
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils help-fns radix-tree help-mode easymenu jka-compr find-func
erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json map seq
byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib thingatpt pp
erc-loaddefs dired dired-loaddefs advice elec-pair mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting x-toolkit x multi-tty
make-network-process emacs)
Memory information:
((conses 16 119750 7960)
(symbols 48 22664 1)
(strings 32 36457 2107)
(string-bytes 1 986101)
(vectors 16 18682)
(vector-slots 8 549648 11634)
(floats 8 51 66)
(intervals 56 588 50)
(buffers 992 15))
next reply other threads:[~2019-02-25 23:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 23:54 Phil Sainty [this message]
2019-02-26 3:32 ` bug#34657: 26.1; Some erc hook names lack the expected suffix Eli Zaretskii
2019-02-27 11:01 ` Phil Sainty
2019-02-27 16:30 ` Eli Zaretskii
2019-02-27 19:30 ` Phil Sainty
2020-08-03 8:34 ` Lars Ingebrigtsen
2020-08-31 9:55 ` Stefan Kangas
2020-09-01 14:31 ` Lars Ingebrigtsen
2021-02-27 4:43 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=34657@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.