set-fontset-font do not work again.

set-fontset-font do not work again.

[tumashu]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hello:


I have found that the below code does not work  in emacs-29 git, any suggestion? thanks.



;; This is a test, 这是一个测试
(dolist (charset '(kana han symbol cjk-misc bopomofo))
  (set-fontset-font
   t
   charset
   (font-spec :name "Microsoft Yahei"
              :weight 'normal
              :slant 'normal
              :size 16)))


[-- Attachment #2: Type: text/html, Size: 845 bytes --]

Re: set-fontset-font do not work again.

[Eli Zaretskii]

> Date: Mon, 8 Nov 2021 10:06:37 +0800 (CST)
> From: tumashu <tumashu@163.com>
> 
> I have found that the below code does not work  in emacs-29 git, any suggestion? thanks.
> 
> ;; This is a test, 这是一个测试
> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>   (set-fontset-font
>    t
>    charset
>    (font-spec :name "Microsoft Yahei"
>               :weight 'normal
>               :slant 'normal
>               :size 16)))

"Does not work" in what sense?  What happens if you execute this code?

Re:Re: set-fontset-font do not work again.

[tumashu]

在 2021-11-08 11:30:34，"Eli Zaretskii" <eliz@gnu.org> 写道：
>> Date: Mon, 8 Nov 2021 10:06:37 +0800 (CST)
>> From: tumashu <tumashu@163.com>
>> 
>> I have found that the below code does not work  in emacs-29 git, any suggestion? thanks.
>> 
>> ;; This is a test, 这是一个测试
>> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>>   (set-fontset-font
>>    t
>>    charset
>>    (font-spec :name "Microsoft Yahei"
>>               :weight 'normal
>>               :slant 'normal
>>               :size 16)))
>
>"Does not work" in what sense?  What happens if you execute this code?

It will let Chinese use "Microsoft Yahei" font, but now it seem to do nothing.

Re: set-fontset-font do not work again.

[Eli Zaretskii]

> Date: Mon, 8 Nov 2021 11:33:06 +0800 (CST)
> From: tumashu  <tumashu@163.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> >> (dolist (charset '(kana han symbol cjk-misc bopomofo))
> >>   (set-fontset-font
> >>    t
> >>    charset
> >>    (font-spec :name "Microsoft Yahei"
> >>               :weight 'normal
> >>               :slant 'normal
> >>               :size 16)))
> >
> >"Does not work" in what sense?  What happens if you execute this code?
> 
> It will let Chinese use "Microsoft Yahei" font, but now it seem to do nothing.

You are saying it worked in Emacs 28, but doesn't work in Emacs 29?

Why are you using both :name and :weight/:slant/:size?  What happens
if you try this instead:

 (dolist (charset '(kana han symbol cjk-misc bopomofo))
   (set-fontset-font t charset "Microsoft Yahei"))

Re:Re: set-fontset-font do not work again.

[tumashu]

At 2021-11-08 20:59:50, "Eli Zaretskii" <eliz@gnu.org> wrote:

>> Date: Mon, 8 Nov 2021 11:33:06 +0800 (CST)
>> From: tumashu  <tumashu@163.com>
>> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
>> 
>> >> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>> >>   (set-fontset-font
>> >>    t
>> >>    charset
>> >>    (font-spec :name "Microsoft Yahei"
>> >>               :weight 'normal
>> >>               :slant 'normal
>> >>               :size 16)))
>> >
>> >"Does not work" in what sense?  What happens if you execute this code?
>> 
>> It will let Chinese use "Microsoft Yahei" font, but now it seem to do nothing.
>
>You are saying it worked in Emacs 28, but doesn't work in Emacs 29?

yes


>
>Why are you using both :name and :weight/:slant/:size?  What happens

(dolist (charset '(kana han symbol cjk-misc bopomofo))
  (set-fontset-font
   t
   charset
   (font-spec :name "Microsoft Yahei"
              :slant 'normal
              :size 20)))

The above code  works,  so I think the problem is :   :weight 'normal 




>if you try this instead:
>
> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>   (set-fontset-font t charset "Microsoft Yahei"))

This work.

Re: set-fontset-font do not work again.

[Yuan Fu]

>> 
>> Why are you using both :name and :weight/:slant/:size?  What happens
> 
> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>  (set-fontset-font
>   t
>   charset
>   (font-spec :name "Microsoft Yahei"
>              :slant 'normal
>              :size 20)))
> 
> The above code  works,  so I think the problem is :   :weight ‘normal 

I usually use ‘regular, maybe ‘normal isn’t supported?

Yuan

Re: set-fontset-font do not work again.

[Lars Ingebrigtsen]

Yuan Fu <casouri@gmail.com> writes:

>> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>>  (set-fontset-font
>>   t
>>   charset
>>   (font-spec :name "Microsoft Yahei"
>>              :slant 'normal
>>              :size 20)))
>> 
>> The above code  works,  so I think the problem is :   :weight ‘normal 
>
> I usually use ‘regular, maybe ‘normal isn’t supported?

Could this possibly have something to do with:

commit 65fd3ca84f75aee0dfebb87fa793dae57c1caf35
Author:     Lars Ingebrigtsen <larsi@gnus.org>
AuthorDate: Thu Oct 21 04:30:02 2021 +0200

    Support the "medium" font weight

This entailed tweaking the font weight mapping tables a bit, so perhaps
it's having unintended consequences on this particular font?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re:Re: set-fontset-font do not work again.

[tumashu]

At 2021-11-09 11:22:29, "Lars Ingebrigtsen" <larsi@gnus.org> wrote:
>Yuan Fu <casouri@gmail.com> writes:
>
>>> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>>>  (set-fontset-font
>>>   t
>>>   charset
>>>   (font-spec :name "Microsoft Yahei"
>>>              :slant 'normal
>>>              :size 20)))
>>> 
>>> The above code  works,  so I think the problem is :   :weight ‘normal 
>>
>> I usually use ‘regular, maybe ‘normal isn’t supported?
>
>Could this possibly have something to do with:
>
>commit 65fd3ca84f75aee0dfebb87fa793dae57c1caf35
>Author:     Lars Ingebrigtsen <larsi@gnus.org>
>AuthorDate: Thu Oct 21 04:30:02 2021 +0200
>
>    Support the "medium" font weight
>
>This entailed tweaking the font weight mapping tables a bit, so perhaps
>it's having unintended consequences on this particular font?

Yes, it is this commit's issue, I have tested.

All Chinese fonts installed in my computer  does not work well.

>
>-- 
>(domestic pets only, the antidote for overdose, milk.)
>   bloggy blog: http://lars.ingebrigtsen.no

Re: set-fontset-font do not work again.

[Lars Ingebrigtsen]

tumashu  <tumashu@163.com> writes:

> Yes, it is this commit's issue, I have tested.
>
> All Chinese fonts installed in my computer  does not work well.

Please submit a bug report about this with `M-x report-emacs-bug' (so
that we can track the problem and get info on your system).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: set-fontset-font do not work again.

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: tumashu <tumashu@163.com>,  Eli Zaretskii <eliz@gnu.org>,
>   "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> Date: Tue, 09 Nov 2021 04:22:29 +0100
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
> >> (dolist (charset '(kana han symbol cjk-misc bopomofo))
> >>  (set-fontset-font
> >>   t
> >>   charset
> >>   (font-spec :name "Microsoft Yahei"
> >>              :slant 'normal
> >>              :size 20)))
> >> 
> >> The above code  works,  so I think the problem is :   :weight ‘normal 
> >
> > I usually use ‘regular, maybe ‘normal isn’t supported?
> 
> Could this possibly have something to do with:
> 
> commit 65fd3ca84f75aee0dfebb87fa793dae57c1caf35
> Author:     Lars Ingebrigtsen <larsi@gnus.org>
> AuthorDate: Thu Oct 21 04:30:02 2021 +0200
> 
>     Support the "medium" font weight
> 
> This entailed tweaking the font weight mapping tables a bit, so perhaps
> it's having unintended consequences on this particular font?

You touched slant values as well?  I don't see any change in contents
of font-slant-table, FWIW.

Re: set-fontset-font do not work again.

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> >> (dolist (charset '(kana han symbol cjk-misc bopomofo))
>> >>  (set-fontset-font
>> >>   t
>> >>   charset
>> >>   (font-spec :name "Microsoft Yahei"
>> >>              :slant 'normal
>> >>              :size 20)))
>> >> 
>> >> The above code  works,  so I think the problem is :   :weight ‘normal 
>> >
>> > I usually use ‘regular, maybe ‘normal isn’t supported?

[...]

> You touched slant values as well?  I don't see any change in contents
> of font-slant-table, FWIW.

No, he's talking about :weight 'normal, not :slant 'normal.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: set-fontset-font do not work again.

[Eli Zaretskii]

> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 8 Nov 2021 19:12:10 -0800
> Cc: Eli Zaretskii <eliz@gnu.org>,
>  "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> 
> >> 
> >> Why are you using both :name and :weight/:slant/:size?  What happens
> > 
> > (dolist (charset '(kana han symbol cjk-misc bopomofo))
> >  (set-fontset-font
> >   t
> >   charset
> >   (font-spec :name "Microsoft Yahei"
> >              :slant 'normal
> >              :size 20)))
> > 
> > The above code  works,  so I think the problem is :   :weight ‘normal 
> 
> I usually use ‘regular, maybe ‘normal isn’t supported?

No, 'normal' is the documented value.  I think you confuse :slant with
:width or something.