From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id vR8GF4y+5mCyHAAAgWs5BA (envelope-from ) for ; Thu, 08 Jul 2021 10:59:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AKU0Eoy+5mAJNwAAB5/wlQ (envelope-from ) for ; Thu, 08 Jul 2021 08:59:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03D7925C92 for ; Thu, 8 Jul 2021 10:59:55 +0200 (CEST) Received: from localhost ([::1]:36456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Psu-00076i-6i for larch@yhetil.org; Thu, 08 Jul 2021 04:59:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1PsD-00076J-Dy for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 04:59:09 -0400 Received: from smtp.chopps.org ([54.88.81.56]:54258) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1PsB-0004gj-1L for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 04:59:09 -0400 Received: from smtpclient.apple (047-026-251-217.res.spectrum.com [47.26.251.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by smtp.chopps.org (Postfix) with ESMTPSA id F2FD380E88; Thu, 8 Jul 2021 08:59:04 +0000 (UTC) From: Christian Hopps Message-Id: <42F783E1-86BF-4980-AD50-3673DC98D12B@chopps.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_51CA6CB0-188C-41D5-8DD6-E401C3B561A4" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [new patch] [PATCH] make org-notify support for macOS desktop notification Date: Thu, 8 Jul 2021 04:59:03 -0400 In-Reply-To: <10EF755E-7DA3-454D-88D7-80C0A8D0E566@gmail.com> To: stardiviner References: <5B57CD8B-AA91-4C63-A449-A07364083AEE@gmail.com> <87im1ol2lb.fsf@gmail.com> <7318E1D0-613A-4301-8097-779D3FEF1105@gmail.com> <1CCC83B2-3EFB-4221-9543-03A7BA935C70@gmail.com> <89A2389D-0283-4C12-B80D-831730ABB2A2@chopps.org> <10EF755E-7DA3-454D-88D7-80C0A8D0E566@gmail.com> X-Mailer: Apple Mail (2.3654.100.0.2.22) Received-SPF: none client-ip=54.88.81.56; envelope-from=chopps@chopps.org; helo=smtp.chopps.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Cross , Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625734796; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=wKpBIGHyEGuePCNxYCcQr5zn+vfPWvZPqvUmCNAggaI=; b=oM0wbzVSc450Qw75iwmCpbKg+gXNhW8E6+BRxBbHqiOMSf5qQP5dqIlfs+Sumnwugp2W6X EMt28swrdHILZbyhQpR1gGn1hFt4t1cuGEOSUH0GeSQvvHleG0vO5EGWkjz+k8UXNF9ElZ p9XvIetYNdW1So/9UM5EAMhZ3CC35cCt2CXiPT1ZKhhV5+PY6i5oC29o3wwRNhmcGkDTLC G4vgFdAOMMUrahAu3sYkpVS+TMh7nqG0b4FAKuOUic41QpU+SRPicXqfxZ8+eInw08oirc jhSwPHbUSmdwTRrNAxGZOJqf8KDNWD3KlHx/qPPd6dkPe0nhPCORyzd+ZUk9gw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625734796; a=rsa-sha256; cv=none; b=YL/QQCsqMYzwgfwG/ExvEe9UvUUCe/WrDFyoUx3yu0cZP4ZXEwRHfnXPYsHWHdVhPI36mV MqrsqTAT5ta18ockBQCCs7gMTUurSjnstPq3de4QCxirAWqte1BhaWUrSvXhdiHHZC0dQ4 2zpCl1VzK8UyYaT+gVOTThByy6ZbT3GE1vizIqRqE2pbKUV37oWn1y3Ex9++zd0XFc4UOP fD7t/jbriijJC+tw1r13twTTqIMrtXl/3a4dkrAPWlY2FTZ2g3XYTcY2joL4XEY0F0ZNGh sgljvQRy9uSma97mus4h7lb9t6zbYAAHDzeVFQmllsZdX/Jdgs2yUakJKO3frg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 03D7925C92 X-Spam-Score: -1.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9L05uh1EnsgN --Apple-Mail=_51CA6CB0-188C-41D5-8DD6-E401C3B561A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 It may eventually be incorporated into the very popular emacs-mac port = (railwaycat tap in homebrew); however, it will probably not be = incorporated into the nextstep/emacs main code. I started looking at = doing a version for the mainline code, but it=E2=80=99s hard to get = motivated b/c using that version of emacs on OS X is a pretty sub-par = experience. I only commented on this b/c I think you might are disabling = notifications-notify which work great with my code changes, and using = something else if you see Darwin OS, and that will break my native = =E2=80=9CJust Works=E2=80=9D support for notifications, which again may = end up on many peoples machines. I would ask that the patch be modified = in a way that didn=E2=80=99t break native support if present before it = was accepted. Also as you can see by the multiple patches you=E2=80=99ve submitted = there=E2=80=99s really no good answer for an external notifier, so = whatever you pick is probably going to be wrong for someone I guess. If this patch is going to be accepted I would ask that it 1) be conditional (disable-able with a variable) 2) do the check for the custom installed external notifier and if not = present then fallback to using the emacs supplied notifications-notify 3) not restrict notifications-notify to gnu/linux only. That way people that have already developed solutions for this won=E2=80=99= t have them broken. Thanks, Chris. > On Jul 7, 2021, at 8:00 PM, stardiviner wrote: >=20 > Hi Chris, thanks for your work. I have a question, will your patch of = notification code be merged to upstream? > If yes, I think my patch will be not necessary. If no, then I think = add a my workaround for macOS is considerable. >=20 >> On Jul 7, 2021, at 2:23 AM, Christian Hopps > wrote: >>=20 >> It supports imagemagick (specify =E2=80=94with-imagemagick), and it = includes svg by default, I simply forked the railwaycat version and = added the native notification code. >>=20 >> Thanks, >> Chris. >>=20 >>> On Jul 6, 2021, at 11:30 AM, stardiviner > wrote: >>>=20 >>> Thanks for your suggestion. Does your Emacs build supports = imagemagick image view and svg feature support? Because company-mode now = have built-in icons support. This is the reason that I switch from = https://emacsformacosx.com/ to Homebrew = cask Emacs version. >>>=20 >>>> On Jul 6, 2021, at 12:21 PM, Christian Hopps > wrote: >>>>=20 >>>> Hi, >>>>=20 >>>> Please consider: I added full native notification support to the = popular OS X Emacs build available in homebrew. This supports rewrites = notifications-notify defun to use the native code rather than dbus, and = so everything "Just Works". >>>>=20 >>>> Info can be found here: >>>>=20 >>>> https://github.com/choppsv1/homebrew-emacsmacport = >>>>=20 >>>> Thanks, >>>> Chris. >>>>=20 >>>> stardiviner > = writes: >>>>=20 >>>>> Here is the new patch which invokes notifications though Emacs = built-in API `ns-do-applescript`. >>>>>=20 >>>>> [2. text/x-patch; = 0001-org-clock.el-Make-org-notify-support-macOS-notificat.patch]... >>>>>=20 >>>>>=20 >>>>>=20 >>>>>> On Jul 6, 2021, at 8:06 AM, Tim Cross > wrote: >>>>>>=20 >>>>>>=20 >>>>>> stardiviner > = writes: >>>>>>=20 >>>>>>>> On Jul 5, 2021, at 7:55 PM, Maxim Nikulin > wrote: >>>>>>>>=20 >>>>>>>> On 05/07/2021 10:50, stardiviner wrote: >>>>>>>>> I updated the patch, I found the package `osx-lib` contains = solution. >>>>>>>>> So I removed the directly osascript process invocation. >>>>>>>>=20 >>>>>>>> I have no objections any more. On the other hand I have no = access to macOS, so >>>>>>>> I have not tested this patch. Feel free to ignore comments from = this message, >>>>>>>> they are mostly matter of taste. >>>>>>>>=20 >>>>>>>> I expect that a simple script "notify-send" may allow to avoid = modification of >>>>>>>> code. Something like (untested, unsure concerning "quoted form = of ...") >>>>>>>>=20 >>>>>>>> #!/usr/bin/env osascript >>>>>>>> display notification (item 1 of argv) >>>>>>>>=20 >>>>>>>> However if osx-lib in is installed automatically, it may be = more convenient. >>>>>>>> Unsure if some of currently supported linux distributions have = notify-send >>>>>>>> that can not handle title as the first argument. >>>>>>>>=20 >>>>>>>>> - ((fboundp 'notifications-notify) >>>>>>>>> + ((and (eq system-type 'gnu/linux) (fboundp = 'notifications-notify)) >>>>>>>>=20 >>>>>>>> Does it mean that `notifications-notify' is bound but it does = not work on >>>>>>>> macOS? If so, maybe it is better to put new clause for 'darwin = above and to >>>>>>>> drop 'gnu/linux here. =46rom my point of view, it is preferable = to avoid >>>>>>>> additional requirement for `notifications-notify'. If someone = will create a >>>>>>>> feature request for `notifications-notify' for macOS, it will = just work >>>>>>>> without installing of additional packages as soon as such = feature is >>>>>>>> implemented. >>>>>>>>=20 >>>>>>>>=20 >>>>>>> I indeed tried `notifications-notify`. And it does not work, = reports error that >>>>>>> it needs dbus. PS. I used the Homebrew formulae version Emacs. >>>>>>> I considered the order of conditions. Because notifications and = notify-send etc >>>>>>> requires dbus. So I guess only Linux supports that. So add = system-type detection >>>>>>> will be better. WDYT? >>>>>>=20 >>>>>> I think you can add dbus support to macOS using homebrew and that = might >>>>>> resolve the issue. At the very least, this will need to be = investigated >>>>>> because otherwise, adding this patch may break configurations for = users >>>>>> who have added dbus support via homebrew and have notifications = working, >>>>>> but have not installed the osx-lib package. >>>>>>=20 >>>>>> My only small concern with your proposed changes is that it will = add a >>>>>> dependency on a new package osx-lib, which I think is only = available in >>>>>> melpa. At the very least, this will need to be documented = somewhere. >>>>>> However, I'm not sure what the situation is wrt adding code which >>>>>> depends on an external package which is not available in either = elpa or >>>>>> nongnuELPA? As org mode is a part of GNU Emacs, I suspect that = any code >>>>>> which 'encourages' the use of melpa packages will not be = acceptable. >>>>>>=20 >>>>>> -- >>>>>> Tim Cross >>>>>>=20 >>>>=20 >>>=20 >>=20 >=20 --Apple-Mail=_51CA6CB0-188C-41D5-8DD6-E401C3B561A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 It = may eventually be incorporated into the very popular emacs-mac port = (railwaycat tap in homebrew); however, it will probably not be = incorporated into the nextstep/emacs main code. I started looking at = doing a version for the mainline code, but it=E2=80=99s hard to get = motivated b/c using that version of emacs on OS X is a pretty sub-par = experience.

I only = commented on this b/c I think you might are disabling = notifications-notify which work great with my code changes, and using = something else if you see Darwin OS, and that will break my native = =E2=80=9CJust Works=E2=80=9D support for notifications, which again may = end up on many peoples machines. I would ask that the patch be modified = in a way that didn=E2=80=99t break native support if present before it = was accepted.

Also as you can see by the multiple patches you=E2=80=99ve = submitted there=E2=80=99s really no good answer for an external = notifier, so whatever you pick is probably going to be wrong for someone = I guess.

If = this patch is going to be accepted I would ask that it

1) be conditional = (disable-able with a variable)
2) do the check for = the custom installed external notifier and if not present then fallback = to using the emacs supplied notifications-notify
3) = not restrict notifications-notify to gnu/linux only.

That way people that = have already developed solutions for this won=E2=80=99t have them = broken.

Thanks,
Chris.

On Jul = 7, 2021, at 8:00 PM, stardiviner <numbchild@gmail.com>= wrote:

Hi Chris, thanks for = your work. I have a question, will your patch of notification code be = merged to upstream?
If yes, I think my patch will be not = necessary. If no, then I think add a my workaround for macOS is = considerable.

On Jul 7, 2021, at 2:23 AM, = Christian Hopps <chopps@chopps.org> wrote:

It supports = imagemagick (specify =E2=80=94with-imagemagick), and it includes svg by = default, I simply forked the railwaycat version and added the native = notification code.

Thanks,
Chris.

On Jul 6, 2021, at 11:30 AM, stardiviner <numbchild@gmail.com>= wrote:

Thanks for your = suggestion. Does your Emacs build supports imagemagick image view and = svg feature support? Because company-mode now have built-in icons = support. This is the reason that I switch from https://emacsformacosx.com/ to Homebrew cask Emacs = version.

On Jul 6, 2021, at 12:21 PM, = Christian Hopps <chopps@chopps.org> wrote:

Hi,
Please consider: I added full native = notification support to the popular OS X Emacs build available in = homebrew. This supports rewrites notifications-notify defun to use the = native code rather than dbus, and so everything "Just Works".

Info can be found here:

https://github.com/choppsv1/homebrew-emacsmacport

Thanks,
Chris.

stardiviner <numbchild@gmail.com> writes:

Here is the new patch = which invokes notifications though Emacs built-in API = `ns-do-applescript`.

[2. text/x-patch; = 0001-org-clock.el-Make-org-notify-support-macOS-notificat.patch]...



On Jul 6, 2021, at 8:06 AM, Tim Cross <theophilusx@gmail.com> wrote:


stardiviner <numbchild@gmail.com>= writes:

On Jul 5, 2021, at 7:55 = PM, Maxim Nikulin <manikulin@gmail.com> wrote:

On 05/07/2021 10:50, stardiviner wrote:
I updated the patch, I = found the package `osx-lib` contains solution.
So I = removed the directly osascript process invocation.

I have no objections any more. On = the other hand I have no access to macOS, so
I have not = tested this patch. Feel free to ignore comments from this message,
they are mostly matter of taste.

I= expect that a simple script "notify-send" may allow to avoid = modification of
code. Something like (untested, unsure = concerning "quoted form of ...")

#!/usr/bin/env osascript
display notification = (item 1 of argv)

However if osx-lib in is = installed automatically, it may be more convenient.
Unsure = if some of currently supported linux distributions have notify-send
that can not handle title as the first argument.

- ((fboundp = 'notifications-notify)
+ ((and (eq system-type 'gnu/linux) = (fboundp 'notifications-notify))

Does it mean that `notifications-notify' is bound but it does = not work on
macOS? If so, maybe it is better to put new = clause for 'darwin above and to
drop 'gnu/linux here. =46rom= my point of view, it is preferable to avoid
additional = requirement for `notifications-notify'. If someone will create a
feature request for `notifications-notify' for macOS, it will = just work
without installing of additional packages as = soon as such feature is
implemented.


I indeed tried = `notifications-notify`. And it does not work, reports error that
it needs dbus. PS. I used the Homebrew formulae version = Emacs.
I considered the order of conditions. Because = notifications and notify-send etc
requires dbus. So I = guess only Linux supports that. So add system-type detection
will be better. WDYT?

I think you can add dbus support to macOS using homebrew and = that might
resolve the issue. At the very least, this will = need to be investigated
because otherwise, adding this = patch may break configurations for users
who have added = dbus support via homebrew and have notifications working,
but have not installed the osx-lib package.

My only small concern with your proposed changes is that it = will add a
dependency on a new package osx-lib, which I = think is only available in
melpa. At the very least, this = will need to be documented somewhere.
However, I'm not = sure what the situation is wrt adding code which
depends = on an external package which is not available in either elpa or
nongnuELPA? As org mode is a part of GNU Emacs, I suspect = that any code
which 'encourages' the use of melpa packages = will not be acceptable.

--
Tim = Cross






= --Apple-Mail=_51CA6CB0-188C-41D5-8DD6-E401C3B561A4--