From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: defadvice in Emacs code (was: Kill ring leak in winemacs macros] Date: Fri, 05 Aug 2005 15:48:55 +0200 Message-ID: <42F36E47.4020308@student.lu.se> References: <34161.128.165.123.83.1123097221.squirrel@webmail.lanl.gov> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1123250446 12088 80.91.229.2 (5 Aug 2005 14:00:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 5 Aug 2005 14:00:46 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 05 16:00:44 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E12iL-0003d2-4s for ged-emacs-devel@m.gmane.org; Fri, 05 Aug 2005 15:58:21 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E12lC-0007x1-6v for ged-emacs-devel@m.gmane.org; Fri, 05 Aug 2005 10:01:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E12j1-0007VY-UQ for emacs-devel@gnu.org; Fri, 05 Aug 2005 09:59:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E12j1-0007VC-3J for emacs-devel@gnu.org; Fri, 05 Aug 2005 09:59:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E12j0-0007Op-5F for emacs-devel@gnu.org; Fri, 05 Aug 2005 09:59:02 -0400 Original-Received: from [81.228.11.159] (helo=pne-smtpout2-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E12mG-0000rv-7n; Fri, 05 Aug 2005 10:02:24 -0400 Original-Received: from [192.168.123.121] (83.249.202.93) by pne-smtpout2-sn1.fre.skanova.net (7.2.060.1) id 42B93717006CA32C; Fri, 5 Aug 2005 15:48:56 +0200 User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en Original-To: rms@gnu.org In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41537 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41537 Richard M. Stallman wrote: >These are all bugs that ought to be fixed. In general I did not know >they used defadvice when the code was installed. > > I looked at the help text for defadvice and followed the link to Info (a very useful link!). In the help text I found nothing about defadvice usage in Emacs. The text in Info says "This is a clean method for a library to customize functions defined within Emacs--cleaner than redefining the whole function". Maybe it should be pointed out somewhere that this should not be used within Emacs itself? Viper also has a lot of defadvice. It might be necessary in the case of viper, I do not know.