From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hunter Newsgroups: gmane.emacs.devel Subject: Re: Code inspection: W32 specific problems Date: Mon, 18 Jul 2005 21:02:45 -0400 Message-ID: <42DC5135.5050802@comcast.net> References: <42D94106.6010500@comcast.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1121737662 24350 80.91.229.2 (19 Jul 2005 01:47:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2005 01:47:42 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 19 03:47:40 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DuhCf-0000TY-Q1 for ged-emacs-devel@m.gmane.org; Tue, 19 Jul 2005 03:47:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DuhEd-0007kC-GL for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2005 21:49:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Duh8R-0005w3-2A for emacs-devel@gnu.org; Mon, 18 Jul 2005 21:43:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Duh8E-0005q0-Ol for emacs-devel@gnu.org; Mon, 18 Jul 2005 21:42:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Duh8B-0005eY-O0 for emacs-devel@gnu.org; Mon, 18 Jul 2005 21:42:48 -0400 Original-Received: from [216.148.227.85] (helo=rwcrmhc12.comcast.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dugec-0004Hr-3u; Mon, 18 Jul 2005 21:12:14 -0400 Original-Received: from [192.168.42.3] (pcp08774087pcs.mtlrel01.nj.comcast.net[68.36.32.221]) by comcast.net (rwcrmhc12) with ESMTP id <200507190102480140031d05e>; Tue, 19 Jul 2005 01:02:49 +0000 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax) X-Accept-Language: en-us, en Original-To: "Kim F. Storm" In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41058 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41058 Kim F. Storm wrote: >>Qw32_charset_default was declared in w32term.c rev 1.62 in early >>2000, but was not defined there either. It is potentially used by >>several codepaths, notably in enum_font_cb2(). The related symbol >>'w32-charset-default' also exists in documentation. It should be >>defined. > > What about its initial value? > Is it always set from lisp before first usage? Hmm, I think I might have used the wrong terms to describe the issue. My grip on eLisp is not yet that strong (and probably never will be :) ). Qw32_charset_default should just be a C pointer to a Lisp symbol whose name should be 'w32-charset-default'. Note that it is used only as a symbol and not evaulated as a variable; its value is void. It should simply be interned, so that the C variable Qw32_charset_default will be equivalent (by the EQ macro) to the Lisp symbol 'w32-charset-default'. For reference, examine the relationship between the C variable Qw32_charset_ansi and the Lisp symbol 'w32-charset-ansi', established at w32fns.c:8794. -Dave