Inserting "-*- mode: ..." before turning mode on in (compilation-start)

Inserting "-*- mode: ..." before turning mode on in (compilation-start)

[Markus Gritsch]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi,

It would be nice if the specified mode in (compilation-start) would get 
activated before inserting anything (i.e. the mode setter line) into the 
buffer.

In a function which I added to compilation-mode-hook I change some 
fontification things including the used font.  When (compilation-start) 
is called using compilation-mode as mode, my function gets called using 
(funcall mode).  However this happens a few lines too late, because the 
mode setter has already been inserted into the buffer, and so it is not 
displayed using my font (see attached screen shot).

Kind regards,
Markus


[-- Attachment #2: ScreenShot.png --]
[-- Type: image/png, Size: 19123 bytes --]

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Inserting "-*- mode: ..." before turning mode on in (compilation-start)

[Richard Stallman]

Does this patch give good results?

*** compile.el	20 May 2005 17:56:45 -0400	1.356
--- compile.el	28 May 2005 05:02:27 -0400	
***************
*** 935,946 ****
  		    (substitute-env-vars (match-string 1 command))
  		  "~")
  	      default-directory))
  	(erase-buffer)
! 	;; output a mode setter, for saving and later reloading this buffer
  	(insert "-*- mode: " name-of-mode
  		"; default-directory: " (prin1-to-string default-directory)
! 		" -*-\n" command "\n")
! 	(setq thisdir default-directory))
        (set-buffer-modified-p nil))
      ;; If we're already in the compilation buffer, go to the end
      ;; of the buffer, so point will track the compilation output.
--- 935,954 ----
  		    (substitute-env-vars (match-string 1 command))
  		  "~")
  	      default-directory))
+ 	;; Select the desired mode.
+ 	(if (not (eq mode t))
+ 	    (funcall mode)
+ 	  (setq buffer-read-only nil)
+ 	  (with-no-warnings (comint-mode))
+ 	  (compilation-shell-minor-mode))
+ 	(if highlight-regexp
+ 	    (set (make-local-variable 'compilation-highlight-regexp)
+ 		 highlight-regexp))
  	(erase-buffer)
! 	;; Output a mode setter, for saving and later reloading this buffer.
  	(insert "-*- mode: " name-of-mode
  		"; default-directory: " (prin1-to-string default-directory)
! 		" -*-\n" command "\n")	(setq thisdir default-directory))
        (set-buffer-modified-p nil))
      ;; If we're already in the compilation buffer, go to the end
      ;; of the buffer, so point will track the compilation output.
***************
*** 963,976 ****
  	      ;; don't override users' setting of $EMACS.
  	      (unless (getenv "EMACS") '("EMACS=t"))
  	      (copy-sequence process-environment))))
- 	(if (not (eq mode t))
- 	    (funcall mode)
- 	  (setq buffer-read-only nil)
- 	  (with-no-warnings (comint-mode))
- 	  (compilation-shell-minor-mode))
- 	(if highlight-regexp
- 	    (set (make-local-variable 'compilation-highlight-regexp)
- 		 highlight-regexp))
  	(set (make-local-variable 'compilation-arguments)
  	     (list command mode name-function highlight-regexp))
  	(set (make-local-variable 'revert-buffer-function)
--- 971,976 ----

Re: Inserting "-*- mode: ..." before turning mode on in (compilation-start)

[Markus Gritsch]

Richard Stallman wrote:
> Does this patch give good results?

Yes, it works perfectly now.

Thank you,
Markus

> *** compile.el	20 May 2005 17:56:45 -0400	1.356
> --- compile.el	28 May 2005 05:02:27 -0400	
> ***************
> *** 935,946 ****
>   		    (substitute-env-vars (match-string 1 command))
>   		  "~")
>   	      default-directory))
>   	(erase-buffer)
> ! 	;; output a mode setter, for saving and later reloading this buffer
>   	(insert "-*- mode: " name-of-mode
>   		"; default-directory: " (prin1-to-string default-directory)
> ! 		" -*-\n" command "\n")
> ! 	(setq thisdir default-directory))
>         (set-buffer-modified-p nil))
>       ;; If we're already in the compilation buffer, go to the end
>       ;; of the buffer, so point will track the compilation output.
> --- 935,954 ----
>   		    (substitute-env-vars (match-string 1 command))
>   		  "~")
>   	      default-directory))
> + 	;; Select the desired mode.
> + 	(if (not (eq mode t))
> + 	    (funcall mode)
> + 	  (setq buffer-read-only nil)
> + 	  (with-no-warnings (comint-mode))
> + 	  (compilation-shell-minor-mode))
> + 	(if highlight-regexp
> + 	    (set (make-local-variable 'compilation-highlight-regexp)
> + 		 highlight-regexp))
>   	(erase-buffer)
> ! 	;; Output a mode setter, for saving and later reloading this buffer.
>   	(insert "-*- mode: " name-of-mode
>   		"; default-directory: " (prin1-to-string default-directory)
> ! 		" -*-\n" command "\n")	(setq thisdir default-directory))
>         (set-buffer-modified-p nil))
>       ;; If we're already in the compilation buffer, go to the end
>       ;; of the buffer, so point will track the compilation output.
> ***************
> *** 963,976 ****
>   	      ;; don't override users' setting of $EMACS.
>   	      (unless (getenv "EMACS") '("EMACS=t"))
>   	      (copy-sequence process-environment))))
> - 	(if (not (eq mode t))
> - 	    (funcall mode)
> - 	  (setq buffer-read-only nil)
> - 	  (with-no-warnings (comint-mode))
> - 	  (compilation-shell-minor-mode))
> - 	(if highlight-regexp
> - 	    (set (make-local-variable 'compilation-highlight-regexp)
> - 		 highlight-regexp))
>   	(set (make-local-variable 'compilation-arguments)
>   	     (list command mode name-function highlight-regexp))
>   	(set (make-local-variable 'revert-buffer-function)
> --- 971,976 ----