From: Dmitry Gutov <dmitry@gutov.dev>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: sbaugh@catern.com, 69584@debbugs.gnu.org
Subject: bug#69584: 29.2.50; project-find-functions should have access to maybe-prompt
Date: Fri, 5 Apr 2024 03:33:49 +0300 [thread overview]
Message-ID: <428f4138-1dfa-4d10-8fe6-c957ff28046c@gutov.dev> (raw)
In-Reply-To: <ier8r1turoj.fsf@janestreet.com>
On 04/04/2024 17:29, Spencer Baugh wrote:
> Dmitry Gutov<dmitry@gutov.dev> writes:
>> On 22/03/2024 15:05, Spencer Baugh wrote:
>>>> If this change will be enough to cover your scenario, let's go ahead
>>>> and add the 'non-essential' binding. It does seem to make sense for
>>>> Tramp, at least.
>>> Yes, that completely covers my scenario. (Putting aside whether my
>>> scenario is a good idea 🙂 )
>>> So I would be happy with that.
>> Now pushed to master as commit 1552f8345d8.
> Ah, I think this is not quite right, should be:
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index 1da03c7b60e..3cd6dafb409 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -229,8 +229,8 @@ project-current
> of the project instance object."
> (unless directory (setq directory (or project-current-directory-override
> default-directory)))
> - (let ((pr (project--find-in-directory directory))
> - (non-essential (not maybe-prompt)))
> + (let* ((non-essential (not maybe-prompt))
> + (pr (project--find-in-directory directory)))
> (cond
> (pr)
> ((unless project-current-directory-override
Right! Thanks for the correction (21f9be00531 in master).
next prev parent reply other threads:[~2024-04-05 0:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:23 bug#69584: 29.2.50; project-find-functions should have access to maybe-prompt Spencer Baugh
2024-03-15 1:41 ` Dmitry Gutov
2024-03-16 13:31 ` sbaugh
2024-03-18 21:59 ` Dmitry Gutov
2024-03-22 13:05 ` Spencer Baugh
2024-03-28 3:44 ` Dmitry Gutov
2024-04-04 14:29 ` Spencer Baugh
2024-04-05 0:33 ` Dmitry Gutov [this message]
2024-04-02 17:54 ` Spencer Baugh
2024-04-02 23:10 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428f4138-1dfa-4d10-8fe6-c957ff28046c@gutov.dev \
--to=dmitry@gutov.dev \
--cc=69584@debbugs.gnu.org \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.