all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'John Yates'" <john@yates-sheets.org>
Cc: 'Masatake YAMATO' <yamato@redhat.com>, emacs-devel@gnu.org
Subject: RE: [patch] minor patch for register.el
Date: Wed, 20 Feb 2013 07:27:18 -0800	[thread overview]
Message-ID: <4279D539FD71421584E199995F074E83@us.oracle.com> (raw)
In-Reply-To: <CAJnXXojaUapm6ng3eMQ5wo8snKgGMbLVQKnBx=RXONOGm1OgbQ@mail.gmail.com>

> > Personally, I don't really care one way or the other - (a) 
> > show a message and do nothing or (b) raise an error.
> 
> Raising an error would be tantamount to suggesting that it is user's
> responsibility to _know_ a priori that the set is empty and to avoid
> invoking the function.  Encountering a normal boundary state is not an
> error.
> 
> I run with debug-on-error set.  Raising errors for non-error
> conditions is very distracting.

Again, I don't care which we do here: message or error.  But if you are worried
about an error then you'd better look throughout register.el at the other
commands.  They pretty much all already raise errors for similar situations -
see the cl assertions.

Feel free to change the error raising in the patch to `message' calls, as far as
I am concerned.  Or use `user-error', as Christopher suggests.

The point, for me, is not to open an empty window/frame here: display a message
instead.




  parent reply	other threads:[~2013-02-20 15:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 23:18 [patch] minor patch for register.el Drew Adams
2013-02-20  2:18 ` Masatake YAMATO
2013-02-20  4:30   ` Drew Adams
2013-02-20 14:48     ` John Yates
2013-02-20 14:53       ` Christopher Schmidt
2013-02-20 15:27       ` Drew Adams [this message]
2013-02-20 17:05 ` Stefan Monnier
2013-02-20 23:15   ` Drew Adams
2013-03-11 18:01     ` Stefan Monnier
2013-03-11 20:46       ` Drew Adams
2013-02-21 20:29 ` Bastien
2013-02-21 21:20   ` Drew Adams
2013-02-21 21:25     ` Bastien
2013-02-21 21:29       ` Drew Adams
2013-02-21 21:34         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4279D539FD71421584E199995F074E83@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=john@yates-sheets.org \
    --cc=yamato@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.