From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hunter Newsgroups: gmane.emacs.devel Subject: Re: HAVE_PWD_H Date: Thu, 21 Apr 2005 22:43:57 -0400 Message-ID: <426864ED.7050806@comcast.net> References: <4eb0089f05042106024fea61b5@mail.gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1114137836 12778 80.91.229.2 (22 Apr 2005 02:43:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 22 Apr 2005 02:43:56 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 22 04:43:54 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DOo8v-0006jf-JJ for ged-emacs-devel@m.gmane.org; Fri, 22 Apr 2005 04:43:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DOoDl-0007hq-7F for ged-emacs-devel@m.gmane.org; Thu, 21 Apr 2005 22:48:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DOoCs-0007VV-0Z for emacs-devel@gnu.org; Thu, 21 Apr 2005 22:47:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DOoCm-0007UD-Lx for emacs-devel@gnu.org; Thu, 21 Apr 2005 22:47:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DOoCm-0007U9-IT for emacs-devel@gnu.org; Thu, 21 Apr 2005 22:47:44 -0400 Original-Received: from [204.127.198.39] (helo=rwcrmhc13.comcast.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DOoBc-0002g1-0e for emacs-devel@gnu.org; Thu, 21 Apr 2005 22:46:32 -0400 Original-Received: from [192.168.42.3] (pcp08774087pcs.mtlrel01.nj.comcast.net[68.36.32.221]) by comcast.net (rwcrmhc13) with ESMTP id <20050422024401015004e3l4e>; Fri, 22 Apr 2005 02:44:02 +0000 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax) X-Accept-Language: en-us, en Original-To: David Robinow In-Reply-To: <4eb0089f05042106024fea61b5@mail.gmail.com> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36262 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36262 David Robinow wrote: > Recent changes to fileio.c, editfns.c, etc. have broken the MS Windows > build. Although nt/inc/pwd.h exists, configure.bat does not detect > it. > HAVE_PWD_H, of course, can be unconditionally defined but I'm not > sure exactly where to do it so I'm not including a patch. > However, conditionalizing the #include doesn't seem right > to me, unless the use of "struct passwd" is also conditionalized. As > it is now, if pwd.h is not included, the code won't compile. HAVE_*_H are #defined in ms-w32.h (and #undefined in config.nt for good karma). This patch fixes the build. -Dave Index: nt/config.nt =================================================================== RCS file: /cvsroot/emacs/emacs/nt/config.nt,v retrieving revision 1.19 diff -u -r1.19 config.nt --- nt/config.nt 1 Sep 2003 15:45:46 -0000 1.19 +++ nt/config.nt 22 Apr 2005 02:11:04 -0000 @@ -139,6 +139,7 @@ #undef HAVE_TERMIOS_H #undef HAVE_LIMITS_H #undef HAVE_STRING_H +#undef HAVE_PWD_H #undef STDC_HEADERS #undef TIME_WITH_SYS_TIME Index: src/s/ms-w32.h =================================================================== RCS file: /cvsroot/emacs/emacs/src/s/ms-w32.h,v retrieving revision 1.31 diff -u -r1.31 ms-w32.h --- src/s/ms-w32.h 15 Feb 2005 23:14:05 -0000 1.31 +++ src/s/ms-w32.h 22 Apr 2005 02:14:16 -0000 @@ -230,6 +230,7 @@ #undef HAVE_TERMIOS_H #define HAVE_LIMITS_H 1 #define HAVE_STRING_H 1 +#define HAVE_PWD_H 1 #define STDC_HEADERS 1 #define TIME_WITH_SYS_TIME 1