all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: 54486@debbugs.gnu.org
Subject: bug#54486: 29.0.50; Eshell `escaped' string property can "leak" into output
Date: Sun, 20 Mar 2022 20:52:43 -0700	[thread overview]
Message-ID: <4246ce24-e48e-4bdf-4918-412bf6c0e595@gmail.com> (raw)

When using Eshell, it's possible to inadvertently add an `escaped' 
string property to strings, resulting in some pretty surprising 
behavior. Starting from "emacs -Q --eval '(eshell)'":

   ~ $ setq var (list "foo" "bar")
   ("foo" "bar")
   ~ $ echo $var
   ("foo" "bar")
   ~ $ echo $var[0]
   foo
   ~ $ echo $var
   (#("foo" 0 3
      (escaped t))
    "bar")

This happens because when the `$var[0]' argument is parsed in the third 
command, the function `eshell-interpolate-variable' wraps the 
code-to-be-called with `eshell-escape-arg'. That function adds an 
`escaped' property to any string passed into it.

The `escaped' property is used to indicate that the string should be 
treated literally (i.e. any special characters like "$" will no longer 
have any special meaning in Eshell). That's the right *behavior*, but 
ideally, there'd be a way to do so that doesn't involve manipulating the 
string like this. Eshell can't know the lifetime of the string, and it 
seems like a bad idea in general to go around messing with string 
properties just because you referenced that string somehow in Eshell.

I can't think of an obvious fix for this though. Any ideas?





             reply	other threads:[~2022-03-21  3:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21  3:52 Jim Porter [this message]
2022-03-21  4:04 ` bug#54486: 29.0.50; Eshell `escaped' string property can "leak" into output Jim Porter
2022-03-21 12:19 ` Eli Zaretskii
2022-03-21 19:24   ` Jim Porter
2022-03-21 20:00     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4246ce24-e48e-4bdf-4918-412bf6c0e595@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=54486@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.