From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Newsgroups: gmane.emacs.bugs Subject: bug#34764: prettify-symbols-mode pollutes font-lock-extra-keywords Date: Tue, 5 Mar 2019 17:15:03 -0500 Message-ID: <42355266-99e2-403a-8dd2-8a5320659d1b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180882"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 To: 34764@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 05 23:16:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1IMN-000kw7-SO for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 23:16:28 +0100 Original-Received: from localhost ([127.0.0.1]:49952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1IMM-0008VC-OK for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 17:16:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1IMC-0008Tw-RG for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 17:16:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1IM7-0008Tl-VS for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 17:16:14 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1ILy-0008Pj-PH for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 17:16:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1ILy-0003Px-Kp for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 17:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Mar 2019 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34764 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.155182413013080 (code B ref -1); Tue, 05 Mar 2019 22:16:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Mar 2019 22:15:30 +0000 Original-Received: from localhost ([127.0.0.1]:33560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1ILR-0003Ou-Q7 for submit@debbugs.gnu.org; Tue, 05 Mar 2019 17:15:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1ILP-0003Oh-N1 for submit@debbugs.gnu.org; Tue, 05 Mar 2019 17:15:28 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1ILH-0007Wr-6I for submit@debbugs.gnu.org; Tue, 05 Mar 2019 17:15:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1ILG-0007ws-9V for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 17:15:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1ILA-0007TD-3o for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 17:15:15 -0500 Original-Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:43148) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1IL4-0007QJ-Of for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 17:15:08 -0500 Original-Received: by mail-qt1-x835.google.com with SMTP id y4so10686554qtc.10 for ; Tue, 05 Mar 2019 14:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=GIwuXZmUQsaDBCJyDKVAXap/CKcMOU1OVKziItbPsWk=; b=TrId3RKQgIOpsfS8mjV8znI15MRdNZPtzobbQ6BmFR3RZwk2OzorVIO3gNCV1g/ouh ssvYBo4P3srLW16i+IzYO94I47Bi308P27mVIFnZYAaa9hG1Jq2bCD2lF+KVhSoeYyqd 5udtVQBUxFJhjPn/Nvu3BZKC5vXF5q4+l27rIrQElxqmReRvmY0EgH0Yipw/KQx4FaJB +kAz1D6JWo4tBwWnbaNOC+Kg2FmJrmi+O/nwq4hxQnxdtBaiudJyHWGGE5ArEnFqtEYo f+Umn28n0MVJ4DVeUc9f824+k8Zlodnt7ZPymVBS8YwKTKAwtnepd3QyMl8bqx504sMn WwzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=GIwuXZmUQsaDBCJyDKVAXap/CKcMOU1OVKziItbPsWk=; b=MzMDcbwgfsjRT2a6tPZAbVJEjikEaz7DuE4HH96HSeJcYcUx5Yua5AVR71BUtBxXhB wiPxPtW+DkiYxOsKOixqU2qcT6I5r1777UkAmc1AeE2qNR6jMVgFErNji0SImSQLavoG TX9LGrAB9NVeinmTubcO5arAK2ia2+UAKIB+iok9h7U3srSIiBEHy70J0wCJRZHupHah ay1BnyUgTRjAWUygkmi+8QBrROFpdAeQUbpl6L4kOuf9nhLWi15uAHeeSxiiRNsQ5vf/ eyl/719PSoBYWOlfh7JGpemoEiEvwqaWXFy5pksCmpF5MbBvS652l1aZsyJsYAxVFOAx iMRw== X-Gm-Message-State: APjAAAVjt4UhHMOJawVLS39ekKe06vuOr18X+/scgD2NwDYBgUn/qOmA lvSof7/BsD+s+FMfkuHssyzSbWTg X-Google-Smtp-Source: APXvYqz+fURPO0+Gdi+cvSdvmVL+VSNpJlBc3a+QgfqVperJBLfvSHqnfabHaz4wYwIGKB1dSOan9g== X-Received: by 2002:aed:23c8:: with SMTP id k8mr3247317qtc.101.1551824104581; Tue, 05 Mar 2019 14:15:04 -0800 (PST) Original-Received: from [128.30.10.34] (30-10-34.wireless.csail.mit.edu. [128.30.10.34]) by smtp.googlemail.com with ESMTPSA id p15sm7084310qta.81.2019.03.05.14.15.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 14:15:04 -0800 (PST) Content-Language: en-GB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156076 Archived-At: Hi all, When turned off, prettify-symbols-mode removes 'composition' from font-lock-extra-keywords, but not prettify-symbols-start or prettify-symbols-end; as a result, every time prettify-symbols-mode is turned on, it adds two new elements to font-lock-extra-keywords. (I ran into this issue because I added a watcher on font-lock-extra-keywords to debug an intermittent font-lock problem, and the increasingly long lists of prettify-symbol-* entries made things harder to read). I'm happy to provide a patch, but I'm a bit puzzled by the implementation: (remove-hook 'post-command-hook #'prettify-symbols--post-command-hook t) (when prettify-symbols--keywords (font-lock-remove-keywords nil prettify-symbols--keywords) (setq prettify-symbols--keywords nil)) (when (memq 'composition font-lock-extra-managed-props) (setq font-lock-extra-managed-props (delq 'composition font-lock-extra-managed-props)) (with-silent-modifications (remove-text-properties (point-min) (point-max) '(composition nil)))))) Would it be simpler to just call font-lock-unfontify-region-function and remove all three properties from font-lock-extra-managed-props? Cheers, Clément. In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2019-02-28 built on clem-w50-mint Repository revision: 5d60229bf1a9a496102fc2a3ef9e57dcce7bef10 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Linux Mint 19.1