bug#13600: Bug in cycle-spacing (simple.el)

bug#13600: Bug in cycle-spacing (simple.el)

[Nick Dokos]

The new command ``cycle-spacing'' which is used by just-one-space
is buggy. Evaluating the following form in *scratch* illustrates
the problem:

(cycle-spacing 1 nil t)
\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01nil

(cycle-spacing 1 nil t)

The git commit in question is

,----
| commit 426db07fbc01417362044cac4e6539264a8b7768
| Author: Michal Nazarewicz <mina86@mina86.com>
| Date:   Wed Jan 30 21:57:35 2013 -0500
| 
|     * lisp/simple.el (cycle-spacing): New command.
|     (just-one-space): Use it.
`----

and the suspect line is l.808 in simple.el:

    (insert (make-string ?\s n))

which should be

    (insert (make-string n ?\s))

instead (iiuc).

Thanks,
Nick