all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, 11890@debbugs.gnu.org
Subject: bug#11890: 24.1; (wrong-type-argument processp nil) in `shell-mode'
Date: Thu, 28 Apr 2016 09:10:14 -0700 (PDT)	[thread overview]
Message-ID: <42210bb6-aac5-4853-8813-51e689996892@default> (raw)
In-Reply-To: <87fuu5afz4.fsf@gnus.org>

> > If `shell-mode' is a command that is intended only for certain contexts
> > then it should control/manage that.  It should issue a proper error
> > message when the context is inappropriate.  It should not simply barf
> > with a wrong-type arg error.
> 
> Do you have a recipe from -Q?  From the backtrace included, it kinda
> looked like the bug was triggered from your own code.

No, and it should not matter.  The command should not just barf with
a wrong-type error msg.

As the bug report says:

  Clearly, this code in shell.el is not tolerant of there being no process:
 
  (file-name-nondirectory
   (car (process-command (get-buffer-process (current-buffer)))))
 
  I imagine that it should be, or rather that it should perhaps raise an
  error with a more suitable message.





  reply	other threads:[~2016-04-28 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 15:36 bug#11890: 24.1; (wrong-type-argument processp nil) in `shell-mode' Drew Adams
2012-07-09 15:52 ` Andreas Schwab
2012-07-09 16:04   ` Drew Adams
2012-09-16 23:41     ` Drew Adams
2016-04-28 15:51     ` Lars Ingebrigtsen
2016-04-28 16:10       ` Drew Adams [this message]
2016-04-28 16:13         ` Lars Ingebrigtsen
2016-04-28 16:16           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42210bb6-aac5-4853-8813-51e689996892@default \
    --to=drew.adams@oracle.com \
    --cc=11890@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.