From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#19680: 24.4; option --no-bitmap-icon not working Date: Thu, 05 Mar 2015 16:05:19 -0500 Message-ID: <41vbifyx2o.fsf@fencepost.gnu.org> References: <54C42121.7080602@crowcastle.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1425589581 3271 80.91.229.3 (5 Mar 2015 21:06:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Mar 2015 21:06:21 +0000 (UTC) Cc: Dmitry Antipov , 19680@debbugs.gnu.org To: Preston Crow Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 05 22:06:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YTcyA-00063S-Qx for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Mar 2015 22:06:10 +0100 Original-Received: from localhost ([::1]:54957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTcyA-0005s8-9X for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Mar 2015 16:06:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTcy3-0005ha-C0 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2015 16:06:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTcy2-0008CQ-M4 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2015 16:06:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTcy2-0008CD-Ja for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2015 16:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YTcy2-0006LG-B4 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2015 16:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2015 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19680 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19680-submit@debbugs.gnu.org id=B19680.142558952424307 (code B ref 19680); Thu, 05 Mar 2015 21:06:02 +0000 Original-Received: (at 19680) by debbugs.gnu.org; 5 Mar 2015 21:05:24 +0000 Original-Received: from localhost ([127.0.0.1]:36468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTcxP-0006Jz-Tn for submit@debbugs.gnu.org; Thu, 05 Mar 2015 16:05:24 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:43552 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTcxO-0006Jp-4W for 19680@debbugs.gnu.org; Thu, 05 Mar 2015 16:05:22 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YTcxL-0000Yk-Uz; Thu, 05 Mar 2015 16:05:20 -0500 X-Spook: nuclear credit card [Hello to all my friends and fans in X-Ran: Wf3M&~b:"0Vl#$W1+{7X(h/~/-]Y"<8gE^.wn~d00Y6Mpp6L<7C_p1^J\[9*q5Rbl9*CWQ X-Hue: blue X-Attribution: GM In-Reply-To: <54C42121.7080602@crowcastle.net> (Preston Crow's message of "Sat, 24 Jan 2015 17:48:01 -0500") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100110 Archived-At: Preston Crow wrote: > The command-line option "--no-bitmap-icon" used to turn off the bitmap > icon, but after upgrading to the latest version, this option appears to > be ignored. > > In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.6) I suspect the 2013-09-17 changes to x_iconify_frame etc. The following lightly tested patch seemed to fix it for me. Since this is a new, seemingly simple problem in 24.4 it might be good to fix it for 24.5; ie quickly in emacs-24. --- a/src/frame.h +++ b/src/frame.h @@ -1349,7 +1349,7 @@ x_set_bitmap_icon (struct frame *f) { Lisp_Object obj = assq_no_quit (Qicon_type, f->param_alist); - if (CONSP (obj)) + if (CONSP (obj) && !NILP (XCDR (obj))) x_bitmap_icon (f, XCDR (obj)); }