all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Preston Crow <frompreston2002315lt@crowcastle.net>
Cc: Dmitry Antipov <dmantipov@yandex.ru>, 19680@debbugs.gnu.org
Subject: bug#19680: 24.4; option --no-bitmap-icon not working
Date: Thu, 05 Mar 2015 16:05:19 -0500	[thread overview]
Message-ID: <41vbifyx2o.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <54C42121.7080602@crowcastle.net> (Preston Crow's message of "Sat, 24 Jan 2015 17:48:01 -0500")

Preston Crow wrote:

> The command-line option "--no-bitmap-icon" used to turn off the bitmap
> icon, but after upgrading to the latest version, this option appears to
> be ignored.
>
> In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.6)

I suspect the 2013-09-17 changes to x_iconify_frame etc.
The following lightly tested patch seemed to fix it for me.
Since this is a new, seemingly simple problem in 24.4 it might be good
to fix it for 24.5; ie quickly in emacs-24.

--- a/src/frame.h
+++ b/src/frame.h
@@ -1349,7 +1349,7 @@ x_set_bitmap_icon (struct frame *f)
 {
   Lisp_Object obj = assq_no_quit (Qicon_type, f->param_alist);
 
-  if (CONSP (obj))
+  if (CONSP (obj) && !NILP (XCDR (obj)))
     x_bitmap_icon (f, XCDR (obj));
 }
 






  reply	other threads:[~2015-03-05 21:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24 22:48 bug#19680: 24.4; option --no-bitmap-icon not working Preston Crow
2015-03-05 21:05 ` Glenn Morris [this message]
2015-03-06 14:40   ` Stefan Monnier
2015-03-12 16:03   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41vbifyx2o.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=19680@debbugs.gnu.org \
    --cc=dmantipov@yandex.ru \
    --cc=frompreston2002315lt@crowcastle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.