bug#3474: 23.0.94; Emacs.app crashes during typing (with patch)

bug#3474: 23.0.94; Emacs.app crashes during typing (with patch)

[Wolfgang Lux]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org  
mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I've encountered a few crashes in Emacs.app, which happened while  
typing when Emacs was a bit busy. It turns out that these crashes  
were due to an omitted null-pointer check at line 4165 of keyboard.c  
in function kbd_buffer_get_event(). The attached patch fixes this  
problem along with a second omitted null-pointer check in line 4323  
of the same function.

Wolfgang



[-- Attachment #2: keyboard.patch --]
[-- Type: application/octet-stream, Size: 604 bytes --]

--- src/keyboard.c.~1.1005.~	2009-05-28 17:08:04.000000000 +0200
+++ src/keyboard.c	2009-06-02 13:39:39.000000000 +0200
@@ -4162,7 +4162,8 @@
           else
             obj = Fcons (intern ("ns-unput-working-text"), Qnil);
 	  kbd_fetch_ptr = event + 1;
-	  *used_mouse_menu = 1;
+	  if (used_mouse_menu)
+	    *used_mouse_menu = 1;
         }
 #endif
 
@@ -4319,7 +4320,8 @@
 #endif
 #ifdef HAVE_NS
 	      /* certain system events are non-key events */
-	      if (event->kind == NS_NONKEY_EVENT)
+	      if (used_mouse_menu
+		  && event->kind == NS_NONKEY_EVENT)
 		*used_mouse_menu = 1;
 #endif
 

bug#3474: 23.0.94; Emacs.app crashes during typing (with patch)

[Chong Yidong]

Adrian, could you review this patch?


Wolfgang Lux <wolfgang.lux@gmail.com> wrote:

> I've encountered a few crashes in Emacs.app, which happened while  
> typing when Emacs was a bit busy. It turns out that these crashes  
> were due to an omitted null-pointer check at line 4165 of keyboard.c  
> in function kbd_buffer_get_event(). The attached patch fixes this  
> problem along with a second omitted null-pointer check in line 4323  
> of the same function.

--- src/keyboard.c.~1.1005.~	2009-05-28 17:08:04.000000000 +0200
+++ src/keyboard.c	2009-06-02 13:39:39.000000000 +0200
@@ -4162,7 +4162,8 @@
           else
             obj = Fcons (intern ("ns-unput-working-text"), Qnil);
 	  kbd_fetch_ptr = event + 1;
-	  *used_mouse_menu = 1;
+	  if (used_mouse_menu)
+	    *used_mouse_menu = 1;
         }
 #endif
 
@@ -4319,7 +4320,8 @@
 #endif
 #ifdef HAVE_NS
 	      /* certain system events are non-key events */
-	      if (event->kind == NS_NONKEY_EVENT)
+	      if (used_mouse_menu
+		  && event->kind == NS_NONKEY_EVENT)
 		*used_mouse_menu = 1;
 #endif
 

bug#3474: 23.0.94; Emacs.app crashes during typing (with patch)

[Adrian Robert]

On Jun 8, 2009, at 4:49 AM, Chong Yidong wrote:

> Adrian, could you review this patch?

It looks OK to me, I'm checking it in.  Other parts of that function  
do similar null checks and don't behave specially if they can't set it.

-Adrian




>
>
> Wolfgang Lux <wolfgang.lux@gmail.com> wrote:
>
>> I've encountered a few crashes in Emacs.app, which happened while
>> typing when Emacs was a bit busy. It turns out that these crashes
>> were due to an omitted null-pointer check at line 4165 of keyboard.c
>> in function kbd_buffer_get_event(). The attached patch fixes this
>> problem along with a second omitted null-pointer check in line 4323
>> of the same function.
>
> --- src/keyboard.c.~1.1005.~	2009-05-28 17:08:04.000000000 +0200
> +++ src/keyboard.c	2009-06-02 13:39:39.000000000 +0200
> @@ -4162,7 +4162,8 @@
>            else
>              obj = Fcons (intern ("ns-unput-working-text"), Qnil);
>  	  kbd_fetch_ptr = event + 1;
> -	  *used_mouse_menu = 1;
> +	  if (used_mouse_menu)
> +	    *used_mouse_menu = 1;
>          }
>  #endif
>
> @@ -4319,7 +4320,8 @@
>  #endif
>  #ifdef HAVE_NS
>  	      /* certain system events are non-key events */
> -	      if (event->kind == NS_NONKEY_EVENT)
> +	      if (used_mouse_menu
> +		  && event->kind == NS_NONKEY_EVENT)
>  		*used_mouse_menu = 1;
>  #endif
>

bug#3474: marked as done (23.0.94; Emacs.app crashes during typing (with patch))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]


Your message dated Mon, 08 Jun 2009 10:52:51 -0400
with message-id <87d49eaibg.fsf@cyd.mit.edu>
and subject line Re: 23.0.94; Emacs.app crashes during typing (with patch)
has caused the Emacs bug report #3474,
regarding 23.0.94; Emacs.app crashes during typing (with patch)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3474: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3474
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4779 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 688 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org  
mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I've encountered a few crashes in Emacs.app, which happened while  
typing when Emacs was a bit busy. It turns out that these crashes  
were due to an omitted null-pointer check at line 4165 of keyboard.c  
in function kbd_buffer_get_event(). The attached patch fixes this  
problem along with a second omitted null-pointer check in line 4323  
of the same function.

Wolfgang



[-- Attachment #2.1.2: keyboard.patch --]
[-- Type: application/octet-stream, Size: 604 bytes --]

--- src/keyboard.c.~1.1005.~	2009-05-28 17:08:04.000000000 +0200
+++ src/keyboard.c	2009-06-02 13:39:39.000000000 +0200
@@ -4162,7 +4162,8 @@
           else
             obj = Fcons (intern ("ns-unput-working-text"), Qnil);
 	  kbd_fetch_ptr = event + 1;
-	  *used_mouse_menu = 1;
+	  if (used_mouse_menu)
+	    *used_mouse_menu = 1;
         }
 #endif
 
@@ -4319,7 +4320,8 @@
 #endif
 #ifdef HAVE_NS
 	      /* certain system events are non-key events */
-	      if (event->kind == NS_NONKEY_EVENT)
+	      if (used_mouse_menu
+		  && event->kind == NS_NONKEY_EVENT)
 		*used_mouse_menu = 1;
 #endif
 

[-- Attachment #3: Type: message/rfc822, Size: 1614 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: 3474-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.94; Emacs.app crashes during typing (with patch)
Date: Mon, 08 Jun 2009 10:52:51 -0400
Message-ID: <87d49eaibg.fsf@cyd.mit.edu>

Adrian Robert <adrian.b.robert@gmail.com> writes:

>> Adrian, could you review this patch?
>
> It looks OK to me, I'm checking it in.  Other parts of that function
> do similar null checks and don't behave specially if they can't set
> it.

Thanks.