From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#3207: 23.0.93; x-display-planes is incorrect in NS port Date: Sun, 10 May 2009 18:11:53 -0400 Message-ID: <41408556-4627-42E1-99F8-9AB9E4B0F22D@gmail.com> References: <87ws8oeibf.fsf@cyd.mit.edu> Reply-To: David Reitter , 3207@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: multipart/signed; boundary=Apple-Mail-48--454175228; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1241994757 29301 80.91.229.12 (10 May 2009 22:32:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 May 2009 22:32:37 +0000 (UTC) Cc: Ian Eure , Adrian Robert , 3207@emacsbugs.donarmstrong.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 11 00:32:26 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M3HZK-0007H1-2N for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 May 2009 00:32:26 +0200 Original-Received: from localhost ([127.0.0.1]:53494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M3HZJ-0007zr-DZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 May 2009 18:32:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M3HYz-0007lK-DP for bug-gnu-emacs@gnu.org; Sun, 10 May 2009 18:32:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M3HYu-0007kQ-HT for bug-gnu-emacs@gnu.org; Sun, 10 May 2009 18:32:04 -0400 Original-Received: from [199.232.76.173] (port=49530 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M3HYu-0007k3-8T for bug-gnu-emacs@gnu.org; Sun, 10 May 2009 18:32:00 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:59528) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M3HYt-0004Ie-14 for bug-gnu-emacs@gnu.org; Sun, 10 May 2009 18:31:59 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4AMVsaG021965; Sun, 10 May 2009 15:31:55 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4AMF3kK016743; Sun, 10 May 2009 15:15:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: David Reitter Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 10 May 2009 22:15:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3207 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3207-submit@emacsbugs.donarmstrong.com id=B3207.124199353016548 (code B ref 3207); Sun, 10 May 2009 22:15:03 +0000 Original-Received: (at 3207) by emacsbugs.donarmstrong.com; 10 May 2009 22:12:10 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-fx0-f160.google.com (mail-fx0-f160.google.com [209.85.220.160]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4AMC33l016524 for <3207@emacsbugs.donarmstrong.com>; Sun, 10 May 2009 15:12:05 -0700 Original-Received: by fxm4 with SMTP id 4so2735918fxm.1 for <3207@emacsbugs.donarmstrong.com>; Sun, 10 May 2009 15:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=SsxMwvM0ZMNVXXYCcOcsrlHZ2IaNOvkH8Uqy2WumXrs=; b=Drq1wAaS7cUK86Z/8n1excqqz0wBuoQus+OuU5UzcRHXBnlchGKp2AFD2boObImlUj TJkU1cKge9KlYw8BsMgYFp/8nzKdSdePmhonLP4vPiALGrAScbVAdXBj66rLtLx7hc4f c8rRojHbqT0l6DpBJ/S1uxJmAqkEpwJDf4W0M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=LlO4W8vJOsUw9xQWNEjoocVetJjoGeTWuR3MlP6R6hq30aVXYhtSjwsk4ZisxWukhP GxEilOqvrOi7EJ/sR45VwN3u5ktYW2vGtoZYTTpsn1YocRnovdrYlmB1lUTj4apX3OEq N0rRlY2f4m1om4bTlSbHty/PJmJmTB0gyYdqI= Original-Received: by 10.204.118.207 with SMTP id w15mr6133027bkq.97.1241993517921; Sun, 10 May 2009 15:11:57 -0700 (PDT) Original-Received: from ?192.168.1.42? (pool-71-162-19-47.pitbpa.east.verizon.net [71.162.19.47]) by mx.google.com with ESMTPS id k29sm6629445fkk.11.2009.05.10.15.11.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 10 May 2009 15:11:56 -0700 (PDT) In-Reply-To: <87ws8oeibf.fsf@cyd.mit.edu> X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 10 May 2009 18:32:04 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27810 Archived-At: --Apple-Mail-48--454175228 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable On May 10, 2009, at 5:53 PM, Chong Yidong wrote: > Adrian, could you take a look at this bug? Can you reproduce it? > > > Ian Eure wrote: > >> When starting up NextStep Emacs compiled from CVS HEAD, the old XPM >> splash image is used, rather than the new PNG. >> >> This appears to be caused by (display-planes) reporting an eight-=20 >> plane >> display. This is almost certainly incorrect. >> >> Looking deeper, (display-planes) calls (x-display-planes), in =20 >> nsfns.m. >> I don=92t see anything obviously wrong, but it=92s reporting that I = have >> an 8-plane display when it=92s 24-plane. Evaluating (x-display-color- >> cells) produces the correct value: 16777216, indicating a 24-bit >> display. Yeah, the x-display-planes implementation in nsfns.m should use =20 NSBitsPerPixelFromDepth. It reports 8 because this is 8 bits per color, and we have three =20 colors. Hence 24bit color depth. - David diff --git a/src/nsfns.m b/src/nsfns.m index a6fb7f1..8b5c330 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -2486,7 +2486,7 @@ If omitted or nil, that stands for the selected =20= frame's display. */) { check_ns (); return make_number - (NSBitsPerSampleFromDepth ([ns_get_screen (display) depth])); + (NSBitsPerPixelFromDepth ([ns_get_screen (display) depth])); } --Apple-Mail-48--454175228 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICED6shx13jEDrq0eL8FRq5ykwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTAyMDgwMVoXDTA5MTIwOTAyMDgw MVowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDOdo6kAwlkBxUb8dj4saMbYg4SVng8CUePFn3cjjWrakBTbUVa4Z0n wlUxr7AitEeKhBy5nGhu96+jKUPrCwYNRCZ0l2ovvuGq4z1m1nZ5/c8WvFlVhieuxXMUfmb/O7D3 IojoX6iS8n5MNNU2IWNNT/AD3vOl6DKgOtOw4J9y+QIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAIjI8yEW wkiEfA9PMgpjnD6KyCXT0iZjHhW2PkR53yZZLUoTboHnKgsFwYp/gzzIL8J5cvZaRUyMUzXDufPP dRmxxCs2jXXLDD/8bvdvOuMzqgYoFA73fAfsC8S6qUL1PayZ90J8CZHNhDwqWqOA56T+DdKUegJT sqoHKh6OnypTMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA+rIcdd4xA66tH i/BUaucpMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA5MDUxMDIyMTE1M1owIwYJKoZIhvcNAQkEMRYEFL20NWQPj/ojFMrO9gjrso7sF4f3 MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQPqyHHXeMQOurR4vwVGrnKTCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQPqyHHXeMQOurR4vwVGrnKTANBgkqhkiG9w0B AQEFAASBgGVqtXgQK7wq2a3ggwH9RbvE8jAycLUQJoA5lJdZdmWPx8VC9pZKn8wMibzXeB4HC0SL wrXpMN14RkT6jdCYzDYitCFRpNsZ9Aj3H2Hymg9cYx7gk4X8JLkp6ww20UlDKjzUAGJGrhT5CRkq zj3EJcLVFU6wGgEdKYls5U84EcgCAAAAAAAA --Apple-Mail-48--454175228--