From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35737: xref--original-command Date: Tue, 28 May 2019 00:13:34 +0300 Message-ID: <413fa232-ea7f-bd6a-ecce-632962a7f57e@yandex.ru> References: <87ftpgu59l.fsf@mail.linkov.net> <56943df5-f366-a8af-cb95-a40c244da837@yandex.ru> <87tvdvpgzj.fsf@mail.linkov.net> <87woiqkwok.fsf@mail.linkov.net> <87r28nenzk.fsf@mail.linkov.net> <8736kzekie.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44494"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35737@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 27 23:14:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVMwm-000BUX-OB for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 May 2019 23:14:20 +0200 Original-Received: from localhost ([127.0.0.1]:50974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVMwl-0002mt-En for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 May 2019 17:14:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVMwX-0002lO-HR for bug-gnu-emacs@gnu.org; Mon, 27 May 2019 17:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVMwU-000899-EA for bug-gnu-emacs@gnu.org; Mon, 27 May 2019 17:14:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVMwU-000895-BV for bug-gnu-emacs@gnu.org; Mon, 27 May 2019 17:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVMwU-0003vu-4M for bug-gnu-emacs@gnu.org; Mon, 27 May 2019 17:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2019 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35737 X-GNU-PR-Package: emacs Original-Received: via spool by 35737-submit@debbugs.gnu.org id=B35737.155899162615081 (code B ref 35737); Mon, 27 May 2019 21:14:02 +0000 Original-Received: (at 35737) by debbugs.gnu.org; 27 May 2019 21:13:46 +0000 Original-Received: from localhost ([127.0.0.1]:54343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVMwE-0003vB-6k for submit@debbugs.gnu.org; Mon, 27 May 2019 17:13:46 -0400 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:43855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVMwC-0003uh-0B for 35737@debbugs.gnu.org; Mon, 27 May 2019 17:13:45 -0400 Original-Received: by mail-wr1-f51.google.com with SMTP id l17so9597046wrm.10 for <35737@debbugs.gnu.org>; Mon, 27 May 2019 14:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t2E6APHIENP/aUnfWG3pG2kyJnhUCCJTU7j6xaM7ztM=; b=unDQnyRD7Lvz2WZVVy1jec1a1PE3urRUPTfUWfIjKnrNVVNe7ug8Cc/gnQK+08xW+m BAV/CbGElcMwxCgBZaLc+9CoJzqVkBjkcs2trwFEgAJGQHtoSdVmjJJyKQt2mGcWUswm p8eAZ6vxqMlRojTHDI5cCbKaqyx2fJc21Z4Vle222rNSrD+xKH6VbdJMBLWX+hI47a71 vIteM2mX8j+qDwanausrXEcfOzAfLYbw5/vWuFAEsQQIZTjwG2CIJAPW2rmEm1j488Jq fdW3r2S3HT/mGK0U5Dkwuz/VHU71nGJnGn8obXbsUZ69FSZ8JdDS+K6lVuXIy8/iPPaf LYlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t2E6APHIENP/aUnfWG3pG2kyJnhUCCJTU7j6xaM7ztM=; b=NkgP2c7Zm+1w6xZ2KeuPQlhEuSCwm2HZMBTxHkQw91YMMYRy/0cSoV4/EVwkSfMGE6 onjc6vQCx9+vUsUKvW9GK/yu58KE0K5jwgPn1PPu9XClvIDJ1w83U/yO23jDf99Owbvv 6t76I/Bkjwwg73JDLZ0ZHkhfqcpiuByi02Yy4ulW6+Oigk6Zki+ulx6BXF1GrKl2Y8Xu 3Gz1NWXOgslUJDCeIo+cFlY+59ahaPcONIEG/kqxTSgI5WNeaDrDYRiMfJXfBNWAy25Z ikz4zlM7noVv/fpOGYTM+diDePxDrLO9YCmHSH6SAb/OQm669I6RafVO+hI8EAreYd7E SZ5g== X-Gm-Message-State: APjAAAXHnrEQ3A49Q9FmJ3nje8U39U6z1lScZ36GHZJ6QiFKW9DNlJWO tpwF1v8UfPjTz4/ztlDXlnA/SXi6 X-Google-Smtp-Source: APXvYqzAYdwzRx0Wl6efBN9ap8LgULOpmAw9DJOok1SKwBr7A/iv+AxT6OlfB578MnuGV3/eY2cNSg== X-Received: by 2002:adf:83c5:: with SMTP id 63mr45979368wre.33.1558991617899; Mon, 27 May 2019 14:13:37 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id u10sm439844wml.42.2019.05.27.14.13.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 May 2019 14:13:37 -0700 (PDT) In-Reply-To: <8736kzekie.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159830 Archived-At: On 27.05.2019 22:59, Juri Linkov wrote: > Thanks. I wonder why you renamed xref--revert-xref-buffer > to a such strange name xref-refresh-results? Why not simply > xref-revert-buffer? Strange? I had to think how to describe the new command in NEWS, and these are the terms I came up with. Hence the name. Do you not think these words are appropriate? "revert buffer" sounds like undoing changes, and we're repeating a search and refreshing (or maybe reloading) the results. > The goal was to improve the default behavior to make customization easier. That's why I added xref-show-definitions-function. Customizing display-buffer-alist is an arcane art. The hook this variable provides should be easier to understand for an average user. So, to clarify, you're not interested in changing the *visible* default behavior, at least for now? >> TBH, xref--original-command is easy to add, but then we'll have an internal >> variable that isn't used anywhere. Somebody will just delete it someday. > > The idea was to make xref more customizable differently for different > commands: xref-find-definitions, xref-find-references, project-find-regexp. I get the idea, but not the goal. I know why we'd want to make xref-find-definitions and project-find-regexp to behave differently. The rest, I'm not so clear. Anyway, I was hoping my efforts in improving the default behavior would benefit your goals as well, but it seems the split between xref--show-xrefs and xref--show-defs goes against them. That's too bad. You still have your alternative solution, though.