From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 35737@debbugs.gnu.org
Subject: bug#35737: xref--original-command
Date: Tue, 28 May 2019 00:13:34 +0300 [thread overview]
Message-ID: <413fa232-ea7f-bd6a-ecce-632962a7f57e@yandex.ru> (raw)
In-Reply-To: <8736kzekie.fsf@mail.linkov.net>
On 27.05.2019 22:59, Juri Linkov wrote:
> Thanks. I wonder why you renamed xref--revert-xref-buffer
> to a such strange name xref-refresh-results? Why not simply
> xref-revert-buffer?
Strange?
I had to think how to describe the new command in NEWS, and these are
the terms I came up with. Hence the name. Do you not think these words
are appropriate?
"revert buffer" sounds like undoing changes, and we're repeating a
search and refreshing (or maybe reloading) the results.
> The goal was to improve the default behavior to make customization easier.
That's why I added xref-show-definitions-function.
Customizing display-buffer-alist is an arcane art. The hook this
variable provides should be easier to understand for an average user.
So, to clarify, you're not interested in changing the *visible* default
behavior, at least for now?
>> TBH, xref--original-command is easy to add, but then we'll have an internal
>> variable that isn't used anywhere. Somebody will just delete it someday.
>
> The idea was to make xref more customizable differently for different
> commands: xref-find-definitions, xref-find-references, project-find-regexp.
I get the idea, but not the goal. I know why we'd want to make
xref-find-definitions and project-find-regexp to behave differently. The
rest, I'm not so clear.
Anyway, I was hoping my efforts in improving the default behavior would
benefit your goals as well, but it seems the split between
xref--show-xrefs and xref--show-defs goes against them. That's too bad.
You still have your alternative solution, though.
next prev parent reply other threads:[~2019-05-27 21:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 20:53 bug#35737: xref--original-command Juri Linkov
2019-05-15 1:07 ` Dmitry Gutov
2019-05-15 21:04 ` Juri Linkov
2019-05-15 22:30 ` Dmitry Gutov
2019-05-16 19:58 ` Juri Linkov
2019-05-24 1:59 ` Dmitry Gutov
2019-05-24 18:40 ` Juri Linkov
2019-05-24 22:48 ` Dmitry Gutov
2019-05-27 19:59 ` Juri Linkov
2019-05-27 21:13 ` Dmitry Gutov [this message]
2019-05-27 23:21 ` Dmitry Gutov
2019-05-28 2:41 ` Eli Zaretskii
2019-05-28 7:46 ` Dmitry Gutov
2019-05-28 15:01 ` Eli Zaretskii
2019-05-28 20:30 ` Juri Linkov
2019-05-30 17:33 ` Dmitry Gutov
2019-06-09 23:44 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413fa232-ea7f-bd6a-ecce-632962a7f57e@yandex.ru \
--to=dgutov@yandex.ru \
--cc=35737@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.