From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14925: 24.3.50; `image-dired.el' code (minor) Date: Thu, 25 Jul 2013 22:31:06 -0700 (PDT) Message-ID: <40a97f39-de0b-41a5-a0af-54bc37e66083@default> References: <6a9c11fa-71ad-44f9-9771-35626a56ee01@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1374816730 13612 80.91.229.3 (26 Jul 2013 05:32:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Jul 2013 05:32:10 +0000 (UTC) Cc: 14925@debbugs.gnu.org To: Drew Adams , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 26 07:32:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V2adM-0007Nt-Kk for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2013 07:32:08 +0200 Original-Received: from localhost ([::1]:37458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2adM-0000Kv-0N for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2013 01:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2adH-0000Ka-RH for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2013 01:32:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2adH-0006aY-0a for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2013 01:32:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2adG-0006aT-Tt for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2013 01:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V2adG-0001B0-Lw for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2013 01:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2013 05:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14925 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14925-submit@debbugs.gnu.org id=B14925.13748166794390 (code B ref 14925); Fri, 26 Jul 2013 05:32:02 +0000 Original-Received: (at 14925) by debbugs.gnu.org; 26 Jul 2013 05:31:19 +0000 Original-Received: from localhost ([127.0.0.1]:50316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V2acY-00018j-MU for submit@debbugs.gnu.org; Fri, 26 Jul 2013 01:31:18 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:32100) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V2acW-00018V-Fx for 14925@debbugs.gnu.org; Fri, 26 Jul 2013 01:31:17 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r6Q5V8Ma032747 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Jul 2013 05:31:09 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6Q5V7b4016576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Jul 2013 05:31:08 GMT Original-Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6Q5V7Z3022930; Fri, 26 Jul 2013 05:31:07 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76670 Archived-At: > > > 1. `image-dired-dired-file-marked-p' uses regexp "^ .*$", which I thi= nk > > > is the same as "^ " (which is simpler). > > > > It's similar, except for (match-end 0) and the position of point after > > re-search-forward. I haven't looked at the code to see if the > > difference matters. >=20 > It does not; the match data and the position of point are not used. > (The `-p' suffix provides a clue.) There is currently only one occurrenc= e > of `image-dired-dired-file-marked-p': >=20 > (if (image-dired-dired-file-marked-p) > (dired-unmark 1) > (dired-mark 1)) It also uses `save-excursion' and `looking-at', not `re-search-forward'. However, as it is in principle just a predicate it should probably also use `looking-at-p', not `looking-at'.